From: Bjorn Helgaas <helgaas@kernel.org>
To: Hans Zhang <18255117159@163.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/VPD: Add Realtek 8126 to VPD blacklist
Date: Mon, 9 Nov 2026 17:09:00 -0600 [thread overview]
Message-ID: <20261109230900.GA342555@bhelgaas> (raw)
In-Reply-To: <20260522114135.2104890-1-18255117159@163.com>
On Fri, May 22, 2026 at 07:41:34PM +0800, Hans Zhang wrote:
> The Realtek 8126 Ethernet controller advertises VPD capability but
> returns invalid data when VPD is read, leading to kernel messages
> like:
>
> r8169 ... invalid VPD tag 0x00 (size 0) at offset 0; assume
> missing optional EEPROM
>
> and pcilib reporting "sysfs_read_vpd: read failed: No such device".
>
> Add the device to the VPD blacklist to suppress these errors.
>
> Signed-off-by: Hans Zhang <18255117159@163.com>
Applied to pci/misc for v7.5, thank you!
> ---
> drivers/pci/vpd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/vpd.c b/drivers/pci/vpd.c
> index 153394a652d3..fbc34cd842ac 100644
> --- a/drivers/pci/vpd.c
> +++ b/drivers/pci/vpd.c
> @@ -590,6 +590,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LSI_LOGIC, 0x002f, quirk_blacklist_vpd);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LSI_LOGIC, 0x005d, quirk_blacklist_vpd);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LSI_LOGIC, 0x005f, quirk_blacklist_vpd);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATTANSIC, PCI_ANY_ID, quirk_blacklist_vpd);
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_REALTEK, 0x8126, quirk_blacklist_vpd);
> /*
> * The Amazon Annapurna Labs 0x0031 device id is reused for other non Root Port
> * device types, so the quirk is registered for the PCI_CLASS_BRIDGE_PCI class.
> --
> 2.43.0
>
prev parent reply other threads:[~2026-11-09 23:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 11:41 Hans Zhang
2026-05-22 11:43 ` Hans Zhang
2026-07-15 13:44 ` Manivannan Sadhasivam
2026-09-11 13:24 ` Hans Zhang
2026-11-08 8:57 ` Hans Zhang
2026-11-09 23:09 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109230900.GA342555@bhelgaas \
--to=helgaas@kernel.org \
--cc=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®