From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: stable@vger.kernel.org, "Sasha Levin" <sashal@kernel.org>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Sean Anderson" <sean.anderson@linux.dev>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6.18.y] net: macb: wait for a running xmit before resetting BQL on close
Date: Mon, 9 Nov 2026 09:10:06 -0500 [thread overview]
Message-ID: <2026110940-familiar-slick-4d2e@gregkh> (raw)
In-Reply-To: <20261109-nb-macb-close-6-18-y-v1-1-51af4b20dffb@tipi-net.de>
On Mon, Nov 09, 2026 at 01:57:09PM +0100, Nicolai Buchwitz wrote:
> macb_close() stops the queues without waiting for an xmit still
> running on another CPU. That frame charges BQL after the reset and
> never completes, so after the reopen the queue stays stopped with an
> empty ring and the watchdog fires until the next close.
>
> Seen on a Raspberry Pi CM5 with ethtool -G under load.
>
> Upstream fixed this as part of the context swap rework in commit
> dcc3288b9433a ("net: macb: use context swapping in .set_ringparam()"),
> which is too large for stable.
Why is that too large? Please backport that instead.
thanks,
greg k-h
next prev parent reply other threads:[~2026-11-09 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 12:57 Nicolai Buchwitz
2026-11-09 14:10 ` Greg Kroah-Hartman [this message]
2026-11-09 14:24 ` Nicolai Buchwitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026110940-familiar-slick-4d2e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=sashal@kernel.org \
--cc=sean.anderson@linux.dev \
--cc=stable@vger.kernel.org \
--cc=theo.lebrun@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®