From: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] ASoC: tegra: Fix potential NULL dereference on AHUB removal
Date: Tue, 10 Nov 2026 22:32:32 +0800 [thread overview]
Message-ID: <20261110-9f141e6bc8-asoc-tegra@mail.sdu.edu.cn> (raw)
I2S child removal releases its FIFOs and routes through the AHUB.
Leaving the children registered while removing the AHUB clears their
shared context before those cleanup operations can run.
Depopulate the children before disabling runtime PM and clearing ahub.
This issue was found by our static analysis tool under development.
Fixes: be944d42ccc1 ("ASoC: tegra: add tegra30-ahub driver")
Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
---
sound/soc/tegra/tegra30_ahub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c
index ee68f28852c4..fe04d19dd6c7 100644
--- a/sound/soc/tegra/tegra30_ahub.c
+++ b/sound/soc/tegra/tegra30_ahub.c
@@ -595,6 +595,7 @@ static int tegra30_ahub_probe(struct platform_device *pdev)
static void tegra30_ahub_remove(struct platform_device *pdev)
{
+ of_platform_depopulate(&pdev->dev);
pm_runtime_disable(&pdev->dev);
ahub = NULL;
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
--
2.43.0
reply other threads:[~2026-11-10 14:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110-9f141e6bc8-asoc-tegra@mail.sdu.edu.cn \
--to=liguangshuo@mail.sdu.edu.cn \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thierry.reding@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®