From: Sander Speetjens <sander.speetjens@gmail.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Eric Anholt <eric@anholt.net>, Stefan Wahren <wahrenst@gmx.net>,
Stephen Boyd <sboyd@kernel.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>
Cc: linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, sander.speetjens@gmail.com,
Manuel Ebner <manuelebnerli@mailbox.org>
Subject: [PATCH v3 0/5] firmware: raspberrypi: Style cleanups and fix child device lifetime
Date: Tue, 10 Nov 2026 17:47:46 +0100 [thread overview]
Message-ID: <20261110-fix-raspberrypi-firmware-v3-0-e001feb542dd@gmail.com> (raw)
This series does minor style cleanups in the Raspberry Pi firmware
driver and fixes the lifetime handling of the hwmon, clock and rtc child
devices.
The first five patches address checkpatch warnings (missing blank lines
after declarations, incorrect indentation, unnecessary braces, and
undocumented memory barriers).
The final patch moves the hwmon, clock and rtc platform device pointers from
globals into struct rpi_firmware. This pairs their lifetime with the
parent device and prevents leaks or incorrect unregistration if the
driver is probed more than once. It also checks the return value of
platform_device_register_data() so that an error pointer is never
stored. Registration failures are not propagated because the child
devices are optional.
---
Changes in v3:
- Update cover letter
- Remove braces fix
- Update commit message 6
- Link to v2: https://lore.kernel.org/r/20261107-fix-raspberrypi-firmware-v2-0-5bfe605a5cc5@gmail.com
Changes in v2:
- Move platform device pointers to rpi firmware struct
- Link to v1: https://lore.kernel.org/r/20261107-fix-raspberrypi-firmware-v1-0-707362c710cd@gmail.com
---
Sander Speetjens (5):
firmware: raspberrypi: Add blank line after declaration in response_callback
firmware: raspberrypi: Fix indentation of return statement
firmware: raspberrypi: Add blank line after declaration in probe error path
firmware: raspberrypi: Document memory barriers in property list path
firmware: raspberrypi: Store child devices in struct rpi_firmware
drivers/firmware/raspberrypi.c | 56 +++++++++++++++++++++++++++---------------
1 file changed, 36 insertions(+), 20 deletions(-)
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261107-fix-raspberrypi-firmware-be9c602d6755
Best regards,
--
Sander Speetjens <sander.speetjens@gmail.com>
next reply other threads:[~2026-11-10 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 16:47 Sander Speetjens [this message]
2026-11-10 16:47 ` [PATCH v3 1/5] firmware: raspberrypi: Add blank line after declaration in response_callback Sander Speetjens
2026-11-10 16:47 ` [PATCH v3 2/5] firmware: raspberrypi: Fix indentation of return statement Sander Speetjens
2026-11-10 16:47 ` [PATCH v3 3/5] firmware: raspberrypi: Add blank line after declaration in probe error path Sander Speetjens
2026-11-10 16:47 ` [PATCH v3 4/5] firmware: raspberrypi: Document memory barriers in property list path Sander Speetjens
2026-11-10 16:47 ` [PATCH v3 5/5] firmware: raspberrypi: Store child devices in struct rpi_firmware Sander Speetjens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110-fix-raspberrypi-firmware-v3-0-e001feb542dd@gmail.com \
--to=sander.speetjens@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=manuelebnerli@mailbox.org \
--cc=nsaenz@kernel.org \
--cc=sboyd@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®