From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794380198; b=H5twrCeBADEgfaas52i3tDbTbdOCWmF4YFoICaK4FfkIUoClZZNJGPXjVNGn9t/pPeaf re+jdQrNCREyY4he8Y8//Q8+UW2JbkVIquclcfaTxgOO5N8fq6WpQbHU/aCkwseo/XA4A /uKjdkfW9DR92kQcHdcURkUpIgQ8NeHKhRb3DFLb9KR5RV3Is6mIy+55R1TA+89O5fdlt mscL0i+ti7sv/LiK7a+MOYHQqSbRFITXBCuzNy3P21CvEdw2TPWdtW7YDyeR2NnFBdbff eEhobIAuGpr7IMs0yFhy80MJGabuWHk0L6LDJMLImkV1KV0tZtAoErpktsL6shDsGHw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794380198; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer; bh=4PtICXQgYMF5gi3lR+RueE2sIoPdSSjd+glcQFFLPog=; b=zkIClNepkwBMR9jJw42wMRMpePGW1+MhV2BBruPiIy4ul6b1ZKwuc2AV2CVj8LGQ68cP 8cnr54DvV5ZwmFhp55/UAq9ApHD7cJXnJyRDyev7yh/QoNs9oouhq0NZTJkkJpVpHfaoG V6kmDwTaTfeOcYMOmbRE/HloPIR6ln3InS7P/DnORFO+KEMIGb5lMCAub+935Jbqv0G6B 44Ujp9lhkvkhe2BO4vpv/02GxZ5AbrNOixwb1O52FRXaAHPzQGD0VMx7CUmkfJ7tp4zLi vvg3bKUA8OCs/qXztre8SDcs5CqpgEe7W/FWIXAQ3GyVzFB6ifvcbJ3p5vU7MDExF2w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=KQA9R7gP; arc=none smtp.remote-ip=74.125.82.41 Received: from mail-dl1-f41.google.com (mail-dl1-f41.google.com [74.125.82.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49EBF60A2617 for ; Wed, 11 Nov 2026 06:56:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 49EBF60A2617 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=KQA9R7gP Received: by mail-dl1-f41.google.com with SMTP id a92af1059eb24-1a2af4c8d00so2219030c88.0 for ; Tue, 10 Nov 2026 22:56:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794380197; x=1794984997; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4PtICXQgYMF5gi3lR+RueE2sIoPdSSjd+glcQFFLPog=; b=KQA9R7gPgWoq5fnFAXy74KLk14GsFWmhDVpN4+RCIoo6MItoK+p9j7PCe7iJ+pBFwl WzvErcP3LauXWLrFZJ5g/VE8O6cMvPEpiJ86rjL4zC+3lKybDwvGA35mJZeoU20Kt1vE qoQ1s8Wxlbdl8eYhrkz4gcmNsFD2lTS7eU7P75tVaK6DdDIwdWG3tXF5lu8F2iWC5o6T ikhlrbsLvqSD0R4J9HWOoY+kxpZRQxi/wHozKMN7zwAjxYzEW5bvslhtU53sn8/HlPEb ieyWfkFjaBbFcA0eM/ZbZ9cHJde2X7yoY3vySesKMe+nfhKt7uEquVCNvO0B3MFmrWsk hmXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794380197; x=1794984997; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4PtICXQgYMF5gi3lR+RueE2sIoPdSSjd+glcQFFLPog=; b=zIzTzQ/SFT/ufG7tshdEngHxnZqDwSJWdaRIg0AlxbOrCG9LdBPJwQmjWuLYi45ILm 72bJ8SVXvkYmn4rleMjRN+NfRCXOwe5ls+g6qnalaD+mIUuZDEg32Gers8qSuCcW7R8Z oCYXik6rWdDpfoe/264xT2Qvdf3kUVxlRwebEap0vQ2Vh3kdwGvJcrieVAXCZOyiVml3 M7BW/XSYUsEpIXVKB3+mC8nZcTa/qnuXj/NJl0PPPPi4timypehUbCPDY1Kj9WjfGKn8 YodSiDFBFFEybUyH3L+NyIlKoq56GxRPZ3ZgPbZ92/BG8375QdYc9VvbM8ZVkGYPN1If eIpw== X-Forwarded-Encrypted: i=1; AL+hErFzDfu50q/d/IIc/Vs/uXrP+4X8AAN7zHTB9S16QrZsvy1wICXKVBJ+W06vrdBXKEqJv0a5LBUuptsLyp0=@vger.kernel.org X-Gm-Message-State: APuU4Z9ZTBrFoOqSpOChRoRnYauJ30mYzdYNqjqTB2VbqGrz9GM9o7RM X1P219s7HuaDiHz7gyd3/sd41vjL/XzCi/6eZnzhby3JBwTD7NkLW9dM X-Gm-Gg: AYBFou2mg0cAzXFYK0DQsoHTaqIo8F6+ivSWw3vYL//fomRmOWxnS7uUp0NvF4RyL2L r10kjoMaWcx7uOOFrP6AXOvSRPWb8sZijUgpCG8SMjVo1DXmcmVNUlkyUHbLTPvh6comaBoOJRy MY06caMBsewBAvscRsExa9gK7BfZrR3tw5/LFGoEfRCdmTS1XxgRswJ4CJY5vhGarmDTp2/lrbo uGFJZsokhaFAVJUy2Y2myVvX7BYghH+FuTIdgJtq9b75uhHJwG27TuRl1sn3tyCFen0cU1MHO0c edt9JT8QhMVTNN/Oql+fVjkg4bOXdBZD2A85xV4THlKR4cabXxs+Ve52XYU3aB9joyfO2dnB/3D 98ypNd0QmG/f4zFa164nxPNkCcoWze3/0xWnS8TzhYXKY4SjGPZoN8bSCIRFD2df8NmiqZFAZaK 0rKz8HyCdQxeCp5rstT+VkWgba1TUfOt0ISzCWBP8MPrAILgCuERqcquAxYSo0yCDfoaDtmZ54c J2CI4uUh/UKn+3fZ4bWijfk5MktfEnDBk/NP1hCLZeHGCTvllHyJwo3M9JLvCeme763VHBCV+fp teEQgaTp/Q66qrJKXVAJPERSfohl/n+gFjIKMdT4pX4lS18lGbp7u3q0VTuENG+Dmrc/pDsGxb4 1mc34iyivvdBnv7jm0Q== X-Received: by 2002:a05:7022:5f05:b0:1b3:aee5:20c5 with SMTP id a92af1059eb24-1b3c0318483mr1532305c88.22.1794380197358; Tue, 10 Nov 2026 22:56:37 -0800 (PST) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:311a:ad7a:93f8:96c8]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b3b5b11435sm13858121c88.4.2026.11.10.22.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 22:56:36 -0800 (PST) From: Dmitry Torokhov Date: Tue, 10 Nov 2026 22:48:08 -0800 Subject: [PATCH v2 10/33] HID: logitech-hidpp: fix HID++ 1.0 battery mileage event parsing X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261110-hid-logitech-hidpp-v2-10-30743e91d83b@gmail.com> References: <20261110-hid-logitech-hidpp-v2-0-30743e91d83b@gmail.com> In-Reply-To: <20261110-hid-logitech-hidpp-v2-0-30743e91d83b@gmail.com> To: Jiri Kosina , Benjamin Tissoires , Gideon Heinz Cc: =?utf-8?q?Filipe_La=C3=ADns?= , Bastien Nocera , Hans de Goede , Edwin Velds , Stuart Hayhurst , Andrey Smirnov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-Mailer: b4 0.17-dev-e56a4 In HID++ 1.0 battery mileage event notifications (register 0x0d), the register address occupies the sub_id field rather than reg_address, so the payload bytes start at rawbytes[1] (parameter p0). The driver previously read capacity from report->rap.params[0] (rawbytes[2]), extracting parameter p1 instead of the battery mileage percentage. Additionally, when a change was detected, hidpp10_battery_event() updated level and status but neglected to update battery.capacity, leaving capacity frozen and triggering spurious power supply updates on every subsequent event. Read capacity from report->rawbytes[1] and store the updated capacity in hidpp->battery.capacity when changed. Fixes: 7f7ce2a258b4 ("HID: logitech-hidpp: enable HID++ 1.0 battery reporting") Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov --- drivers/hid/hid-logitech-hidpp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 16dcd79059d5..0ec2f2fd6dec 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -829,7 +829,7 @@ static int hidpp10_battery_event(struct hidpp_device *hidpp, u8 *data, int size) status = hidpp10_battery_status_map_status(report->rawbytes[2]); break; case HIDPP_REG_BATTERY_MILEAGE: - capacity = report->rap.params[0]; + capacity = report->rawbytes[1]; level = hidpp->battery.level; status = hidpp10_battery_mileage_map_status(report->rawbytes[3]); break; @@ -846,6 +846,7 @@ static int hidpp10_battery_event(struct hidpp_device *hidpp, u8 *data, int size) status == POWER_SUPPLY_STATUS_FULL; if (changed) { + hidpp->battery.capacity = capacity; hidpp->battery.level = level; hidpp->battery.status = status; if (hidpp->battery.ps) -- 2.56.0.542.g3ef89b7020-goog