From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=100.103.45.18 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1794295174; b=ZbmmBCNsI8zp6zRfN+dx81gQZeRRYBWm7LlNzR+KkkdMbYi8II4tygAX9gWE+wkgebwr gS1VmyoTNusspGKb54eAEEpQwBeyob/1J2bs7nRMZ4zDSeUEGSOi8raBU+5mK5lmM+oBn pQS7P4HnRM9+i9H1rCezwKBr4F0U2yZa6iq4JqV/ZDwItvalGv5OqMUgS1CgQW3hhQqrC L4iiR64RR274bmBeEGyI59rb2t8/8Xx3Ya8p+jCA0jZIGVN3YgscvfJfiOSkc7aeJyJYT 7SkoScxdmme1r6BdALF8MsqpcxDSuE3aBYgiJjpGFndMGdx2jMITjJXZDCUBz+LuWRA== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794295174; h=Received:DKIM-Signature:Received:From:Date:Subject:MIME-Version: Content-Type:Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Endpoint-Received: X-Original-From:Reply-To:Content-Transfer-Encoding; bh=9m1iAeouVAj4F1HOa9zNEIXietvCGZ4AUJji/MyAt+Q=; b=r/nQ6ixi6Dsx5AK3TBytY137MRxqMYoTGjcbQ1gjOtXQUDEFpWwbWUpTQMrRD4anQP94 bRE9HZr80CQN6WbYb+YIKPs+CGpqoKwKygYhNmae8MkubxR6pWiy3e/sm1EsNMTFiTyhM faHn409m6ajs3rzad4g0wjBsuZt7RMvlPw6WIZfnl+KpNMhSKkJHwqyRXXk9z2kYkAqwB H3L6LRSdAc5a6zK0Z0d4IZIYOICX/T4qoD/AKkbIqWGUinRffekrJ4RZjE5xxBxOBBbCe BYmFJY84JsYshRMu9fDdxgT5Ti8Vzvo1OiQT2MtjzsgtHcSuSeZ2e9F9bgpyByNe+hw== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=iAi+wyB2; arc=pass header.oldest-pass=0 smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 440D5606D631; Tue, 10 Nov 2026 07:19:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=iAi+wyB2 Authentication-Results: smtp.kernel.org; arc=none smtp.remote-ip=100.80.115.77 ARC-Seal: i=1; d=kernel.org; s=arc20260519; a=rsa-sha256; cv=none; t=1794295174; b=stY7AnjsV5+hxqpQbFWhUAAiPtMkoU88acSi9uH3uhxbMNAYHvyYBUlPKFMyAsv83RmC yiRnCqZ2sUbzawz1xBW4MkoK8M0NOBg53JUm257DCANMNLrATFOKDHusSaEkbACe0vM0M fBBnJbTPveFr8QxVvT9WtrQ7GfbYGggHsoZSrySoNz0zy1tns+Z6DkhI+LaMT+fTX0CqL 8DQHh9R3AqjCv0bbowRcOTeUYrTqooGG/o/cQQqnPXwrPJY/IWky4wJfi5RlowFd4B+ZC JZX755h5BPbXczupPGNhbo9gOUbBGSOHy/oFc2AB2+40M893e9gZxD40YKlje5fH20g== ARC-Message-Signature: i=1; d=kernel.org; s=arc20260519; a=rsa-sha256; c=relaxed/relaxed; t=1794295174; h=DKIM-Signature:Received:From:Date:Subject:MIME-Version:Content-Type: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Endpoint-Received: X-Original-From:Reply-To:Content-Transfer-Encoding; bh=9m1iAeouVAj4F1HOa9zNEIXietvCGZ4AUJji/MyAt+Q=; b=NYTO4j0ktZ8/XNOR7vb6/YXcChT04T6EveseBcPlJhUs846t8zSkwuZcLVAJ2X269EOV SJw0FR0W8Lh/VbegY83DBGWThYS9JfsOGuY/8rOUphlX2CnBg3yDd8n4n9qVaVeEwerhL +j5Y0LKPq2sGSm84xH6IWZs0ruKsUKJecG5wTe5NAQzAiFyiKfoJ7zvifZF2JaUNewR0e ZhcCXxYyf1H32F3tmyupA0Je8Kwnzly9Wf9J9HivZCN7r9jAg6Q/EPwoifbgTLpYYFRLF gZnzt/PbnlBUGrLGuvB37n5P6zn9wPLorN6mSIsyrBZpw/oRvKs4cVTVio0HDV5gXuQ== ARC-Authentication-Results: i=1; smtp.kernel.org; arc=none smtp.remote-ip=100.80.115.77 Received: from lkml.kernel.org (nexus.subspace.kernel.org [100.80.115.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 8AFFD1F008A1; Tue, 10 Nov 2026 07:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794295174; bh=9m1iAeouVAj4F1HOa9zNEIXietvCGZ4AUJji/MyAt+Q=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To; b=iAi+wyB24SUzRN7Laxt3DST7CGzdlCsf+NpaLeF5Xsce6ksrlS1dpgft2E0vh1R3W lfGAqDds1Y+clTW/eCAR2ayIVPxORVhCq564P+A2FLX9rr88OOSqP54fv06fYvFr3D OcZXas+fqDGYgmydmc5x+Q2UT95SCzAIzOZjKvGyes7C6NFJcEIkdhhGg3gQ8rg8iP w4e6mw1ih5e8jvX1dVjzLVHKPqTmJNCEHJBz/KmhXoEZgG9heRLCiEWv4Xlcd6NZIv 6mOeCAc8sJBxakSd+i6onllX/3tB09HWXcd28rrHYiaoxgtKhV7y17Ur6Eb/B9P5SB bLO818GHVfrJQ== Received: from nexus.subspace.kernel.org (localhost [IPv6:::1]) by lkml.kernel.org (Postfix) with ESMTP id 1FF46489BD; Tue, 10 Nov 2026 07:19:33 +0000 (UTC) From: Arun Iyengar via B4 Relay Date: Tue, 10 Nov 2026 07:19:33 +0000 Subject: [PATCH 1/3] arm64: dts: rockchip: use rgmii-id for the Orange Pi 5/5B ethernet PHY X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Message-Id: <20261110-opi5-dts-v1-1-582b63d074be@gmail.com> References: <20261110-opi5-dts-v1-0-582b63d074be@gmail.com> In-Reply-To: <20261110-opi5-dts-v1-0-582b63d074be@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1794295172; l=1895; i=aiyengar1990@gmail.com; s=20261110; h=from:subject:message-id; bh=tvDxnxzJS+qXTLT+S+2SEXSC6rLShYZjDQnh9IALLos=; b=KKWIzOxcaNMe8ftleSNYT2RAzatFYKNDsM0hJ+ZT9gzxNp9n6GiVSLnuWoGh6GB7QIT2+iaZ5 WBWjPYSD2T4BbFAIEdJQJaG+N4pYaqM2vVK9II35mxoc0otEw4FLRuy X-Developer-Key: i=aiyengar1990@gmail.com; a=ed25519; pk=zXpRgUTrhaFe6jLyPqbBy3ccfkj04w0g2690Wv3mg+0= X-Endpoint-Received: by B4 Relay for aiyengar1990@gmail.com/20261110 with auth_id=1480 X-Original-From: Arun Iyengar Reply-To: aiyengar1990@gmail.com Content-Transfer-Encoding: 7bit From: Arun Iyengar The Orange Pi 5 and 5B have a Motorcomm YT8531C RGMII PHY on gmac1 (the PHY driver binds as "YT8531 Gigabit Ethernet"). The board neither uses extra long clock traces for TX nor for RX, yet the device tree describes it as "rgmii-rxid", which according to ethernet-controller.yaml means that the PCB provides the TX delay, and then makes the MAC insert the TX delay with tx_delay = <0x42>. The setting was copied from the vendor kernel, which uses the MAC delay lines everywhere. Describe the PCB correctly as "rgmii-id" and drop tx_delay, so that the MAC adds no delay and the PHY adds both: motorcomm.c programs its default 1950 ps for RX (as now) and for TX. This is the setup the binding recommends, and the one the same vendor's Orange Pi CM5 (rk3588s-orangepi-cm5-base.dts), with a YT8531C on gmac1 of the same SoC, already uses in mainline. Besides being the correct description, this removes the MAC from the timing path for both directions, so no board-specific delay-line value is needed any more. Signed-off-by: Arun Iyengar --- arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-5b.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-5b.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-5b.dtsi index c153e7248727..7c1fd5905553 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-5b.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-5b.dtsi @@ -97,14 +97,13 @@ vcc_3v3_sd_s0: regulator-vcc-3v3-sd-s0 { &gmac1 { clock_in_out = "output"; phy-handle = <&rgmii_phy1>; - phy-mode = "rgmii-rxid"; + phy-mode = "rgmii-id"; pinctrl-0 = <&gmac1_miim &gmac1_tx_bus2 &gmac1_rx_bus2 &gmac1_rgmii_clk &gmac1_rgmii_bus>; pinctrl-names = "default"; - tx_delay = <0x42>; status = "okay"; }; -- 2.55.0