mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	 Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	 Lukasz Luba <lukasz.luba@arm.com>,
	 Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 kernel-team@meta.com, Breno Leitao <leitao@debian.org>
Subject: [PATCH] thermal: intel: powerclamp: Do not log an error on unsupported CPUs
Date: Tue, 10 Nov 2026 07:26:47 -0800	[thread overview]
Message-ID: <20261110-powerclamp_mwait_msg-v1-1-18c03fa17ebe@debian.org> (raw)

powerclamp_probe() returns -ENODEV unless x86_match_cpu() finds an
Intel CPU with MWAIT, and logs "CPU does not support MWAIT" at KERN_ERR
when it does not.

As a result, a kernel with CONFIG_INTEL_POWERCLAMP=y logs this error on
every boot on a non-Intel CPU.

  # grep -m1 vendor_id /proc/cpuinfo
  vendor_id	: AuthenticAMD
  # grep -m1 -o -w monitor /proc/cpuinfo
  monitor
  # dmesg -l err | grep intel_powerclamp:
  [    0.485728] intel_powerclamp: CPU does not support MWAIT

At KERN_ERR the line also gets past "quiet" and lands on the console,
and on kernel metrics.

Reduce it to debug, and also name both conditions in the message.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/thermal/intel/intel_powerclamp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/intel/intel_powerclamp.c b/drivers/thermal/intel/intel_powerclamp.c
index 1ffcb0a699e57d..82587dc8b0156f 100644
--- a/drivers/thermal/intel/intel_powerclamp.c
+++ b/drivers/thermal/intel/intel_powerclamp.c
@@ -695,7 +695,7 @@ static int __init powerclamp_probe(void)
 {
 
 	if (!x86_match_cpu(intel_powerclamp_ids)) {
-		pr_err("CPU does not support MWAIT\n");
+		pr_debug("CPU is not Intel or does not support MWAIT\n");
 		return -ENODEV;
 	}
 

---
base-commit: 630059a5a632377b9b7b487baccde92b7ae1dd47
base-tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
change-id: 20261110-powerclamp_mwait_msg-93bac0782c79

Best regards,
--  
Breno Leitao <leitao@debian.org>


                 reply	other threads:[~2026-11-10 15:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110-powerclamp_mwait_msg-v1-1-18c03fa17ebe@debian.org \
    --to=leitao@debian.org \
    --cc=daniel.lezcano@kernel.org \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®