From: Conor Dooley <conor@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: dmitry.torokhov@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, mkorpershoek@kernel.org, clamor95@gmail.com,
Frank.Li@nxp.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: input: touchscreen: tsc2007: allow standard properties
Date: Tue, 10 Nov 2026 18:33:00 +0000 [thread overview]
Message-ID: <20261110-probably-vertical-70723be84cfb@spud> (raw)
In-Reply-To: <20261110113019.404706-1-andreas@kemnade.info>
[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]
On Tue, Nov 10, 2026 at 12:30:19PM +0100, Andreas Kemnade wrote:
> The driver accepts touchscreen standard properties, so allow them.
This is the wrong justification, the justification needs to be that the
hardware requires them for xyz reason.
pw-bot: changes-requested
Thanks,
Conor.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> .../devicetree/bindings/input/touchscreen/ti,tsc2007.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2007.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2007.yaml
> index 5ef38d24d6a97..b8a11631183e1 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2007.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2007.yaml
> @@ -9,6 +9,9 @@ title: Texas Instruments tsc2007 touchscreen controller
> maintainers:
> - Frank Li <Frank.Li@nxp.com>
>
> +allOf:
> + - $ref: touchscreen.yaml#
> +
> properties:
> compatible:
> const: ti,tsc2007
> @@ -61,7 +64,7 @@ required:
> - reg
> - ti,x-plate-ohms
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
> --
> 2.47.3
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-11-10 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 11:30 Andreas Kemnade
2026-11-10 18:33 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110-probably-vertical-70723be84cfb@spud \
--to=conor@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=andreas@kemnade.info \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkorpershoek@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®