From: Joas Antonio dos Santos via B4 Relay <devnull+joasantonio108.gmail.com@kernel.org>
To: joasantonio108@gmail.com, david@ixit.cz, krzk@kernel.org
Cc: oe-linux-nfc@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, horms@kernel.org
Subject: [PATCH RESEND v2 0/2] nfc: st21nfca: fix SE APDU request race condition
Date: Tue, 10 Nov 2026 03:22:54 +0000 [thread overview]
Message-ID: <20261110-st21nfca-v2-v2-0-cf9102b314cb@gmail.com> (raw)
Fix a race between the timeout work handler and the EVT_TRANSMIT_DATA
event handler that can lead to a double invocation of the SE APDU
callback, resulting in use-after-free or double-free of the callback
context.
Split into two patches:
1/2: Add a spinlock to serialize access to bwi_active, cb, and
cb_context across the three concurrent paths.
2/2: Use the lock to guard against double completion and reject
overlapping requests.
Changes since v1:
- Use spinlock instead of plain bwi_active flag checks (Simon Horman)
- Split into 2-patch series: locking infrastructure + completion fix
- Move bwi_active = true before mod_timer()
- Copy cb/cb_context under lock, invoke after releasing
- Reject overlapping se_io requests with -EBUSY
- Drop Assisted-by trailer
---
Joas Antonio dos Santos (2):
nfc: st21nfca: add spinlock to serialize SE APDU request state
nfc: st21nfca: prevent double completion of SE APDU request
drivers/nfc/st21nfca/se.c | 36 ++++++++++++++++++++++++++++++++----
drivers/nfc/st21nfca/st21nfca.h | 2 ++
2 files changed, 34 insertions(+), 4 deletions(-)
---
base-commit: 602042bf29f6efde39cfb5fdd9289bf4854bc0c5
change-id: 20261108-st21nfca-v2-f4c5f861e416
Best regards,
--
Joas Antonio dos Santos <joasantonio108@gmail.com>
next reply other threads:[~2026-11-10 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 3:22 Joas Antonio dos Santos via B4 Relay [this message]
2026-11-10 3:22 ` [PATCH RESEND v2 1/2] nfc: st21nfca: add spinlock to serialize SE APDU request state Joas Antonio dos Santos via B4 Relay
2026-11-10 3:22 ` [PATCH RESEND v2 2/2] nfc: st21nfca: prevent double completion of SE APDU request Joas Antonio dos Santos via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110-st21nfca-v2-v2-0-cf9102b314cb@gmail.com \
--to=devnull+joasantonio108.gmail.com@kernel.org \
--cc=david@ixit.cz \
--cc=horms@kernel.org \
--cc=joasantonio108@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-linux-nfc@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®