mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: David Ahern <dsahern@kernel.org>,
	Ido Schimmel <idosch@nvidia.com>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,  Simon Horman <horms@kernel.org>,
	Shuah Khan <shuah@kernel.org>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	 linux-kernel@vger.kernel.org, Petr Machata <petrm@nvidia.com>,
	 Hannes Laimer <h.laimer@proxmox.com>
Subject: [PATCH net-next] selftests: forwarding: vxlan_reserved: drop redundant in_defer_scope
Date: Tue, 10 Nov 2026 15:03:55 +0100	[thread overview]
Message-ID: <20261110-vxlan-reserved-tests-v1-1-a252d69c841e@proxmox.com> (raw)

With commit a6e263f125cd ("selftests: net: lib: Introduce deferred
commands") tests_run() already runs every test in its own defer scope.
So the per-test in_defer_scope here does not do anything. Drop the
in_defer_scope calls and the wrappers that only exist for that.

Suggested-by: Petr Machata <petrm@nvidia.com>
Link: https://lore.kernel.org/all/875wyo6b7d.fsf@pmachata.org/
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 .../selftests/net/forwarding/vxlan_reserved.sh     | 39 +++++-----------------
 1 file changed, 8 insertions(+), 31 deletions(-)

diff --git a/tools/testing/selftests/net/forwarding/vxlan_reserved.sh b/tools/testing/selftests/net/forwarding/vxlan_reserved.sh
index 0ce264cc57f8..a273e1fcd26c 100755
--- a/tools/testing/selftests/net/forwarding/vxlan_reserved.sh
+++ b/tools/testing/selftests/net/forwarding/vxlan_reserved.sh
@@ -273,30 +273,18 @@ __default_test_do()
 	log_test "$what: drops reported"
 }
 
-default_test_do()
+default_test()
 {
 	vxlan_device_add
 	__default_test_do 0 "Default"
 }
 
-default_test()
-{
-	in_defer_scope \
-	    default_test_do
-}
-
-plain_test_do()
+plain_test()
 {
 	vxlan_device_add reserved_bits 0xf7ffffff000000ff
 	__default_test_do 0 "reserved_bits 0xf7ffffff000000ff"
 }
 
-plain_test()
-{
-	in_defer_scope \
-	    plain_test_do
-}
-
 reserved_test()
 {
 	local bit=$1; shift
@@ -311,35 +299,30 @@ reserved_test()
 
 reserved_0_test()
 {
-	in_defer_scope \
-	    reserved_test 0
+	reserved_test 0
 }
 
 reserved_10_test()
 {
-	in_defer_scope \
-	    reserved_test 10
+	reserved_test 10
 }
 
 reserved_31_test()
 {
-	in_defer_scope \
-	    reserved_test 31
+	reserved_test 31
 }
 
 reserved_56_test()
 {
-	in_defer_scope \
-	    reserved_test 56
+	reserved_test 56
 }
 
 reserved_63_test()
 {
-	in_defer_scope \
-	    reserved_test 63
+	reserved_test 63
 }
 
-gbp_changelink_test_do()
+gbp_changelink_test()
 {
 	vxlan_device_add gbp
 	__default_test_do 25 "gbp"
@@ -347,12 +330,6 @@ gbp_changelink_test_do()
 	__default_test_do 25 "gbp after changelink"
 }
 
-gbp_changelink_test()
-{
-	in_defer_scope \
-	    gbp_changelink_test_do
-}
-
 trap cleanup EXIT
 
 setup_prepare

---
base-commit: 6db9448a443afde26231aaed7b112ed17b33f468
change-id: 20261026-vxlan-reserved-tests-f2ceea83bb0c

Best regards,
--  
Hannes Laimer <h.laimer@proxmox.com>



             reply	other threads:[~2026-11-10 14:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 14:03 Hannes Laimer [this message]
2026-11-10 15:41 ` Petr Machata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110-vxlan-reserved-tests-v1-1-a252d69c841e@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®