Re: [PATCH ath-next v2 1/2] wifi: ath12k: report no AFC memory region to firmware

[Goran Sustek <gsustek@gmail.com>]

On 11/3/2026 6:17 AM, Rameshkumar Sundaram wrote:
> What do you mean by "bus address" here? Do you mean the DMA address
> provided in chunk->paddr?

Yes, the DMA address in chunk->paddr. v3 says that.

> Also, the paragraph below makes it sound like without this change the
> firmware doesn't send the memory ready indication and the radios don't
> come up, which isn't the case. There is no visible functional issue
> being fixed here. Please update the commit message to precisely describe
> what changes with this patch.

Agreed, there is none. v3 states that the firmware comes up with or
without the change, and describes only what changes in the response:
size 0 instead of the requested size for a segment the host does not
provide.

> I'd rather move chunk->size = 0 to the default: case. That way, all
> unsupported memory region types are consistently reported with size 0.

Done in v3: one line in the default case, no AFC case and no new enum
value. I also restored the existing warning. v2 had moved it to debug
level, which hides a request the driver does not implement; that was
wrong.

Thanks for the review.

Goran