mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrea Mayer <andrea.mayer@uniroma2.it>
To: Boyan Liu <yymhvert@gmail.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>,
	David Ahern <dsahern@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	co+98d7de09cd94fec5@bugs.sh, co+cdeaa2edb6897680@bugs.sh,
	Stefano Salsano <stefano.salsano@uniroma2.it>,
	Hangbin Liu <hangbin.liu@linux.dev>,
	Andrea Mayer <andrea@common-net.org>,
	Andrea Mayer <andrea.mayer@uniroma2.it>
Subject: Re: [PATCH net v3] seg6: Fix unset mac header in SRv6 End.DT VRF decapsulation
Date: Tue, 10 Nov 2026 01:37:43 +0100	[thread overview]
Message-ID: <20261110013743.101dc3309db53ade8d6bb24e@uniroma2.it> (raw)
In-Reply-To: <20261106065607.3372-1-yymhvert@gmail.com>

On Fri,  6 Nov 2026 14:56:07 +0800
Boyan Liu <yymhvert@gmail.com> wrote:

> Hi Andrea,
>
> It has been about two weeks since you mentioned that you were
> looking into the NFQUEUE case.

Hi Boyan,

I followed up on the NFQUEUE case on 26 Oct, in this reply to the v3:

https://lore.kernel.org/netdev/20261026003415.f7c46fa5a495144c29c03a07@uniroma2.it/

> My understanding is that NFQUEUE is the remaining open question
> for v3. Did you get a chance to check it? Should I prepare a v4
> to address that case, or is the current approach acceptable?

As I wrote there, setting the mac header at the network header with
mac_len 0 looks fine, and the reported crash is gone with v3 in my
tests. The NFQUEUE case in the Sashiko review also exists without this
patch, so it is not introduced by v3. On the SRv6 side, I think the
current approach is acceptable, and the NFQUEUE case can be handled
separately.

Ciao,
Andrea

  reply	other threads:[~2026-11-10  0:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21  2:47 Boyan Liu
2026-10-22  5:19 ` Hangbin Liu
2026-10-23  2:49 ` netdev-bot+sashiko
2026-10-23 23:58 ` Andrea Mayer
2026-11-06  6:56   ` Boyan Liu
2026-11-10  0:37     ` Andrea Mayer [this message]
2026-10-25 23:34 ` Andrea Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110013743.101dc3309db53ade8d6bb24e@uniroma2.it \
    --to=andrea.mayer@uniroma2.it \
    --cc=andrea@common-net.org \
    --cc=co+98d7de09cd94fec5@bugs.sh \
    --cc=co+cdeaa2edb6897680@bugs.sh \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=hangbin.liu@linux.dev \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stefano.salsano@uniroma2.it \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=yymhvert@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®