From: Tarun Sahu <tarunsahu@google.com>
To: Pasha Tatashin <pasha.tatashin@soleen.com>,
Mike Rapoport <rppt@kernel.org>,
robin.murphy@arm.com, maz@kernel.org, will@kernel.org,
David Matlack <dmatlack@google.com>,
Alexander Graf <graf@amazon.com>,
seanjc@google.com, jgg@nvidia.com, loganodell@google.com,
arnd@arndb.de, dwmw2@infradead.org, baolu.lu@linux.intel.com,
Bjorn Helgaas <bhelgaas@google.com>,
oupton@kernel.org, alex@shazbot.org, gle.com@google.com,
pbonzini@redhat.com, Andrew Morton <akpm@linux-foundation.org>,
kevin.tian@intel.com, joro@8bytes.org
Cc: kvmarm@lists.linux.dev, linux-pci@vger.kernel.org,
Pratyush Yadav <pratyush@kernel.org>,
kexec@lists.infradead.org, kvm@vger.kernel.org,
iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
skhawaja@google.com, sagis@google.com,
linux-arch@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Tarun Sahu <tarunsahu@google.com>
Subject: [PATCH v4 19/19] kho: Add KUnit test for the feature header helpers
Date: Tue, 10 Nov 2026 05:02:02 +0000 [thread overview]
Message-ID: <20261110050202.529473-20-tarunsahu@google.com> (raw)
In-Reply-To: <20261110050202.529473-1-tarunsahu@google.com>
Add a KUnit test suite in lib/tests/kho_feature_kunit.c covering
the Kexec HandOver feature header declared in
include/linux/kho/abi/feature.h.
The suite contains three focused test cases:
- kho_ser_hdr_zero_flags_test: verifies zero-feature header
initialization, payload sizing, and empty feature queries.
- kho_ser_hdr_set_get_test: verifies DECLARE_KHO_SER structure sizing,
header initialization, payload pointer resolution, and 1-bit
feature flag setting and retrieval across flags entry boundaries,
including out-of-range queries.
- kho_ser_hdr_validate_test: verifies __kho_ser_validate rejecting
unsupported required feature flags while ignoring optional flags.
Signed-off-by: Tarun Sahu <tarunsahu@google.com>
---
MAINTAINERS | 1 +
lib/Kconfig.debug | 13 +++
lib/tests/Makefile | 1 +
lib/tests/kho_feature_kunit.c | 184 ++++++++++++++++++++++++++++++++++
4 files changed, 199 insertions(+)
create mode 100644 lib/tests/kho_feature_kunit.c
diff --git a/MAINTAINERS b/MAINTAINERS
index 1572f6c905aa..0b50de45140f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14786,6 +14786,7 @@ F: include/linux/kho/
F: include/linux/kho_block.h
F: kernel/liveupdate/kexec_handover*
F: lib/test_kho.c
+F: lib/tests/kho_feature_kunit.c
F: tools/testing/selftests/kho/
KEYS-ENCRYPTED
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 2d22638ec13a..3d74d32b181d 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2967,6 +2967,19 @@ config DIMLIB_KUNIT_TEST
For more information on KUnit and unit tests in general please refer
to the KUnit documentation in Documentation/dev-tools/kunit/.
+config KHO_FEATURE_KUNIT_TEST
+ tristate "KUnit test for the Kexec HandOver feature header helpers" if !KUNIT_ALL_TESTS
+ depends on KUNIT
+ default KUNIT_ALL_TESTS
+ help
+ This option enables the KUnit test suite for the Kexec HandOver
+ feature header helpers defined in include/linux/kho/abi/feature.h.
+ It checks the feature flag encoding, the flags array sizing, the
+ feature bit helpers, and header validation rules.
+
+ The helpers are self-contained, so the test does not depend on
+ CONFIG_KEXEC_HANDOVER and can also run under UML.
+
If unsure, say N.
config CMDLINE_KUNIT_TEST
diff --git a/lib/tests/Makefile b/lib/tests/Makefile
index df0537e1b91f..f22a4552f755 100644
--- a/lib/tests/Makefile
+++ b/lib/tests/Makefile
@@ -35,6 +35,7 @@ obj-$(CONFIG_KFIFO_KUNIT_TEST) += kfifo_kunit.o
obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o
obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
obj-$(CONFIG_LIVEUPDATE_TEST) += liveupdate.o
+obj-$(CONFIG_KHO_FEATURE_KUNIT_TEST) += kho_feature_kunit.o
CFLAGS_longest_symbol_kunit.o += $(call cc-disable-warning, missing-prototypes)
obj-$(CONFIG_LONGEST_SYM_KUNIT_TEST) += longest_symbol_kunit.o
diff --git a/lib/tests/kho_feature_kunit.c b/lib/tests/kho_feature_kunit.c
new file mode 100644
index 000000000000..db36895d53f5
--- /dev/null
+++ b/lib/tests/kho_feature_kunit.c
@@ -0,0 +1,184 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * KUnit tests for the Kexec HandOver feature header helpers
+ * in include/linux/kho/abi/feature.h.
+ *
+ * Copyright (c) 2026, Google LLC.
+ * Tarun Sahu <tarunsahu@google.com>
+ */
+
+#include <kunit/test.h>
+#include <linux/kho/abi/feature.h>
+#include <linux/module.h>
+
+struct test_kho_payload {
+ u64 val;
+};
+
+enum test_kho_req_feat {
+ TEST_KHO_REQ_0 = 0,
+ TEST_KHO_REQ_63 = 63,
+ TEST_KHO_REQ_64 = 64,
+ TEST_KHO_REQ_69 = 69,
+ TEST_KHO_NR_REQUIRED = 70,
+};
+
+enum test_kho_opt_feat {
+ TEST_KHO_OPT_0 = 0,
+ TEST_KHO_OPT_63 = 63,
+ TEST_KHO_OPT_64 = 64,
+ TEST_KHO_OPT_69 = 69,
+ TEST_KHO_NR_OPTIONAL = 70,
+};
+
+DECLARE_KHO_SER(test_kho_payload, 8, TEST_KHO_NR_REQUIRED, TEST_KHO_NR_OPTIONAL);
+
+struct test_kho_zero {
+ u64 val;
+};
+
+DECLARE_KHO_SER(test_kho_zero, 8, 0, 0);
+
+static void kho_ser_hdr_zero_flags_test(struct kunit *test)
+{
+ DECLARE_KHO_SER_HDR(test_kho_zero, *fhdr);
+ const DECLARE_KHO_SER_HDR(test_kho_zero, *const_fhdr);
+ u8 buf[kho_ser_size(test_kho_zero)] __aligned(8);
+ struct test_kho_zero *p;
+
+ KUNIT_EXPECT_EQ(test, sizeof(struct kho_ser_hdr), 8UL);
+ KUNIT_EXPECT_EQ(test, sizeof(*fhdr), sizeof(struct kho_ser_hdr));
+ KUNIT_EXPECT_EQ(test, kho_ser_size(test_kho_zero), 16UL);
+
+ fhdr = (void *)buf;
+ kho_ser_init(fhdr, test_kho_zero);
+ KUNIT_EXPECT_EQ(test, fhdr->size, 16U);
+ KUNIT_EXPECT_EQ(test, fhdr->nr_required, 0U);
+ KUNIT_EXPECT_EQ(test, fhdr->nr_optional, 0U);
+ KUNIT_EXPECT_EQ(test, kho_ser_hdr_size(fhdr), 8UL);
+
+ const_fhdr = fhdr;
+ KUNIT_EXPECT_EQ(test, const_fhdr->size, 16U);
+
+ p = kho_ser_payload(fhdr, test_kho_zero);
+ KUNIT_EXPECT_PTR_EQ(test, p, (void *)(buf + 8));
+
+ p = kho_ser_payload(const_fhdr, test_kho_zero);
+ KUNIT_EXPECT_PTR_EQ(test, p, (void *)(buf + 8));
+
+ KUNIT_EXPECT_FALSE(test, kho_ser_has_required(fhdr, 0));
+ KUNIT_EXPECT_FALSE(test, kho_ser_has_optional(fhdr, 0));
+ KUNIT_EXPECT_EQ(test, kho_ser_validate(fhdr, test_kho_zero), 0);
+ KUNIT_EXPECT_EQ(test, kho_ser_validate(const_fhdr, test_kho_zero), 0);
+}
+
+static void kho_ser_hdr_set_get_test(struct kunit *test)
+{
+ DECLARE_KHO_SER_HDR(test_kho_payload, *fhdr);
+ const DECLARE_KHO_SER_HDR(test_kho_payload, *const_fhdr);
+ u8 buf[kho_ser_size(test_kho_payload)] __aligned(8);
+ struct test_kho_payload *p;
+
+ KUNIT_EXPECT_EQ(test, kho_ser_size(test_kho_payload), 40UL);
+
+ fhdr = (void *)buf;
+ kho_ser_init(fhdr, test_kho_payload);
+ KUNIT_EXPECT_EQ(test, fhdr->size, 40U);
+ KUNIT_EXPECT_EQ(test, fhdr->nr_required, 70U);
+ KUNIT_EXPECT_EQ(test, fhdr->nr_optional, 70U);
+ KUNIT_EXPECT_EQ(test, kho_ser_hdr_size(fhdr), 32UL);
+
+ const_fhdr = fhdr;
+ KUNIT_EXPECT_EQ(test, const_fhdr->size, 40U);
+ KUNIT_EXPECT_EQ(test, const_fhdr->nr_required, 70U);
+ KUNIT_EXPECT_EQ(test, const_fhdr->nr_optional, 70U);
+
+ p = kho_ser_payload(fhdr, test_kho_payload);
+ KUNIT_EXPECT_PTR_EQ(test, p, (void *)(buf + 32));
+
+ p = kho_ser_payload(const_fhdr, test_kho_payload);
+ KUNIT_EXPECT_PTR_EQ(test, p, (void *)(buf + 32));
+
+ kho_ser_set_required(fhdr, TEST_KHO_REQ_0);
+ kho_ser_set_required(fhdr, TEST_KHO_REQ_63);
+ kho_ser_set_required(fhdr, TEST_KHO_REQ_64);
+ kho_ser_set_required(fhdr, TEST_KHO_REQ_69);
+
+ KUNIT_EXPECT_TRUE(test, kho_ser_has_required(fhdr, TEST_KHO_REQ_0));
+ KUNIT_EXPECT_FALSE(test, kho_ser_has_required(fhdr, 1));
+ KUNIT_EXPECT_TRUE(test, kho_ser_has_required(fhdr, TEST_KHO_REQ_63));
+ KUNIT_EXPECT_TRUE(test, kho_ser_has_required(fhdr, TEST_KHO_REQ_64));
+ KUNIT_EXPECT_FALSE(test, kho_ser_has_required(fhdr, 65));
+ KUNIT_EXPECT_TRUE(test, kho_ser_has_required(fhdr, TEST_KHO_REQ_69));
+
+ KUNIT_EXPECT_TRUE(test, !!(fhdr->flags[0] & (1ULL << 0)));
+ KUNIT_EXPECT_TRUE(test, !!(fhdr->flags[0] & (1ULL << 63)));
+ KUNIT_EXPECT_TRUE(test, !!(fhdr->flags[1] & (1ULL << 0)));
+ KUNIT_EXPECT_TRUE(test, !!(fhdr->flags[1] & (1ULL << 5)));
+
+ kho_ser_set_optional(fhdr, TEST_KHO_OPT_0);
+ kho_ser_set_optional(fhdr, TEST_KHO_OPT_63);
+ kho_ser_set_optional(fhdr, TEST_KHO_OPT_64);
+ kho_ser_set_optional(fhdr, TEST_KHO_OPT_69);
+
+ KUNIT_EXPECT_TRUE(test, kho_ser_has_optional(fhdr, TEST_KHO_OPT_0));
+ KUNIT_EXPECT_FALSE(test, kho_ser_has_optional(fhdr, 1));
+ KUNIT_EXPECT_TRUE(test, kho_ser_has_optional(fhdr, TEST_KHO_OPT_63));
+ KUNIT_EXPECT_TRUE(test, kho_ser_has_optional(fhdr, TEST_KHO_OPT_64));
+ KUNIT_EXPECT_FALSE(test, kho_ser_has_optional(fhdr, 65));
+ KUNIT_EXPECT_TRUE(test, kho_ser_has_optional(fhdr, TEST_KHO_OPT_69));
+
+ KUNIT_EXPECT_TRUE(test, !!(fhdr->flags[1] & (1ULL << 6)));
+ KUNIT_EXPECT_TRUE(test, !!(fhdr->flags[2] & (1ULL << 5)));
+ KUNIT_EXPECT_TRUE(test, !!(fhdr->flags[2] & (1ULL << 6)));
+ KUNIT_EXPECT_TRUE(test, !!(fhdr->flags[2] & (1ULL << 11)));
+
+ KUNIT_EXPECT_FALSE(test, kho_ser_has_required(fhdr, 70));
+ KUNIT_EXPECT_FALSE(test, kho_ser_has_required(fhdr, 100));
+ KUNIT_EXPECT_FALSE(test, kho_ser_has_optional(fhdr, 70));
+ KUNIT_EXPECT_FALSE(test, kho_ser_has_optional(fhdr, 100));
+}
+
+static void kho_ser_hdr_validate_test(struct kunit *test)
+{
+ u8 buf[sizeof(struct kho_ser_hdr) + sizeof(u64) * 2] __aligned(8);
+ struct kho_ser_hdr *fhdr = (void *)buf;
+
+ __kho_ser_init(fhdr, 0, 4, 10);
+ KUNIT_EXPECT_EQ(test, __kho_ser_validate(fhdr, 4), 0);
+ KUNIT_EXPECT_EQ(test, __kho_ser_validate(fhdr, 2), 0);
+
+ kho_ser_set_optional(fhdr, 0);
+ kho_ser_set_optional(fhdr, 9);
+ KUNIT_EXPECT_EQ(test, __kho_ser_validate(fhdr, 2), 0);
+
+ kho_ser_set_required(fhdr, 0);
+ kho_ser_set_required(fhdr, 1);
+ KUNIT_EXPECT_EQ(test, __kho_ser_validate(fhdr, 2), 0);
+
+ kho_ser_set_required(fhdr, 2);
+ KUNIT_EXPECT_EQ(test, __kho_ser_validate(fhdr, 2), -EOPNOTSUPP);
+
+ kho_ser_clear_required(fhdr, 2);
+ KUNIT_EXPECT_EQ(test, __kho_ser_validate(fhdr, 2), 0);
+
+ kho_ser_set_required(fhdr, 3);
+ KUNIT_EXPECT_EQ(test, __kho_ser_validate(fhdr, 2), -EOPNOTSUPP);
+}
+
+static struct kunit_case kho_feature_test_cases[] = {
+ KUNIT_CASE(kho_ser_hdr_zero_flags_test),
+ KUNIT_CASE(kho_ser_hdr_set_get_test),
+ KUNIT_CASE(kho_ser_hdr_validate_test),
+ {}
+};
+
+static struct kunit_suite kho_feature_test_suite = {
+ .name = "kho_feature",
+ .test_cases = kho_feature_test_cases,
+};
+
+kunit_test_suite(kho_feature_test_suite);
+
+MODULE_DESCRIPTION("KUnit tests for the Kexec HandOver feature header helpers");
+MODULE_LICENSE("GPL");
--
2.56.0.506.g506a7eabc5-goog
prev parent reply other threads:[~2026-11-10 5:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 5:01 [PATCH v4 00/19] kho, liveupdate: Add feature header for fine-grained ABI compatibility Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 01/19] liveupdate, kho: Remove __packed from KHO, LUO and memfd ABI structures Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 02/19] kho: block: Record the entry size in the block header Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 03/19] kho, memfd_luo: Reference struct kho_vmalloc via serialized pointer Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 04/19] liveupdate: Reference struct luo_file_set_ser " Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 05/19] kho: Add feature header for fine-grained ABI compatibility Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 06/19] kho: kexec_metadata: Add the feature header Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 07/19] kho: vmalloc: " Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 08/19] kho: block: Add the feature header to blocks Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 09/19] liveupdate: Add feature header to struct luo_ser Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 10/19] liveupdate: Add feature header to struct luo_session_ser Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 11/19] liveupdate: Add feature header to struct luo_file_set_ser Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 12/19] liveupdate: Add feature header to struct luo_file_ser Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 13/19] liveupdate: Add feature header to struct luo_flb_header_ser Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 14/19] liveupdate: Add feature header to struct luo_flb_ser Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 15/19] PCI: liveupdate: Add feature header to struct pci_ser Tarun Sahu
2026-11-10 5:01 ` [PATCH v4 16/19] PCI: liveupdate: Add feature header to struct pci_dev_ser Tarun Sahu
2026-11-10 5:02 ` [PATCH v4 17/19] mm: memfd_luo: Add feature header to struct memfd_luo_ser Tarun Sahu
2026-11-10 5:02 ` [PATCH v4 18/19] mm: memfd_luo: Add feature header to struct memfd_luo_folio_ser Tarun Sahu
2026-11-10 5:02 ` Tarun Sahu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110050202.529473-20-tarunsahu@google.com \
--to=tarunsahu@google.com \
--cc=akpm@linux-foundation.org \
--cc=alex@shazbot.org \
--cc=arnd@arndb.de \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=dmatlack@google.com \
--cc=dwmw2@infradead.org \
--cc=gle.com@google.com \
--cc=graf@amazon.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kexec@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=loganodell@google.com \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=pbonzini@redhat.com \
--cc=pratyush@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=sagis@google.com \
--cc=seanjc@google.com \
--cc=skhawaja@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®