From: Sergey Lebedev <lsa.uz@pm.me>
To: Manik Bajpai <manik.bajpai@intel.com>,
Divyamani Tripathi <divyamani.tripathi@intel.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@amd.com>,
Antti Laakso <antti.laakso@linux.intel.com>,
German Pablo Lindo <germanpapulindez@gmail.com>,
Christian Murphy <christian@themurphys.eu>,
Hans Verkuil <hverkuil@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: staging/ipu7: snoop ISYS writes to capture buffers
Date: Tue, 10 Nov 2026 06:51:25 +0000 [thread overview]
Message-ID: <20261110065119.20575-1-lsa.uz@pm.me> (raw)
In-Reply-To: <asaywQrMq-GSrI2r@kekkonen.localdomain>
Hi Manik, Divyamani,
Sakari added you to this patch in October. Is is_snoop = 1 on the
capture pin right for IPU7, and for IPU 7.5, which I could not test?
Christian Murphy sent a different fix for the same rows in August,
which I missed: a clflush of each capture buffer in buf_prepare and
buf_finish, with is_snoop left at 0. If the snoop bit cannot be relied
on, his is the one to take:
https://lore.kernel.org/all/20260824224139.21256-1-christian@themurphys.eu/
With is_snoop = 1, frames holding rows of the buffer's previous fill
went from 301 of 698 and 684 of 697 to none, reading every frame with
the CPU, and 4224x3136 raw at about 790 MB/s still ran at 29.95 fps.
The patch applies to v7.4-rc1 unchanged.
It carries an Assisted-by tag, which 7.4-rc1 no longer accepts; Sakari,
please drop it when applying, or I will resend without it.
Sergey
next prev parent reply other threads:[~2026-11-10 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 18:33 Sergey Lebedev
2026-10-07 20:59 ` Sakari Ailus
2026-11-10 6:51 ` Sergey Lebedev [this message]
2026-10-10 7:55 ` Test for " German Pablo Lindo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110065119.20575-1-lsa.uz@pm.me \
--to=lsa.uz@pm.me \
--cc=antti.laakso@linux.intel.com \
--cc=bingbu.cao@amd.com \
--cc=christian@themurphys.eu \
--cc=divyamani.tripathi@intel.com \
--cc=germanpapulindez@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manik.bajpai@intel.com \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®