From: Stephen Hemminger <stephen@networkplumber.org>
To: Hangbin Liu <hangbin.liu@linux.dev>
Cc: netdev@vger.kernel.org, dsahern@kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Ido Schimmel <idosch@nvidia.com>,
Sabrina Dubroca <sd@queasysnail.net>,
Andrea Parri <parri.andrea@gmail.com>,
Stanislav Fomichev <sdf.kernel@gmail.com>,
Nikolaos Gkarlis <nickgarlis@gmail.com>,
Willem de Bruijn <willemb@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] rtnetlink: return EMSGSIZE when first dump entry does not fit
Date: Tue, 10 Nov 2026 07:19:28 -0800 [thread overview]
Message-ID: <20261110071928.6e8aebd7@phoenix.local> (raw)
In-Reply-To: <avLVfWQEtsLH4BUA@fedora>
On Tue, 10 Nov 2026 16:27:41 +0800
Hangbin Liu <hangbin.liu@linux.dev> wrote:
> Hi Stephen,
> On Sun, Nov 08, 2026 at 05:13:12PM -0800, Stephen Hemminger wrote:
> > If a route entry is too large for the dump skb, the dump is silently
> > truncated and no error is returned.
> >
> > For handlers with RTNL_FLAG_DUMP_SPLIT_NLM_DONE, rtnl_dumpit() drops
> > -EMSGSIZE and returns skb->len. With an empty skb this is 0, so the
> > dump ends with NLMSG_DONE and status 0, and the remaining entries are
> > lost.
> >
> > The first dump skb is allocated from __netlink_dump_start() while
> > max_recvmsg_len is still 0, so it is only NLMSG_GOODSIZE. On a 4K page
> > kernel that is under 4000 bytes, and a 500 way multipath route does not
> > fit:
> >
> > ip link add dummy0 type dummy
> > ip link set dummy0 up
> > ip route add 198.51.100.0/24 table 100 \
> > $(for i in $(seq 500); do echo -n "nexthop dev dummy0 "; done)
> > ip route show table 100
> >
> > The dump prints nothing and exits 0, although "ip route get
> > 198.51.100.1 table 100" still shows the route.
>
> One question. AFAIK, `ip route get` doesn't support "table" parameter. No?
>
> Thanks
> Hangbin
Your right AI is wrong in the commit message.
A way to use get is to add a rule.
# ip rule add to 198.51.100.0/24 lookup 100
# ip route get 198.51.100.1
198.51.100.1 dev dummy0 table 100 src 192.168.50.131 uid 0
cache
But best to just drop the incorrect wording there.
next prev parent reply other threads:[~2026-11-10 15:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261109012115.11898-1-stephen@networkplumber.org>
2026-11-09 1:13 ` Stephen Hemminger
2026-11-10 7:25 ` Hangbin Liu
2026-11-10 8:27 ` Hangbin Liu
2026-11-10 15:19 ` Stephen Hemminger [this message]
2026-11-09 1:13 ` [PATCH 2/3] ipv6: return EMSGSIZE when first route in dump " Stephen Hemminger
2026-11-10 8:28 ` Hangbin Liu
2026-11-09 1:13 ` [PATCH 3/3] selftests: net: netlink-dumps: test dump of route larger than skb Stephen Hemminger
2026-11-10 9:24 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110071928.6e8aebd7@phoenix.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=hangbin.liu@linux.dev \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nickgarlis@gmail.com \
--cc=pabeni@redhat.com \
--cc=parri.andrea@gmail.com \
--cc=sd@queasysnail.net \
--cc=sdf.kernel@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®