Re: [PATCH v3 6/9] ARM: dts: omap: dm816x: Update USB node

[Andreas Kemnade <andreas@kemnade.info>]

On Mon, 02 Nov 2026 20:52:52 +0100
Ettore Chimenti <ettore.chimenti@linaro.org> wrote:

> From: Andrew Goodbody <andrew.goodbody@linaro.org>
> 
> USB node was not working correctly with DMA enabled as the supporting
> code had been updated without updating this SoC's device tree. Bring the
> device tree more up to date so that it works with DMA enabled.
> Removing deprecated usb_otg_hs `ti,hwmods` property in DT node in favour
> of ti-sysc implementation.
> 
> Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/ti/omap/dm816x.dtsi | 40 +++++++++++++++++++++--------------
>  1 file changed, 24 insertions(+), 16 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/dm816x.dtsi b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> index 1e8d225dfb2c..314e5e580c8b 100644
> --- a/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> @@ -573,18 +573,26 @@ uart3: serial@48024000 {
>  		};
>  
>  		/* NOTE: USB needs a transceiver driver for phys to work */
> -		usb: usb_otg_hs@47401000 {
> -			compatible = "ti,am33xx-usb";
> -			reg = <0x47401000 0x400000>;
> -			ranges;
> +		usb: target-module@47400000 {
> +			compatible = "ti,sysc-omap4", "ti,sysc";
> +			reg = <0x47400000 0x4>,
> +			      <0x47400010 0x4>;
> +			reg-names = "rev", "sysc";
> +			ti,sysc-mask = <SYSC_OMAP4_SOFTRESET>;
> +			ti,sysc-midle = <SYSC_IDLE_FORCE>,
> +					<SYSC_IDLE_SMART>;
> +			ti,sysc-sidle = <SYSC_IDLE_SMART>;
> +			ti,sysc-delay-us = <2>;
> +			clocks = <&default_clkctrl DM816_USB_OTG_HS_CLKCTRL 0>;
> +			clock-names = "fck";
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> -			ti,hwmods = "usb_otg_hs";
> +			ranges = <0x0 0x47400000 0x8000>;
>  
> -			usb0: usb@47401000 {
> +			usb0: usb@1400 {
>  				compatible = "ti,musb-dm816";
> -				reg = <0x47401400 0x400
> -				       0x47401000 0x200>;
> +				reg = <0x1400 0x400>,
> +				      <0x1000 0x200>;
>  				reg-names = "mc", "control";
>  				interrupts = <18>;
>  				interrupt-names = "mc";
> @@ -621,10 +629,10 @@ &cppi41dma 11 1 &cppi41dma 12 1
>  					"tx14", "tx15";
>  			};
>  
> -			usb1: usb@47401800 {
> +			usb1: usb@1c00 {
>  				compatible = "ti,musb-dm816";
> -				reg = <0x47401c00 0x400
> -				       0x47401800 0x200>;
> +				reg = <0x1c00 0x400>,
> +				      <0x1800 0x200>;
>  				reg-names = "mc", "control";
>  				interrupts = <19>;
>  				interrupt-names = "mc";
> @@ -661,12 +669,12 @@ &cppi41dma 26 1 &cppi41dma 27 1
>  					"tx14", "tx15";
>  			};
>  
> -			cppi41dma: dma-controller@47402000 {
> +			cppi41dma: dma-controller@2000 {
>  				compatible = "ti,am3359-cppi41";
> -				reg = <0x47400000 0x1000>,
> -				      <0x47402000 0x1000>,
> -				      <0x47403000 0x1000>,
> -				      <0x47404000 0x4000>;
> +				reg =  <0x0000 0x1000>,
> +				       <0x2000 0x1000>,
> +				       <0x3000 0x1000>,
> +				       <0x4000 0x4000>;
>  				reg-names = "glue", "controller", "scheduler", "queuemgr";
>  				interrupts = <17>;
>  				interrupt-names = "glue";
>