From: Archit More <architmore303@gmail.com>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Douglas Anderson <dianders@chromium.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Archit More <architmore303@gmail.com>
Subject: [PATCH] drm/panel: kingdisplay-kd097d04: Use mipi_dsi_*_multi() functions
Date: Tue, 10 Nov 2026 13:55:35 +0530 [thread overview]
Message-ID: <20261110082535.7998-1-architmore303@gmail.com> (raw)
The mipi_dsi_dcs_*() and mipi_dsi_generic_write() functions used
by this driver are deprecated in favor of their _multi() counterparts,
as noted in Documentation/gpu/todo.rst.
Convert disable(), unprepare(), and prepare() to use the _multi() APIs.
Signed-off-by: Archit More <architmore303@gmail.com>
---
.../drm/panel/panel-kingdisplay-kd097d04.c | 54 ++++++-------------
1 file changed, 17 insertions(+), 37 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c b/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
index 893af9b16756..01f5a96f1cfb 100644
--- a/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
+++ b/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
@@ -180,28 +180,21 @@ struct kingdisplay_panel *to_kingdisplay_panel(struct drm_panel *panel)
static int kingdisplay_panel_disable(struct drm_panel *panel)
{
struct kingdisplay_panel *kingdisplay = to_kingdisplay_panel(panel);
- int err;
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = kingdisplay->link };
- err = mipi_dsi_dcs_set_display_off(kingdisplay->link);
- if (err < 0)
- dev_err(panel->dev, "failed to set display off: %d\n", err);
+ mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
- return 0;
+ return dsi_ctx.accum_err;
}
static int kingdisplay_panel_unprepare(struct drm_panel *panel)
{
struct kingdisplay_panel *kingdisplay = to_kingdisplay_panel(panel);
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = kingdisplay->link };
int err;
- err = mipi_dsi_dcs_enter_sleep_mode(kingdisplay->link);
- if (err < 0) {
- dev_err(panel->dev, "failed to enter sleep mode: %d\n", err);
- return err;
- }
-
- /* T15: 120ms */
- msleep(120);
+ mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
+ mipi_dsi_msleep(&dsi_ctx, 120);
gpiod_set_value_cansleep(kingdisplay->enable_gpio, 0);
@@ -209,12 +202,13 @@ static int kingdisplay_panel_unprepare(struct drm_panel *panel)
if (err < 0)
return err;
- return 0;
+ return dsi_ctx.accum_err;
}
static int kingdisplay_panel_prepare(struct drm_panel *panel)
{
struct kingdisplay_panel *kingdisplay = to_kingdisplay_panel(panel);
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = kingdisplay->link };
int err, regulator_err;
unsigned int i;
@@ -232,32 +226,18 @@ static int kingdisplay_panel_prepare(struct drm_panel *panel)
/* T4: 15ms */
usleep_range(15000, 16000);
- for (i = 0; i < ARRAY_SIZE(init_code); i++) {
- err = mipi_dsi_generic_write(kingdisplay->link, &init_code[i],
- sizeof(struct kingdisplay_panel_cmd));
- if (err < 0) {
- dev_err(panel->dev, "failed write init cmds: %d\n", err);
- goto poweroff;
- }
- }
+ for (i = 0; i < ARRAY_SIZE(init_code); i++)
+ mipi_dsi_generic_write_multi(&dsi_ctx, &init_code[i],
+ sizeof(struct kingdisplay_panel_cmd));
- err = mipi_dsi_dcs_exit_sleep_mode(kingdisplay->link);
- if (err < 0) {
- dev_err(panel->dev, "failed to exit sleep mode: %d\n", err);
- goto poweroff;
- }
+ mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
+ mipi_dsi_msleep(&dsi_ctx, 120);
- /* T6: 120ms */
- msleep(120);
+ mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
+ mipi_dsi_usleep_range(&dsi_ctx, 10000, 11000);
- err = mipi_dsi_dcs_set_display_on(kingdisplay->link);
- if (err < 0) {
- dev_err(panel->dev, "failed to set display on: %d\n", err);
+ if (dsi_ctx.accum_err)
goto poweroff;
- }
-
- /* T7: 10ms */
- usleep_range(10000, 11000);
return 0;
@@ -268,7 +248,7 @@ static int kingdisplay_panel_prepare(struct drm_panel *panel)
if (regulator_err)
dev_err(panel->dev, "failed to disable regulator: %d\n", regulator_err);
- return err;
+ return dsi_ctx.accum_err;
}
static const struct drm_display_mode default_mode = {
--
2.34.1
reply other threads:[~2026-11-10 8:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110082535.7998-1-architmore303@gmail.com \
--to=architmore303@gmail.com \
--cc=airlied@gmail.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®