From: phucduc.bui@gmail.com
To: Maxim Kochetkov <fido_max@inbox.ru>,
Andrew Jackson <Andrew.Jackson@arm.com>,
Mark Brown <broonie@kernel.org>,
Xingyu Wu <xingyu.wu@starfivetech.com>
Cc: Tim Bird <tim.bird@sony.com>,
Yuri Zaporozhets <yuriz@vodafonemail.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v2 1/6] ASoC: dwc: Fix bit clock rate in TDM mode
Date: Tue, 10 Nov 2026 16:55:20 +0700 [thread overview]
Message-ID: <20261110095525.504660-2-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20261110095525.504660-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
The bit clock is computed as rate * data_width * 2, which only fits
a two-slot I2S frame. Use rate * data_width * tdm_slots in TDM mode.
Fixes: 221acc16aee1 ("ASoC: dwc: Add TDM mode support")
Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
Changes in v2:
- Move the indentation fixes into a separate commit.
- Add Maxim Kochetkov's Reviewed-by tag.
sound/soc/dwc/dwc-i2s.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
index dbda943cfaf3..1f4d06a82333 100644
--- a/sound/soc/dwc/dwc-i2s.c
+++ b/sound/soc/dwc/dwc-i2s.c
@@ -332,6 +332,9 @@ static int dw_i2s_hw_params(struct snd_pcm_substream *substream,
} else {
u32 bitclk = config->sample_rate *
config->data_width * 2;
+ if (dev->tdm_slots)
+ bitclk = config->sample_rate *
+ config->data_width * dev->tdm_slots;
ret = clk_set_rate(dev->clk, bitclk);
if (ret) {
--
2.43.0
next prev parent reply other threads:[~2026-11-10 9:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 9:55 [PATCH v2 0/6] ASoC: dwc: Fix several issues in the I2S driver phucduc.bui
2026-11-10 9:55 ` phucduc.bui [this message]
2026-11-10 9:55 ` [PATCH v2 2/6] ASoC: dwc: Fix error handling in dw_i2s_set_fmt() phucduc.bui
2026-11-10 9:55 ` [PATCH v2 3/6] ASoC: dwc: Fix channels_max derived from COMP_PARAM_1 phucduc.bui
2026-11-10 9:55 ` [PATCH v2 4/6] ASoC: dwc: Fix DMA fifo_size calculation phucduc.bui
2026-11-10 9:55 ` [PATCH v2 5/6] ASoC: dwc: Propagate optional IRQ lookup errors phucduc.bui
2026-11-10 9:55 ` [PATCH v2 6/6] ASoC: dwc: Remove redundant error messages phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110095525.504660-2-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=Andrew.Jackson@arm.com \
--cc=broonie@kernel.org \
--cc=fido_max@inbox.ru \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tim.bird@sony.com \
--cc=tiwai@suse.com \
--cc=xingyu.wu@starfivetech.com \
--cc=yuriz@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®