From: Jakub Kicinski <kuba@kernel.org>
To: Xia Yan <yanxia@cmss.chinamobile.com>
Cc: netdev@vger.kernel.org, edumazet@kernel.org,
ncardwell@google.com, kuniyu@google.com, davem@davemloft.net,
pabeni@redhat.com, horms@kernel.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, yana06070@163.com,
netdev-bot+sashiko@kernel.org, jiayuan.chen@linux.dev
Subject: Re: [PATCH net v2] tcp: fix device binding after failed IPv6 connect
Date: Tue, 10 Nov 2026 10:02:24 -0800 [thread overview]
Message-ID: <20261110100224.57cbf548@kernel.org> (raw)
In-Reply-To: <20261102143352.135769-1-yanxia@cmss.chinamobile.com>
On Mon, 2 Nov 2026 22:34:52 +0800 Xia Yan wrote:
> + if (scope_id_set &&
> + READ_ONCE(sk->sk_bound_dev_if) == usin->sin6_scope_id)
> + WRITE_ONCE(sk->sk_bound_dev_if, old_bound_dev_if);
> + scope_id_set = false;
Just restore the old_bound_dev_if, I don't think we need all these
pre-conditions complicating the code. __ip6_datagram_connect()
already restores unconditionally for example.
--
pw-bot: cr
prev parent reply other threads:[~2026-11-10 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 14:34 Xia Yan
2026-11-03 14:37 ` netdev-bot+sashiko
2026-11-03 23:25 ` Xia Yan
2026-11-10 18:02 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110100224.57cbf548@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yana06070@163.com \
--cc=yanxia@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®