From: Thorsten Blum <blum@kernel.org>
To: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Nicolas Schier <n.schier@fritz.com>,
Ard Biesheuvel <ardb@kernel.org>,
"Lorenzo Stoakes (ARM)" <ljs@kernel.org>,
Jan Stancek <jstancek@redhat.com>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
"Pratyush Yadav (Google)" <pratyush@kernel.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Andreas Larsson <andreas@gaisler.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kevin Brodsky <kevin.brodsky@arm.com>
Cc: linux-kernel@vger.kernel.org, Thorsten Blum <blum@kernel.org>
Subject: [PATCH v5 0/4] x86/boot/compressed: Enable -Wunused and remove unused variables
Date: Tue, 10 Nov 2026 12:56:07 +0100 [thread overview]
Message-ID: <20261110115606.133611-6-blum@kernel.org> (raw)
This series removes unused variables and marks __efi_get_rsdp_addr() as
__maybe_unused. Patch 4 then enables -Wunused, matching the W=0 kernel
defaults. With WERROR=y, the warnings failed as follows:
arch/x86/boot/compressed/acpi.c:25:1: error: '__efi_get_rsdp_addr' defined but not used
arch/x86/boot/compressed/acpi.c:29:6: error: unused variable 'ret'
arch/x86/boot/compressed/acpi.c:57:15: error: unused variable 'nr_tables'
arch/x86/boot/compressed/efi.c:64:16: error: unused variable 'et'
arch/x86/boot/compressed/efi.c:136:6: error: unused variable 'ret'
arch/x86/boot/compressed/kaslr.c:600:13: error: unused variable 'i'
Patch 2 also drops a redundant efi_get_system_table() call and uses the
existing efi_get_conf_table() error path.
Changes in v5:
- Drop unrelated fall-through change from efi_get_system_table() (Ingo)
- Avoid __maybe_unused and declare index in for loop initializer (Ingo)
- v4: https://lore.kernel.org/r/20261109124816.61438-6-blum@kernel.org/
Changes in v4:
- Add a newline to the log message in efi_get_system_table() (Jan)
- Make efi_get_system_table() static and update misc.h (Jan)
- v3: https://lore.kernel.org/r/20261109005528.3477-6-blum@kernel.org/
Changes in v3:
- Rebase patch 4/4
- v2: https://lore.kernel.org/r/20260624120300.590233-6-thorsten.blum@linux.dev/
Changes in v2:
- Fix a kernel test robot issue by marking __efi_get_rsdp_addr() as
__maybe_unused: https://lore.kernel.org/r/202606240416.cXegPpiJ-lkp@intel.com/
- v1: https://lore.kernel.org/r/20260621144116.224010-6-thorsten.blum@linux.dev/
Thorsten Blum (4):
x86/boot/compressed: Remove unused variables in EFI helpers
x86/boot/compressed: Clean up EFI RSDP lookup in efi_get_rsdp_addr()
x86/boot/compressed: Declare immovable_mem index in loop initializer
x86/boot/compressed: Enable -Wunused
arch/x86/boot/compressed/Makefile | 3 +++
arch/x86/boot/compressed/acpi.c | 18 ++++--------------
arch/x86/boot/compressed/efi.c | 17 ++++++-----------
arch/x86/boot/compressed/kaslr.c | 3 +--
arch/x86/boot/compressed/misc.h | 6 ------
5 files changed, 14 insertions(+), 33 deletions(-)
next reply other threads:[~2026-11-10 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 11:56 Thorsten Blum [this message]
2026-11-10 11:56 ` [PATCH v5 1/4] x86/boot/compressed: Remove unused variables in EFI helpers Thorsten Blum
2026-11-10 11:56 ` [PATCH v5 2/4] x86/boot/compressed: Clean up EFI RSDP lookup in efi_get_rsdp_addr() Thorsten Blum
2026-11-10 11:56 ` [PATCH v5 3/4] x86/boot/compressed: Declare immovable_mem index in loop initializer Thorsten Blum
2026-11-10 11:56 ` [PATCH v5 4/4] x86/boot/compressed: Enable -Wunused Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110115606.133611-6-blum@kernel.org \
--to=blum@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andreas@gaisler.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jstancek@redhat.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=mingo@redhat.com \
--cc=n.schier@fritz.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®