From: Jakub Kicinski <kuba@kernel.org>
To: Christian Schmidbauer <opensource@grische.xyz>
Cc: netdev@vger.kernel.org, maxime.chevallier@bootlin.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
pabeni@redhat.com, Oleksij Rempel <o.rempel@pengutronix.de>,
stable@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 3/3] net: stmmac: dwmac1000: stop hardware from dropping checksum-error packets
Date: Tue, 10 Nov 2026 12:25:36 -0800 [thread overview]
Message-ID: <20261110122536.7cca85ce@kernel.org> (raw)
In-Reply-To: <20261104151914.2651241-4-opensource@grische.xyz>
On Wed, 4 Nov 2026 16:19:13 +0100 Christian Schmidbauer wrote:
> /* DMA operation mode defines (start/stop tx/rx are placed in common header)*/
> /* Disable Drop TCP/IP csum error */
> +#define DMA_CONTROL_DT 0x04000000
Maybe just me, since I don't know the HW, but what does _DT stand for
in this context? Other bits seem to be documented with a comment,
let's document the new one as well.
Not sure what the comment above the new define is deferring to, either.
Should it be removed?
> #define DMA_CONTROL_RSF 0x02000000 /* Receive Store and Forward */
> #define DMA_CONTROL_DFF 0x01000000 /* Disaable flushing */
--
pw-bot: cr
prev parent reply other threads:[~2026-11-10 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261104151914.2651241-1-opensource@grische.xyz>
2026-11-04 15:19 ` [PATCH net v2 1/3] net: stmmac: honour Rx checksum errors in the AF_XDP zero-copy path Christian Schmidbauer
2026-11-04 15:19 ` [PATCH net v2 2/3] net: stmmac: dwmac1000: don't discard frames with only a checksum error Christian Schmidbauer
2026-11-04 15:19 ` [PATCH net v2 3/3] net: stmmac: dwmac1000: stop hardware from dropping checksum-error packets Christian Schmidbauer
2026-11-10 20:25 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110122536.7cca85ce@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=opensource@grische.xyz \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®