From: Jakub Kicinski <kuba@kernel.org>
To: Rishikesh Jethwani <rjethwani@purestorage.com>
Cc: netdev@vger.kernel.org, John Fastabend <john.fastabend@gmail.com>,
Sabrina Dubroca <sd@queasysnail.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Alice Mikityanska <alice.kernel@fastmail.im>,
Tariq Toukan <tariqt@nvidia.com>,
Boris Pismenny <borisp@mellanox.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] tls: restrict device-down TX fallback to hardware TX sockets
Date: Tue, 10 Nov 2026 13:34:25 -0800 [thread overview]
Message-ID: <20261110133425.3bdcd98f@kernel.org> (raw)
In-Reply-To: <20261104214853.659378-1-rjethwani@purestorage.com>
On Wed, 4 Nov 2026 14:48:52 -0700 Rishikesh Jethwani wrote:
> + /* Stop offloaded TX and switch to the fallback.
> + * tls_is_skb_tx_device_offloaded will return false.
> + * Only HW TX sockets have the context it needs. Do it under
> + * tls_device_lock: the reference pins ctx, not ctx->sk.
> + */
> + if (ctx->tx_conf == TLS_HW)
> + WRITE_ONCE(ctx->sk->sk_validate_xmit_skb,
> + tls_validate_xmit_skb_sw);
The locking in this patch looks way too coincidental.
--
pw-bot: cr
next prev parent reply other threads:[~2026-11-10 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 21:48 Rishikesh Jethwani
2026-11-10 21:34 ` Jakub Kicinski [this message]
2026-11-11 0:21 ` Rishikesh Jethwani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110133425.3bdcd98f@kernel.org \
--to=kuba@kernel.org \
--cc=alice.kernel@fastmail.im \
--cc=borisp@mellanox.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rjethwani@purestorage.com \
--cc=sd@queasysnail.net \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®