mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
To: hare@suse.de
Cc: hare@kernel.org, hch@lst.de, kbusch@kernel.org, kch@nvidia.com,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	sagi@grimberg.me, sreekuttan2156239@gmail.com
Subject: Re: [PATCH v4] nvmet: clean up DH group state on initialization failure
Date: Tue, 10 Nov 2026 13:47:20 +0000	[thread overview]
Message-ID: <20261110134720.3500-1-sreekuttan2156239@gmail.com> (raw)
In-Reply-To: <2f0e8fe5-42b6-47d9-9bcd-c549544e099a@suse.de>

Thanks, Hannes.

I kept the cleanup in a common "err:" path to avoid duplicating the teardown 
logic across multiple failure paths.

The diff looks larger mainly because I removed the existing "else" block after 
introducing "goto err" for error handling. This allows the successful initialization 
path to remain linear, with all failures handled through the common cleanup section.

Thanks for the review!

Sreeraj

      reply	other threads:[~2026-11-10 13:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 11:35 Sreeraj S Kurup
2026-11-10 13:05 ` Hannes Reinecke
2026-11-10 13:47   ` Sreeraj S Kurup [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110134720.3500-1-sreekuttan2156239@gmail.com \
    --to=sreekuttan2156239@gmail.com \
    --cc=hare@kernel.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®