From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794351044; b=SVm8hoSAEbcxlEf40FIBjcnijrqsL2kJwHNkKgykSbe107AGxfdQXwd5cLIikZyX2fSh FUUbu7cDcdsltXOerYxt0DX5QkQ9JE643yQsgE/h6ZvA9AliC2xxSmdI9/aEmwZ6NN3o7 Nbd1CpvFkKyyHzyBxrcKgEJPwi2/XWJP54Zc5t4nM1JO0yc+rrYKhlAJ8PeI8YllNS7k0 t/cot4IiKFtMmrhs7G/rbW/3chfAvwE5TtYsz4jFAVaE5G3epY3m4cspWTi+ZKngI4dDL DlIJlLn+7pp/Nd8mWNXujXlm5wGlFGyjFpGGVqMY2Qq3Y/G/tvJO+Ww+ONNr+64bCbg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794351044; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Gm-Message-State:X-Gm-Gg: X-Received:X-Received:Received:Date:From:To:Cc:Subject:Message-ID: In-Reply-To:References:Organization:X-Mailer:MIME-Version: Content-Type:Content-Transfer-Encoding:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Info:X-Authority-Analysis:X-Proofpoint-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=uVC61jJFB75Gmb5fdaFJWW1deGVGa7rOIiH4PEtL2io=; b=q8S4qjES+65lR7T8HuGtz6OmnWDkbNZUCwFgo/5Ti58zPntfgIY1zUZ5p8TDkHJJcr3H Aqt0cjKY9oYA3uTrtivQyV8+BWTxqOhcEy2/QjMCf2Ema9zOZmvIXqv7YJd4etPH18qvr B94ntvnb8+NV8A1er484qkfd+aIx8a7FayG0G8pQSiXwQpXPMXRrTKjhtCjvz7kgkdw3x k73oUbslk0hOIPmnsU7UKThUK8mam7Y9KDQWuDuhNhSsoG24BUs4g0D3R1qigSTvK4/Jb tdwjdz6lId5YCB4QcWCYB4QO15+4S0m6GxD7ZA/ptflHrUnJg8TS+scbcoWLQxHPr6Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=F03OaTtb; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=MkVooa+B; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5C43606A31C for ; Tue, 10 Nov 2026 22:50:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E5C43606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=F03OaTtb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=MkVooa+B Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AAMLBGa469782 for ; Tue, 10 Nov 2026 22:50:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uVC61jJFB75Gmb5fdaFJWW1deGVGa7rOIiH4PEtL2io=; b=F03OaTtb6bYFL8gL Ve7hnhc8Sw7J0rgs/T0of/qgvB9zty7yK88MG/KqmyKo0fjNPIy36RKq7bY/h0rG MII55Veey/4m0wpHYvZf0j5eeLFJCNOWB1o3CPl1bb34Fnemsi4Z6WD0rQMrEwvw 9gIwmD/8TzFtFpGBdTZ7Y96/syKYW/wlm6UxZrj4MOSAxu/4TQrpvd/cGMEPAh0K 21fLl/KpycU200fyM9amctc50JpVd6OQqWDTvmqrGWpt9CIgk1FLTZtKWimUyhfo RIwN1s4FdtEL4yX9mUPXOzSt/p93knQ36CorLFfZScmNxTuMk7pkHzOX5z54iQNa HEmvkQ== Received: from mail-dl1-f72.google.com (mail-dl1-f72.google.com [74.125.82.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hv03cu7r5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Nov 2026 22:50:42 +0000 (GMT) Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-1b3b5b49cabso2189829c88.0 for ; Tue, 10 Nov 2026 14:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794351042; x=1794955842; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=uVC61jJFB75Gmb5fdaFJWW1deGVGa7rOIiH4PEtL2io=; b=MkVooa+B1Vm3Wr3BM2XKK2zM3uor1j/dKCfzqpZ4uo1DtS+Hs/JTzR2ICrTLNy47jG JiNillRotSWb3Sy6CzJ/J1hh0rBi1Wnk+PrAj1C70sl1VlDUAohTZtk2HOVQdojymOWA YCVasoc9M3UyDLFnohPUtMOl/onJDkFdfFrZ3SRhoQ1yKz9qtjCy7lP2OV3B9BsbaoP8 mHzxrebx4m7Xp97gCXENGJ17EuE3QsnFXCrvQWz1c+JyTewVqsfRhW+g24BymPbQd6Sj QKZXfMxyzx1zLDarH7wnv7r6mvAhUmrnHC0wkNds6X4CypXifaouWAK5hX/M3HVVhgUv hb0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794351042; x=1794955842; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uVC61jJFB75Gmb5fdaFJWW1deGVGa7rOIiH4PEtL2io=; b=Ltu4dSWf7R4CLJGmVyzQv3/w8nEcJf1Q4tPUbUrQVwYq5lkpADUUInHI7fB+UnBVSt Bq8ExBc+WKdK/QphY2iVJxYUozbzPlViyuAXCh+MC82MOXWZtBfrOIBQZFG2K7Uu4bYD 1MVhccbQXJPNrbwnIcoe4Fndbsp+q8JGFtFlkkCJ3YM4DxdRQO+oUEm+asDs12HBRnps mAvjscoW2uWT1Q6tbaeWaDTm89L1nRzamW23PX4Ns4ndUbleW8wgJvbib5VgzCTCBWUl b5nSTxM4anVkoJGB+Bm+t/2LvxxgQ1i8TdpQcTDEzwsqPF6WR0DFrYUAtyiPwNIpYDgB 2Q7w== X-Gm-Message-State: APuU4Z/CIxSrVW+iZT/SQBQf3ASPXjsMr2xo6d1LDB5NL9F6gDxAkg64 3M4tDURBO96oP1zAF1LCBSR2AWtyAuwFgkB3iVlZK3rrn+f1+AAVGWYjPlbQ6rPCuBoLn0Pnfqt 1x6762/jwYqJ+aVceoaNY0UIHYq3jd+WboTKzpe3SAmvkK7ALWslyn7rJ5n4E1GjijVs= X-Gm-Gg: AYBFou0URkIfLpJu3Uh3j0Lemz2uB5BIv6d5ZVQM7ti/EKUIOnUv8ERprXEZVLKu1xR b/Rka9DhWutvsNiwrHubKoEhG17wrQL9CKI7JzrpROsPpdzmLMkyXNNFvqwbOAXJlQ5L3IjdApz /BvlXPox7m++gcB8VvAQSpBl/frga5l94HFcHTeGKd2eJ0NYeAFk7gcZeTmfOc+bLipRCMgh9cM 1QcB1vrGtyB+3wTk7DQwFDvDUWxHhCyyszJTP2OJJHpjSOwjqh1E7x5n+2GtIr7xKotVirWCZ/6 qlCq5etytGOpiVCxTfcnI4dh9YmfPcH4ydQ2kSz6uGMPTcAqXeJZFWB0RxHpgy81o7I+n3V8gN0 CXwuF1f8bB3kMpHItgwkBbJQJYUzwYLB9Vsuqk0NDVO4TQOHy4tVgLXbF/Qtl0iL2YPkkQrZJID VU9MukcjGqaweQwD9fDW4V3g/ZIho= X-Received: by 2002:a05:7022:1184:b0:1b2:6b1f:1d89 with SMTP id a92af1059eb24-1b3c0360627mr424913c88.36.1794351041491; Tue, 10 Nov 2026 14:50:41 -0800 (PST) X-Received: by 2002:a05:7022:1184:b0:1b2:6b1f:1d89 with SMTP id a92af1059eb24-1b3c0360627mr424866c88.36.1794351040724; Tue, 10 Nov 2026 14:50:40 -0800 (PST) Received: from localhost (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b3b5b2eeffsm10023483c88.9.2026.11.10.14.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 14:50:40 -0800 (PST) Date: Tue, 10 Nov 2026 14:50:15 -0800 From: Jonathan Cameron To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, linux-doc@vger.kernel.org, sudeep.holla@kernel.org, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, etienne.carriere@st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, d-gole@ti.com, elif.topuz@arm.com, lukasz.luba@arm.com, philip.radford@arm.com, david@kernel.org, souvik.chakravarty@arm.com, leitao@kernel.org, kas@kernel.org, puranjay@kernel.org, usama.arif@linux.dev, kernel-team@meta.com Subject: Re: [PATCH v15 24/35] firmware: arm_scmi: Add common per-protocol debugfs support Message-ID: <20261110145015.0000712c@oss.qualcomm.com> In-Reply-To: <20261109091221.2532706-25-cristian.marussi@arm.com> References: <20261109091221.2532706-1-cristian.marussi@arm.com> <20261109091221.2532706-25-cristian.marussi@arm.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: FSHeuKr5sqI5Z-Y6AuxUhXx6-4Fagsvh X-Proofpoint-Spam-Info: AW1haW4tMjYxMTEwMDA5MSBTYWx0ZWRfX76ESClgtEoIo dYAe6B+eT1UZrMLFY+8kRWXX7WoZ0Rnto8Zp1dHwCdMaFbMG6Ik41E4v61VZBqBpOepNQSMsmJ6 TAhTRUfP/FP5QC5moCksjsuoIkqbc7Q= X-Authority-Analysis: v=2.4 cv=FuiQbGrq c=1 sm=1 tr=0 ts=6af39fc2 cx=c_pps a=bS7HVuBVfinNPG3f6cIo3Q==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=kj9zAlcOel0A:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=7CQSdrXTAAAA:8 a=43dFeItomYT0VcnkQewA:9 a=CjuIK1q_8ugA:10 a=vBUdepa8ALXHeOFLBtFW:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-GUID: FSHeuKr5sqI5Z-Y6AuxUhXx6-4Fagsvh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTEwMDA5MSBTYWx0ZWRfXwdIoGCnXww9d whvUlkj1rP/y66Fylneon3s7HCiV/AGAJOm6HGIMUntGXa1rWZhKHx9XHFNSYDzHw2qiazN3Dkb wKP147LVrSLHIFj75o271z2kzZeqvXDAufmn7LWsqe2RXc+XebK4H+dZezABWJoxqbxNhKv9TpO 80kgzxpck8N8rlYUMCjbUtBc4U3uZANuxza9pyxyb/b15qAnCXViNfzDiSSXTrjA4KqDDIUJiW/ g8Jn1TSCH8/0f4MKNHoXgIL/hl/f2G8cAEFFDA1NtjYOKsVknAVFgVAMSN0AdXSILV91wlgWBL4 CMatuqG5xcToaXkxMJ1mOOz2yYa+4wKPqCFfr65mj4XJSmFOgP1GDBQfb1AFYeXqQr6aKjiVQuj VWZiwhkXld9+3GeyB7Z7pzMWZOgcEeE4V+m6PRzhHZXADeDnXzjiN0lxnKJq4k+/kTLeUesjTZb JYQzIPSFWVcTXBxYpAg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-10_07,2026-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611100091 On Mon, 9 Nov 2026 09:12:10 +0000 Cristian Marussi wrote: > Allow interested SCMI protocols to register their own specific debugfs > entries under a common per-instance and per-protocol subtree rooted > at /sys/kernel/debug/scmi//protocols// > > Expose a helper to enable protocol initialization code to get access to > such per-protocol/per-instance dentries in order to be able to install > their own dedicated debugfs entries. > > Per-protocol debugfs support is configurable and default off. > > Signed-off-by: Cristian Marussi > --- > v14 --> v15 > - fix debugfs_remove_recursive call-site...was too early > v8 --> v9 > - avoid NULL deref on DBG cleanup path > v5 --> v6 > - bail out of dentry_get helper when SCMI debug susbsytem failed to init > - remove stale SCMI protocol operations > - add a preoper clean up of debugfs when protocol init fails > --- > drivers/firmware/arm_scmi/Kconfig | 14 +++++++++ > drivers/firmware/arm_scmi/common.h | 2 ++ > drivers/firmware/arm_scmi/driver.c | 42 +++++++++++++++++++++++++-- > drivers/firmware/arm_scmi/protocols.h | 6 ++++ > include/linux/scmi_protocol.h | 1 - > 5 files changed, 62 insertions(+), 3 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig > index 783c24a20e29..f506c4d1d96a 100644 > --- a/drivers/firmware/arm_scmi/Kconfig > +++ b/drivers/firmware/arm_scmi/Kconfig > @@ -69,6 +69,20 @@ config ARM_SCMI_DEBUG_COUNTERS > such useful debug counters. This can be helpful for debugging and > SCMI monitoring. > > +config ARM_SCMI_DEBUG_PROTOCOLS > + bool "Enable SCMI protocols debug" > + select ARM_SCMI_NEED_DEBUGFS > + depends on DEBUG_FS > + default n default of default is n, so no need. By all means add some text to discourage distros from enabling it. > + help > + Enables per-protocol specific debug features, where available. > + When provided, such per-protocol debugfs entries are grouped > + inside a common a subtree named by the protocol number and rooted > + under a per-instance 'protocols' directory. > + > + Such per-protocol entries subtree structure is freely defined > + within the related protocol code. > + > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index c1f503c6e72c..8a4664165a64 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h > index 585eb3a4684e..ed3eaa1482a3 100644 > --- a/include/linux/scmi_protocol.h > +++ b/include/linux/scmi_protocol.h > @@ -1164,7 +1164,6 @@ struct scmi_handle { > void (*devm_protocol_put)(struct scmi_device *sdev, u8 proto); > bool (*is_transport_atomic)(const struct scmi_handle *handle, > unsigned int *atomic_threshold); > - Unrelated. Scrub for this stuff before sending new versions. Saves time all round for a minute or two sanity checking. > const struct scmi_notify_ops *notify_ops; > }; >