mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sarah Maedel <sarah.maedel@hetzner-cloud.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andi Shyti <andi.shyti@kernel.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Benoît Monin" <benoit.monin@bootlin.com>,
	"David LaPorte" <dalaport@amazon.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] i2c: designware: Fix stuck master on multi-master buses
Date: Tue, 10 Nov 2026 16:43:28 +0100	[thread overview]
Message-ID: <20261110154330.78515-1-sarah.maedel@hetzner-cloud.de> (raw)

Since v7.0, the DesignWare controller used for IPMI SSIF on Ampere
Altra (DW_apb_i2c 1.20a) can get stuck after "spurious STOP detected"
errors, and stays unusable until a power cycle.

Patch 1 limits the spurious STOP check to controllers without
IC_EMPTYFIFO_HOLD_MASTER, as suggested by David LaPorte [1].

Patch 2 lets __i2c_dw_disable() abort a stuck master on configurations
without IC_STAT_FOR_CLK_STRETCH, where it otherwise never recovers.

Patch 2 was tested on Altra by forcing the stuck state through
/dev/mem. With both patches applied, IPMI commands in a loop no
longer hang the controller on a Gigabyte and an ASRock Rack Altra
server.

Both patches were prepared with the help of an AI coding assistant
(Claude Opus 5.5). I reviewed them and tested them as described above.

[1] https://lore.kernel.org/all/20260505232244.71807-1-dalaport@amazon.com/

Sarah Maedel (2):
  i2c: designware: Only check for spurious STOP without
    EMPTYFIFO_HOLD_MASTER
  i2c: designware: Abort stuck master when disabling times out

 drivers/i2c/busses/i2c-designware-common.c | 19 +++++++++++++++++++
 drivers/i2c/busses/i2c-designware-master.c |  7 +++++--
 2 files changed, 24 insertions(+), 2 deletions(-)


base-commit: b3dfbde62cf1981c4638939c159dfd087b7a72e9
-- 
2.47.3


             reply	other threads:[~2026-11-10 15:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 15:43 Sarah Maedel [this message]
2026-11-10 15:43 ` [PATCH 1/2] i2c: designware: Only check for spurious STOP without EMPTYFIFO_HOLD_MASTER Sarah Maedel
2026-11-10 15:43 ` [PATCH 2/2] i2c: designware: Abort stuck master when disabling times out Sarah Maedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110154330.78515-1-sarah.maedel@hetzner-cloud.de \
    --to=sarah.maedel@hetzner-cloud.de \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=benoit.monin@bootlin.com \
    --cc=dalaport@amazon.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®