From: Jakub Kicinski <kuba@kernel.org>
To: "Bilal Yazıcıoğlu" <ahmetbilalyazicioglu@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Mohsin Bashir <hmohsin@meta.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 0/2] selftests: drv-net: ring_reconfig: handle devices without channel config
Date: Tue, 10 Nov 2026 17:22:21 -0800 [thread overview]
Message-ID: <20261110172221.49db2576@kernel.org> (raw)
In-Reply-To: <20261110161423.77910-1-ahmetbilalyazicioglu@gmail.com>
On Tue, 10 Nov 2026 19:14:21 +0300 Bilal Yazıcıoğlu wrote:
> ring_reconfig.py assumes that a device which supports ring parameters
> also supports changing its channels. Drivers without a get_channels op,
> such as e1000e, return -EOPNOTSUPP for the channel query, and drivers
> with get_channels but no set_channels, such as vmxnet3 and r8169,
> return it for every channel change. The resulting NlError makes the
> tests fail instead of skipping them.
The test is fine, please don't waste our time.
prev parent reply other threads:[~2026-11-11 1:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 16:14 Bilal Yazıcıoğlu
2026-11-10 16:14 ` [PATCH net v2 1/2] " Bilal Yazıcıoğlu
2026-11-10 16:14 ` [PATCH net v2 2/2] selftests: drv-net: ring_reconfig: skip tx stall test " Bilal Yazıcıoğlu
2026-11-11 1:22 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110172221.49db2576@kernel.org \
--to=kuba@kernel.org \
--cc=ahmetbilalyazicioglu@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hmohsin@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®