mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Lebedev <lsa.uz@pm.me>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
	Sylvain Petinot <sylvain.petinot@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: "Dan Scally" <dan.scally@ideasonboard.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Peter Marshall" <pm@petermarshall.ca>,
	"George Neacsu" <geocausa@gmail.com>,
	"Hao Yao" <hao.yao@intel.com>,
	"Fernando Rimoli" <fernandorimoli11@gmail.com>,
	"D. Manresa" <dmanresa@gmail.com>,
	"Jizhou Tong" <fqwqf@fqwqf.xyz>,
	linux-media@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 3/6] platform/x86: int3472: Map the VD55G0 supplies to "vddio" and "vana"
Date: Tue, 10 Nov 2026 19:55:26 +0000	[thread overview]
Message-ID: <20261110195454.48176-4-lsa.uz@pm.me> (raw)
In-Reply-To: <20261110195454.48176-1-lsa.uz@pm.me>

The ST VD55G0 IR camera of the Surface Pro 11 with Intel (ACPI HID
SMO55F0) is powered through two GPIOs of an INT3472 discrete device: the
power enable, and type 0x10, which int3472 calls DOVDD. Which rail each
one feeds is not documented, and it cannot be measured here: the sensor
answers on I2C only with both on.

Intel's own control logic driver names type 0x10 Avdd, so map it to
"vana". The power enable takes "vddio"; whether it feeds VDDIO or VCORE
is not known either. VCORE is not described, so the driver gets a dummy
regulator for it. The vd55g0 driver enables all three together, so the
names do not change what the sensor gets.

Signed-off-by: Sergey Lebedev <lsa.uz@pm.me>
---
New in v4, so that 2/6 uses the same supply names on DT and ACPI
(Sakari). 2/6 needs it on ACPI.

 drivers/platform/x86/intel/int3472/discrete.c | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
index b19ea6ee337..a7098b08f8b 100644
--- a/drivers/platform/x86/intel/int3472/discrete.c
+++ b/drivers/platform/x86/intel/int3472/discrete.c
@@ -150,6 +150,17 @@ static const char * const power_enable_hids_vdda[] = {
 	NULL
 };
 
+static const char * const power_enable_hids_vddio[] = {
+	"SMO55F0", /* vd55g0 on Microsoft Surface Pro 11 */
+	NULL
+};
+
+/* Intel's own name for type 0x10 is Avdd */
+static const char * const dovdd_hids_vana[] = {
+	"SMO55F0", /* vd55g0 on Microsoft Surface Pro 11 */
+	NULL
+};
+
 /**
  * struct int3472_gpio_map - Map GPIOs to whatever is expected by the
  * sensor driver (as in DT bindings)
@@ -199,6 +210,20 @@ static const struct int3472_gpio_map int3472_gpio_map[] = {
 		.con_id = "vana",
 		.enable_time_us = GPIO_REGULATOR_ENABLE_TIME,
 	},
+	{	/* Sensors which expect "vddio" as con_id for power enable */
+		.hids = power_enable_hids_vddio,
+		.type_from = INT3472_GPIO_TYPE_POWER_ENABLE,
+		.type_to = INT3472_GPIO_TYPE_POWER_ENABLE,
+		.con_id = "vddio",
+		.enable_time_us = GPIO_REGULATOR_ENABLE_TIME,
+	},
+	{	/* Sensors which expect "vana" as con_id for DOVDD */
+		.hids = dovdd_hids_vana,
+		.type_from = INT3472_GPIO_TYPE_DOVDD,
+		.type_to = INT3472_GPIO_TYPE_DOVDD,
+		.con_id = "vana",
+		.enable_time_us = GPIO_REGULATOR_ENABLE_TIME,
+	},
 };
 
 static bool int3472_gpio_map_hids_match(struct acpi_device *adev,
-- 
2.54.0



  parent reply	other threads:[~2026-11-10 19:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 19:54 [PATCH v4 0/6] media: Add the ST VD55G0 global shutter sensor Sergey Lebedev
2026-11-10 19:55 ` [PATCH v4 1/6] dt-bindings: media: i2c: st,vd55g1: Add ST VD55G0 Sergey Lebedev
2026-11-10 19:55 ` [PATCH v4 2/6] media: i2c: Add ST VD55G0 global shutter sensor driver Sergey Lebedev
2026-11-10 19:55 ` Sergey Lebedev [this message]
2026-11-10 19:55 ` [PATCH v4 4/6] media: ipu-bridge: Add ST VD55G0 Sergey Lebedev
2026-11-10 19:55 ` [PATCH v4 5/6] media: ipu-bridge: Index the sensor device properties as the endpoint ones Sergey Lebedev
2026-11-10 19:55 ` [PATCH v4 6/6] media: ipu-bridge: Add the Surface Pro 9 and 11 infrared illuminator Sergey Lebedev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110195454.48176-4-lsa.uz@pm.me \
    --to=lsa.uz@pm.me \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmanresa@gmail.com \
    --cc=fernandorimoli11@gmail.com \
    --cc=fqwqf@fqwqf.xyz \
    --cc=geocausa@gmail.com \
    --cc=hansg@kernel.org \
    --cc=hao.yao@intel.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pm@petermarshall.ca \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sylvain.petinot@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®