From: Ian Bridges <icb@fastmail.org>
To: koray.fra@gmail.com
Cc: linkinjeon@kernel.org, senozhatsky@chromium.org, tom@talpey.com,
chenxiaosong@chenxiaosong.com, mmakassikis@freebox.fr,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
Ian Bridges <icb@fastmail.org>
Subject: Re: [PATCH] ksmbd: set create_time to btime in ksmbd_vfs_fill_dentry_attrs()
Date: Tue, 10 Nov 2026 13:56:25 -0600 [thread overview]
Message-ID: <20261110195625.3211657-1-icb@fastmail.org> (raw)
In-Reply-To: <20261110161659.481208-1-koray.fra@gmail.com>
Hi,
On Tue, Nov 10, 2026 at 05:16:59PM +0100, koraynilay wrote:
> ksmbd_vfs_fill_dentry_attrs() queries vfs_getattr() with STATX_BTIME,
> but discards ksmbd_kstat->kstat->btime and unconditionally initializes
> ksmbd_kstat->create_time to ksmbd_kstat->kstat->ctime.
I tested this on a kernel whose fs/smb/server matches ksmbd-for-next,
with files and a directory created on the server, so without the DOS
attribute xattr. Before the patch, a directory listing reported their
ctime as the creation time, while a query on the open file reported
the btime. With the patch, both report the btime. A file created over
SMB keeps its stored creation time in both. smbtorture gives the same
results as without the patch, and KASAN reports nothing.
Reviewed-by: Ian Bridges <icb@fastmail.org>
Tested-by: Ian Bridges <icb@fastmail.org>
prev parent reply other threads:[~2026-11-10 19:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 16:16 koraynilay
2026-11-10 19:56 ` Ian Bridges [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110195625.3211657-1-icb@fastmail.org \
--to=icb@fastmail.org \
--cc=chenxiaosong@chenxiaosong.com \
--cc=koray.fra@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmakassikis@freebox.fr \
--cc=senozhatsky@chromium.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®