From: Joas Antonio dos Santos via B4 Relay <devnull+joasantonio108.gmail.com@kernel.org>
To: mkl@pengutronix.de, mailhol@kernel.org, joasantonio108@gmail.com
Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: [PATCH v2 0/2] can: kvaser_usb: validate values received from the device
Date: Wed, 11 Nov 2026 17:23:57 +0000 [thread overview]
Message-ID: <20261111-kvaser-usb-validate-v2-0-193dc10ca19b@gmail.com> (raw)
Two fixes for values that kvaser_usb takes from the USB device without
checking them.
Patch 1 rejects hydra commands whose length is shorter than a standard
command. A length of zero otherwise stalls the command loops, and a
short extended command makes the handlers read past the command.
Patch 2 rejects devices that report zero max outstanding tx, which
otherwise leads to a division by zero.
These issues were found with the help of an LLM-based code review tool
(Claude). I checked the code paths by hand against v7.4-rc3 and
reviewed the fixes myself. They are build-tested only (W=1, arm64); I
do not have the hardware to test them at runtime.
---
Changes in v2:
- Patch 1: require at least sizeof(struct kvaser_cmd) instead of the
4-byte header, so that the extended command handlers do not read past
a short command (sashiko review of v1). Subject changed, it was
"can: kvaser_usb: hydra: reject commands shorter than the header".
- Patch 2: unchanged.
- Link to v1: https://lore.kernel.org/r/20261110-kvaser-usb-validate-v1-0-f266b85aa908@gmail.com
---
Joas Antonio dos Santos (2):
can: kvaser_usb: hydra: reject commands shorter than a standard command
can: kvaser_usb: reject devices reporting zero max outstanding tx
drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 6 ++++++
drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c | 8 +++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
---
base-commit: b3dfbde62cf1981c4638939c159dfd087b7a72e9
change-id: 20261110-kvaser-usb-validate-33c2e34b63bf
Best regards,
--
Joas Antonio dos Santos <joasantonio108@gmail.com>
next reply other threads:[~2026-11-11 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 17:23 Joas Antonio dos Santos via B4 Relay [this message]
2026-11-11 17:23 ` [PATCH v2 1/2] can: kvaser_usb: hydra: reject commands shorter than a standard command Joas Antonio dos Santos via B4 Relay
2026-11-11 17:23 ` [PATCH v2 2/2] can: kvaser_usb: reject devices reporting zero max outstanding tx Joas Antonio dos Santos via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111-kvaser-usb-validate-v2-0-193dc10ca19b@gmail.com \
--to=devnull+joasantonio108.gmail.com@kernel.org \
--cc=joasantonio108@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®