Re: [PATCH 1/4] dt-bindings: watchdog: loongson,ls1x-wdt: Add ls7a-wdt compatible

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

On Wed, Nov 11, 2026 at 11:17:48AM +0800, Rong Zhang wrote:
> Hi Conor,
> 
> Thanks for the review.
> 
> On Tue, 2026-11-10 at 18:58 +0000, Conor Dooley wrote:
> > On Tue, Nov 10, 2026 at 03:02:30PM +0800, Rong Zhang wrote:
> > > The Loongson-7A has a watchdog, which is similar to Loongson 2K0300,
> > > except that it has no clock controller.
> > 
> > I find this hard to believe, the device seems to be getting a clock from
> > somewhere that the clock-frequency property is providing the rate of.
> 
> I must be losing my mind when I wrote this. My thought was "software
> cannot control the clock" but my finger typed "no clock controller".

No worries, I lose my mind more often than I would like ;)

> > Why is that clock not represented in devicetree?
> 
> I will add a fixed-clock node in v2.

It's probably worth taking a look at what other devices share that same
clock. Probably all of the uarts use this clock too, given the identical
clock-frequency, and could be updated (in a separate patch) to use it?

Cheers,
Conor.

pw-bot: changes-requested

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]