From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=100.103.45.18 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1794381591; b=ez+oUkIgBZ0R/nDPePgdx/5ei/Fd0o3lRCC46LZPVws+n/D/SGUB+v36B90rc3aA7Fk6 MSdIsKfjmfpt7BDwPNhWTGkTQfSXrNKnjhtw9bWxiLU0dYZar7ixnEyiMDKUD9VT3T0fy wFWimckykJ6JgFdI9hRb3jKPoTo5i8cOnYIBne3u4duGymXBME/7sF0tmy7Am2rRHcU+J vv34CzfkCjZW+YEOk3mTN3nq7Ndm6LNXbA7tvnF9M6BcJKqs3eQOr03SwBeLQukDWvNTE oQ+u5Xu1EsfYxVjVd2AZ052oNLaUtscK1hnF+CtFil/HFUMlWwFAqgQ3IEUiZSL/mvw== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794381591; h=Received:DKIM-Signature:Received:From:Date:Subject:MIME-Version: Content-Type:Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Endpoint-Received: X-Original-From:Reply-To:Content-Transfer-Encoding; bh=9m1iAeouVAj4F1HOa9zNEIXietvCGZ4AUJji/MyAt+Q=; b=0X21rIlTgRqqzzU1QY9N1du4RFyumg6mZwTrZt5VuXlaihwxqm7M0MKKDaipy3NOyBtl 1tN9NJG73h/s/BVaYi2JqD1kt5tIK0sEpBlhdY6mhBmeKizmghhKousEVZws1p7d/ifyZ A1HvNUZnVwkqmyFroRbMmyVVeqVaDE/gB6bRekSOskh3qQexqAu/Rly5Vn2uuX/mpxcml XQkfRHBWBiNZbPx9e2CsvinsBfJZ/z5vcxw7QmbLYrwd+QTAIzeDB3Yn23PZF9aaGSB/S B0PazpjC/6+JRLH0y8xKArgeDi4N3vUgzDlC3Gjj+0jJggnXcVsW3IE+6859RVUlFUA== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VB5QEXKs; arc=pass header.oldest-pass=0 smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFCF5606A33A; Wed, 11 Nov 2026 07:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VB5QEXKs Authentication-Results: smtp.kernel.org; arc=none smtp.remote-ip=100.80.115.77 ARC-Seal: i=1; d=kernel.org; s=arc20260519; a=rsa-sha256; cv=none; t=1794381591; b=hTLOgfBKI+lj4I3/tcqoPDViJj50tI3XLTumhxgrXMC/0jIsGaGszHSPmYAGG7SDBSd4 SUHGPMA4bLsWv8xGsfywivu1nVPjs9ibDbQOMlxUrG5oucUOa15jR5u0sJYFjPf/xB8DZ 2C8HRCCEwYGlw9o69YHPFfYfHn/aUUJUrLwGPl9A+ZMcSjgOuJMSsYd66Jsqi43SrWJlk Nb/lIPGFDrzX063/sGukTGKEK4gW0mL3beO9toLSIA61YhTBsDzGWFak8oITcIUMBCSCy /DjTh3KtIIswKlsRhDUan5pYD/lYNzBpdL7SXWQ969g75GigkvzCaxfkwXy1u0zYvgQ== ARC-Message-Signature: i=1; d=kernel.org; s=arc20260519; a=rsa-sha256; c=relaxed/relaxed; t=1794381591; h=DKIM-Signature:Received:From:Date:Subject:MIME-Version:Content-Type: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Endpoint-Received: X-Original-From:Reply-To:Content-Transfer-Encoding; bh=9m1iAeouVAj4F1HOa9zNEIXietvCGZ4AUJji/MyAt+Q=; b=N9aEP1wFYkCb6o/UxbSnoBzFFyYTPM+ee5WXCn23r1q0k+9uzOEbK5QKdAXojYbCi0Ms K0nWh6WTDdUUUfjCsqzphayZ8wP/YMRkB4ezqhhCPTU6aQWTGU+G4PYiKuYp0aEgOFQXs WxmkbGTvg+V9K5w3Vs9arGAdU9jjSYMQr27Jqkf6vDBe6cWQIp3uzKL13QYYI30VlHBbY c9HkKWrXEPz37PAupgM07aXg7qNArfv4bgBa3OhPTD+Nobs1M+GMG94L/dbR/EKPhyp5A FVSwkdIgTHCNCsrYAHvmalC5/xs4gQwGKkGLIrvaRJRodxm73R02EDpvp/Xn/2epp9A== ARC-Authentication-Results: i=1; smtp.kernel.org; arc=none smtp.remote-ip=100.80.115.77 Received: from lkml.kernel.org (nexus.subspace.kernel.org [100.80.115.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 314E51F00A0A; Wed, 11 Nov 2026 07:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794381591; bh=9m1iAeouVAj4F1HOa9zNEIXietvCGZ4AUJji/MyAt+Q=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To; b=VB5QEXKstkdY3oOhVT/0RkZEiw9g4doGvD4wKT5eQHUkG5ntpxX4QkYQ6z4BY5CbR oYPDYy9+JyXgQu9Mk+23bT5nrKUTDeXsDki4y76Ooq70kpsAvsYe7/Dxtc3z30jl4i kMdJIRulrcD1A4llznj2rAfI65XA22YHJ1lHee3NQfFG90p2KXafpo9FvPpwfuoXdh j/L8ME6R+ZgO7T3+7MrPcv1U9EXYXk1ezBLAa6btOYqh4TsUmkAZN7SnZzmVaISaJA HDLBFMZ3kEGwNK2L4uQPpVNWBLXiytV7xdh/nesNogv2ShZ/VhiX5Z/xdR0FwQaBdk HnjKbjKzfFU8A== Received: from nexus.subspace.kernel.org (localhost [IPv6:::1]) by lkml.kernel.org (Postfix) with ESMTP id B370248E4B; Wed, 11 Nov 2026 07:19:49 +0000 (UTC) From: Arun Iyengar via B4 Relay Date: Wed, 11 Nov 2026 07:19:49 +0000 Subject: [PATCH v2 1/3] arm64: dts: rockchip: use rgmii-id for the Orange Pi 5/5B ethernet PHY X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Message-Id: <20261111-opi5-dts-v2-1-821f666418a6@gmail.com> References: <20261111-opi5-dts-v2-0-821f666418a6@gmail.com> In-Reply-To: <20261111-opi5-dts-v2-0-821f666418a6@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Arun Iyengar X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1794381589; l=1895; i=aiyengar1990@gmail.com; s=20261110; h=from:subject:message-id; bh=tvDxnxzJS+qXTLT+S+2SEXSC6rLShYZjDQnh9IALLos=; b=lnyHB7N/nE5oteOdOo3aGqGL6oboZhpQwUp9nonKn8fssqXvBWA7+1eCQHDJhPHv/LrwnGOhS 8BhiEf4sKmXCuVUzlTfp83d/CPMhehKxOMkRVKjdX8GmK7ljpdUS6OI X-Developer-Key: i=aiyengar1990@gmail.com; a=ed25519; pk=zXpRgUTrhaFe6jLyPqbBy3ccfkj04w0g2690Wv3mg+0= X-Endpoint-Received: by B4 Relay for aiyengar1990@gmail.com/20261110 with auth_id=1480 X-Original-From: Arun Iyengar Reply-To: aiyengar1990@gmail.com Content-Transfer-Encoding: 7bit From: Arun Iyengar The Orange Pi 5 and 5B have a Motorcomm YT8531C RGMII PHY on gmac1 (the PHY driver binds as "YT8531 Gigabit Ethernet"). The board neither uses extra long clock traces for TX nor for RX, yet the device tree describes it as "rgmii-rxid", which according to ethernet-controller.yaml means that the PCB provides the TX delay, and then makes the MAC insert the TX delay with tx_delay = <0x42>. The setting was copied from the vendor kernel, which uses the MAC delay lines everywhere. Describe the PCB correctly as "rgmii-id" and drop tx_delay, so that the MAC adds no delay and the PHY adds both: motorcomm.c programs its default 1950 ps for RX (as now) and for TX. This is the setup the binding recommends, and the one the same vendor's Orange Pi CM5 (rk3588s-orangepi-cm5-base.dts), with a YT8531C on gmac1 of the same SoC, already uses in mainline. Besides being the correct description, this removes the MAC from the timing path for both directions, so no board-specific delay-line value is needed any more. Signed-off-by: Arun Iyengar --- arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-5b.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-5b.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-5b.dtsi index c153e7248727..7c1fd5905553 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-5b.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5-5b.dtsi @@ -97,14 +97,13 @@ vcc_3v3_sd_s0: regulator-vcc-3v3-sd-s0 { &gmac1 { clock_in_out = "output"; phy-handle = <&rgmii_phy1>; - phy-mode = "rgmii-rxid"; + phy-mode = "rgmii-id"; pinctrl-0 = <&gmac1_miim &gmac1_tx_bus2 &gmac1_rx_bus2 &gmac1_rgmii_clk &gmac1_rgmii_bus>; pinctrl-names = "default"; - tx_delay = <0x42>; status = "okay"; }; -- 2.55.0