From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.167.170 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794446915; b=DhzXQ7jRqaiyuzOnQctX9igiYBFYudF+cNyqnhg/YjvENotmWxTkvQgaUzYF5ZRX2NOj jDptIg+8vo+xQLDmbewr9r7+o7gtD5cMyvNDccXSaXvDn8iasHAg96A/io2dRa7MbZLp2 0YGWgc7MuJ4UtQoY3RY1UHC8m0bDQl7OGEwzosfevUSnbC5Z/AhmeJ8beBgDbl1eEZSrQ FRy9fNg6vGOjl/6+Qu9XS4V0oSwAkeDUh98Uj/nyCoPnMms0xRBAvcKLcrIO1Udu73CaA DBWo4G7L9C74/hR1apwtTytM1w/3kpn2nlbdlTu1u6TkZ1el0WsjBt48ThBnJNktK/A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794446915; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer; bh=hMhTaF/Lq9srjx6odTOPS5fFn4jWcOaxw/rA3kVk6mw=; b=tWnCkiUT2/81/vXRenbd1KqLtvPRBj0ndjD2AWtOUYwYP+rPZ/vSdzFmXwCXUomIG7/8 SBHcRRxfMR3qjWufNPfEJCXawQO27Q8qGIbBbxPrOIU3IYcQX8bJ/U1HWfDIBKmoTorAh D4iDKSadiU1HVmKaVJKxlMYedQWH+CxKZo52xo7LrH2Betty1u86rY2yYCsd7I5ZBsq1s pLbHhjOGvS5+bcNA0hhn3v9te8P+gIfTJbWnNSW531xhHPohN4hWLshog9DvseEBFtH7Y WeXHhrIY9o0E22ef1vXb6v4kx5dAlK6tA4L3tIkjdZi/n7j+EB0ojFqDNBom8Jl8p8A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Ft60jEar; arc=none smtp.remote-ip=209.85.167.170 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96584606A89B for ; Thu, 12 Nov 2026 01:28:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 96584606A89B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Ft60jEar Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-4b28d7c729fso2410864b6e.0 for ; Wed, 11 Nov 2026 17:28:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794446914; x=1795051714; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hMhTaF/Lq9srjx6odTOPS5fFn4jWcOaxw/rA3kVk6mw=; b=Ft60jEarPtx0hNpSomwSF4iDyWBMHugvqsaq3xIKNIxjpXYyk1JtTuj5I3Mav9qW1r RM3h3xSsBLFh9d9TK911FdbzytOsNSViYzTvzV1KYAfjiF3WMizQGtr2wjPkuKvd3h5q 13asI3rQFzNrgX4rLBxbbr50FfYmPh2MM4wmtyCG9O0fPH5mO04Tjw1ULDcPz/vroAi9 pPdFmzYjfxrbZTqCuNGolUWuiepAVPQ2VpS3lKn/q6a0q5th19liL7/pOZ+lnzsTIkYh EmVFZ4gmOt18/RqpK9EAc0Xw2AKa/iBapt8ZA3DRteKtu1q3NO6xs0/SpfQ96r5sRjnO xVWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794446914; x=1795051714; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hMhTaF/Lq9srjx6odTOPS5fFn4jWcOaxw/rA3kVk6mw=; b=xiudLnb/dYcvC95HwyiR7akrlaiySg9VJiPcLWDvx+zY28luotBevBCOvE4TWIlkk4 jzqsvprLr8omqmSbeOnwnGvGo/BAt92CBb0vnHZ8h3J1gyH0PYeUXjo+TNbtqD4DKl5E aXQfWLyfigJLvr0AmSjHsrWNg3iX1w6T4kYVKolP/Q2MnrdMXUfGi3fwpJmagZ8EiPXa NWw+dA6PYgVJUC55G26I5D4Dly4hsT1fEiHHgybSF7YtVf0T13//nKqxX5EpaSYZBr2E EPeJLwVU1/qpus8IJu9+Fdqmf43Yusq2/AW5f1Fdy9bINn1BZzAp09f2GST4yinrHNk1 /Nag== X-Forwarded-Encrypted: i=1; AL+hErHZYzeH3nQkdTgjKMC71RnWdyVKTaAMd3gEqYdA6dvzoPfYgWZ2ptjDzf4lE1KmH35kDsCteH+IFeRfYRI=@vger.kernel.org X-Gm-Message-State: APuU4Z9c974Bjw3bYD6RQ4/sBGJHbBpBd/ddWh5DzWXqU6aWSy6SFDJu Jq/FCdFnUNRE+9XmHcjXeJK3wCWUJ9hiSiZj2RJaqKqdV21Y+vMdbAmQ X-Gm-Gg: AYBFou03bewLpcji3dC4ZRDOU2s1SboJEi9IwpcukRXgAN9JveTM366U/idDjl3O8Ux YbFN6bfmYAMJ5uXmDTrzURjMustXp7f6KAF2APSdYsBovhRbbmX0YwpXB3gTgH9lktMSpBMDJQs 8Kdn2n+mh8vkmz2gu/trfgtdOaPYsqzv+0RKdUI1SCLQzr9y8+9clnGn9IqBPiKVZTcxE/RSyz+ Y60hfUyN0mQucKX0STmTfuDosJf8MkYdFdyLZ5BgtDTXjb0Ugj1dCTJA/OBTv2Ee7GAvNoRIz6P WxUxXgmDVRpVkcdjT9P8zaOCxmEYSHBUXfwOXEr4N8rVao29ssBl/dld80BsqECBf2H1T/dV0qr WxEcFHdvgz99rLcHN9/Ofr3FnTmlIgouJjnKhWABjOvSZHdgrUdrjbSiz2FMadfwXiSm4JsiVr2 t9sIB1ljr6J+n8vaeFhbKNX8eEVca6tdcB8nCf55BmEwgp5fPMfQifF8ZJa967YD1gx2MNkQ+60 2F/a+yftUC02+xhMpoZ5F88iADDkq8bYDmNgKzgOn3cj69CNqq17P9Xut6F08rfD6YlQTDNsGau egY6Nm9efqfEphiX58lXNWDIhB/Fuy03/OG1zPrgKxgv5Lwznc6B3WTgz8gGZV3oblfsaS/Ol29 DvR1W/1thJoFIv1nsw27+j3m/Q0Pm6sSwhHWxrRG5rDt4DTZ+CUJ+j5RQoHGIKOl3y3OVW0R4D/ /ajl4/Eu9snFydNtWQCCceG0dlNCh6Y+I5NMCjcRkiPqYimS6Q7uFbhQ== X-Received: by 2002:a05:6808:c12a:b0:4f4:4eef:52cc with SMTP id 5614622812f47-56b97717f4emr3821584b6e.43.1794446908845; Wed, 11 Nov 2026 17:28:28 -0800 (PST) Received: from [127.0.1.1] (174-29-1-49.hlrn.qwest.net. [174.29.1.49]) by smtp.gmail.com with ESMTPSA id 5614622812f47-56905738049sm6823481b6e.10.2026.11.11.17.28.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 17:28:28 -0800 (PST) From: James Hilliard Date: Wed, 11 Nov 2026 18:27:40 -0700 Subject: [PATCH v3 01/58] nvmem: disconnect provider callbacks before unregister returns X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261111-submit-rawnand-retained-handle-lifetime-v1-v3-1-ce537999741d@gmail.com> References: <20261111-submit-rawnand-retained-handle-lifetime-v1-v3-0-ce537999741d@gmail.com> In-Reply-To: <20261111-submit-rawnand-retained-handle-lifetime-v1-v3-0-ce537999741d@gmail.com> To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , James Hilliard , Srinivas Kandagatla , Tze Yee Ng X-Mailer: b4 0.15.2 An NVMEM consumer or device reference can outlive provider unbind. The reference retains the NVMEM allocation, but not the private data or hardware resources that the provider releases during remove. Pinning the provider module also does not prevent unbind from freeing that state. Reject new callback access once unregister starts and drain admitted accesses with SRCU before returning to the provider. Cover register access, keepout handling, cell post-processing and device matching. Existing consumers retain core-owned metadata and return -ENODEV after disconnection. Release the write-protect GPIO after the drain so retained references do not prevent a new provider from requesting it. The final device release frees only core-owned data. Give cell entries their own references and retire layout cells when their driver is unbound. Remove and drain cell attributes and callbacks before layout-owned state is freed. Rebinding creates new entries; held old cells remain disconnected. Remove partially added cells when a layout probe fails, and destroy the layout during provider unregister rather than at the final consumer put. Preserve the existing exporter-module references. Providers remain responsible for unregistering before releasing callback state. Retain the firmware node explicitly and serialize consumer-reference acquisition with disconnection. This lets MTD unregister an OTP provider before freeing its backing object without requiring a release callback into the departing provider module. Cc: Srinivas Kandagatla Cc: Tze Yee Ng Signed-off-by: James Hilliard --- drivers/nvmem/Kconfig | 1 + drivers/nvmem/core.c | 297 +++++++++++++++++++++++++++-------------- drivers/nvmem/internals.h | 13 +- drivers/nvmem/layouts.c | 2 + include/linux/nvmem-provider.h | 3 + 5 files changed, 206 insertions(+), 110 deletions(-) diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig index c36c2a4c2a0b..550f3118071a 100644 --- a/drivers/nvmem/Kconfig +++ b/drivers/nvmem/Kconfig @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only menuconfig NVMEM bool "NVMEM Support" + select SRCU imply NVMEM_LAYOUTS help Support for NVMEM(Non Volatile Memory) devices like EEPROM, EFUSES... diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 0556d140170a..8571d821591c 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -27,6 +27,9 @@ #define FLAG_COMPAT BIT(0) struct nvmem_cell_entry { + struct kref refcnt; + bool disconnected; + struct nvmem_layout *layout; const char *name; int offset; size_t raw_len; @@ -57,28 +60,25 @@ static BLOCKING_NOTIFIER_HEAD(nvmem_notifier); static int __nvmem_reg_read(struct nvmem_device *nvmem, unsigned int offset, void *val, size_t bytes) { - struct nvmem_operations *ops = nvmem->ops; - - if (!ops->reg_read) + if (!nvmem->reg_read) return -EOPNOTSUPP; - return ops->reg_read(nvmem->priv, offset, val, bytes); + return nvmem->reg_read(nvmem->priv, offset, val, bytes); } static int __nvmem_reg_write(struct nvmem_device *nvmem, unsigned int offset, void *val, size_t bytes) { - struct nvmem_operations *ops = nvmem->ops; int ret, wr_ok; - if (!ops->reg_write) + if (!nvmem->reg_write) return -EOPNOTSUPP; ret = gpiod_set_value_cansleep(nvmem->wp_gpio, 0); if (ret) return ret; - wr_ok = ops->reg_write(nvmem->priv, offset, val, bytes); + wr_ok = nvmem->reg_write(nvmem->priv, offset, val, bytes); ret = gpiod_set_value_cansleep(nvmem->wp_gpio, 1); if (ret) @@ -154,6 +154,10 @@ static int nvmem_access_with_keepouts(struct nvmem_device *nvmem, static int nvmem_reg_read(struct nvmem_device *nvmem, unsigned int offset, void *val, size_t bytes) { + guard(srcu)(&nvmem->srcu); + if (READ_ONCE(nvmem->disconnected)) + return -ENODEV; + if (!nvmem->nkeepout) return __nvmem_reg_read(nvmem, offset, val, bytes); @@ -163,6 +167,10 @@ static int nvmem_reg_read(struct nvmem_device *nvmem, unsigned int offset, static int nvmem_reg_write(struct nvmem_device *nvmem, unsigned int offset, void *val, size_t bytes) { + guard(srcu)(&nvmem->srcu); + if (READ_ONCE(nvmem->disconnected)) + return -ENODEV; + if (!nvmem->nkeepout) return __nvmem_reg_write(nvmem, offset, val, bytes); @@ -289,8 +297,6 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj, static umode_t nvmem_bin_attr_get_umode(struct nvmem_device *nvmem) { - struct nvmem_operations *ops = nvmem->ops; - umode_t mode = 0400; if (!nvmem->root_only) @@ -299,10 +305,10 @@ static umode_t nvmem_bin_attr_get_umode(struct nvmem_device *nvmem) if (!nvmem->read_only) mode |= 0200; - if (!ops->reg_write) + if (!nvmem->reg_write) mode &= ~0200; - if (!ops->reg_read) + if (!nvmem->reg_read) mode &= ~0444; return mode; @@ -333,7 +339,6 @@ static umode_t nvmem_attr_is_visible(struct kobject *kobj, { struct device *dev = kobj_to_dev(kobj); struct nvmem_device *nvmem = to_nvmem_device(dev); - struct nvmem_operations *ops = nvmem->ops; /* * If the device has no .reg_write operation, do not allow @@ -342,7 +347,7 @@ static umode_t nvmem_attr_is_visible(struct kobject *kobj, * can be forced into read-write mode using the 'force_ro' * attribute. */ - if (attr == &dev_attr_force_ro.attr && !ops->reg_write) + if (attr == &dev_attr_force_ro.attr && !nvmem->reg_write) return 0; /* Attribute not visible */ return attr->mode; @@ -468,9 +473,6 @@ static void nvmem_sysfs_remove_compat(struct nvmem_device *nvmem) static int nvmem_populate_sysfs_cells(struct nvmem_device *nvmem) { - struct attribute_group group = { - .name = "cells", - }; struct nvmem_cell_entry *entry; const struct bin_attribute **pattrs; struct bin_attribute *attrs; @@ -479,6 +481,9 @@ static int nvmem_populate_sysfs_cells(struct nvmem_device *nvmem) guard(mutex)(&nvmem_mutex); + if (nvmem->disconnected) + return -ENODEV; + if (list_empty(&nvmem->cells) || nvmem->sysfs_cells_populated) return 0; @@ -511,9 +516,10 @@ static int nvmem_populate_sysfs_cells(struct nvmem_device *nvmem) i++; } - group.bin_attrs = pattrs; + nvmem->cells_group.name = "cells"; + nvmem->cells_group.bin_attrs = pattrs; - ret = device_add_group(&nvmem->dev, &group); + ret = device_add_group(&nvmem->dev, &nvmem->cells_group); if (ret) return ret; @@ -540,8 +546,8 @@ static void nvmem_release(struct device *dev) struct nvmem_device *nvmem = to_nvmem_device(dev); ida_free(&nvmem_ida, nvmem->id); - gpiod_put(nvmem->wp_gpio); - kfree(nvmem->ops); + of_node_put(nvmem->dev.of_node); + cleanup_srcu_struct(&nvmem->srcu); kfree(nvmem); } @@ -553,22 +559,30 @@ static const struct bus_type nvmem_bus_type = { .name = "nvmem", }; -static void nvmem_cell_entry_drop(struct nvmem_cell_entry *cell) +static void nvmem_cell_entry_release(struct kref *ref) { - blocking_notifier_call_chain(&nvmem_notifier, NVMEM_CELL_REMOVE, cell); - scoped_guard(mutex, &nvmem_mutex) - list_del(&cell->node); + struct nvmem_cell_entry *cell = container_of(ref, struct nvmem_cell_entry, refcnt); + of_node_put(cell->np); kfree_const(cell->name); kfree(cell); } +static void nvmem_cell_entry_put(struct nvmem_cell_entry *cell) +{ + kref_put(&cell->refcnt, nvmem_cell_entry_release); +} + static void nvmem_device_remove_all_cells(const struct nvmem_device *nvmem) { struct nvmem_cell_entry *cell, *p; - list_for_each_entry_safe(cell, p, &nvmem->cells, node) - nvmem_cell_entry_drop(cell); + list_for_each_entry_safe(cell, p, &nvmem->cells, node) { + blocking_notifier_call_chain(&nvmem_notifier, NVMEM_CELL_REMOVE, cell); + scoped_guard(mutex, &nvmem_mutex) + list_del(&cell->node); + nvmem_cell_entry_put(cell); + } } static void nvmem_cell_entry_add(struct nvmem_cell_entry *cell) @@ -583,6 +597,7 @@ static int nvmem_cell_info_to_nvmem_cell_entry_nodup(struct nvmem_device *nvmem, struct nvmem_cell_entry *cell) { cell->nvmem = nvmem; + cell->disconnected = false; cell->offset = info->offset; cell->raw_len = info->raw_len ?: info->bytes; cell->bytes = info->bytes; @@ -653,6 +668,10 @@ int nvmem_add_one_cell(struct nvmem_device *nvmem, struct nvmem_cell_entry *cell; int rval; + guard(srcu)(&nvmem->srcu); + if (READ_ONCE(nvmem->disconnected)) + return -ENODEV; + cell = kzalloc_obj(*cell); if (!cell) return -ENOMEM; @@ -663,6 +682,8 @@ int nvmem_add_one_cell(struct nvmem_device *nvmem, return rval; } + kref_init(&cell->refcnt); + cell->layout = nvmem->layout; nvmem_cell_entry_add(cell); return 0; @@ -729,6 +750,7 @@ nvmem_find_cell_entry_by_name(struct nvmem_device *nvmem, const char *cell_id) list_for_each_entry(iter, &nvmem->cells, node) { if (strcmp(cell_id, iter->name) == 0) { cell = iter; + kref_get(&cell->refcnt); break; } } @@ -795,6 +817,10 @@ int nvmem_add_cells_from_dt(struct nvmem_device *nvmem, struct device_node *np) const __be32 *addr; int len, ret; + guard(srcu)(&nvmem->srcu); + if (READ_ONCE(nvmem->disconnected)) + return -ENODEV; + for_each_child_of_node_scoped(np, child) { struct nvmem_cell_info info = {0}; @@ -851,29 +877,81 @@ int nvmem_layout_register(struct nvmem_layout *layout) if (!layout->add_cells) return -EINVAL; - /* Populate the cells */ - ret = layout->add_cells(layout); + scoped_guard(srcu, &layout->nvmem->srcu) { + if (READ_ONCE(layout->nvmem->disconnected)) + return -ENODEV; + ret = layout->add_cells(layout); + } if (ret) - return ret; + goto err_unregister; #ifdef CONFIG_NVMEM_SYSFS ret = nvmem_populate_sysfs_cells(layout->nvmem); - if (ret) { - nvmem_device_remove_all_cells(layout->nvmem); - return ret; - } + if (ret) + goto err_unregister; #endif return 0; + +err_unregister: + nvmem_layout_unregister(layout); + return ret; } EXPORT_SYMBOL_GPL(nvmem_layout_register); void nvmem_layout_unregister(struct nvmem_layout *layout) { - /* Keep the API even with an empty stub in case we need it later */ + struct nvmem_device *nvmem = layout->nvmem; + struct nvmem_cell_entry *cell, *next; + struct attribute_group group = {}; + LIST_HEAD(cells); + + scoped_guard(mutex, &nvmem_mutex) { + if (nvmem->sysfs_cells_populated) + group = nvmem->cells_group; + list_for_each_entry_safe(cell, next, &nvmem->cells, node) { + if (cell->layout != layout) + continue; + WRITE_ONCE(cell->disconnected, true); + list_move_tail(&cell->node, &cells); + } + } + + if (group.bin_attrs) { + device_remove_group(&nvmem->dev, &group); + scoped_guard(mutex, &nvmem_mutex) { + nvmem->sysfs_cells_populated = false; + memset(&nvmem->cells_group, 0, sizeof(nvmem->cells_group)); + } + for (int i = 0; group.bin_attrs[i]; i++) + devm_kfree(&nvmem->dev, (void *)group.bin_attrs[i]->attr.name); + devm_kfree(&nvmem->dev, (void *)group.bin_attrs[0]); + devm_kfree(&nvmem->dev, group.bin_attrs); + } + + /* Old cell handles retain data, never a departing layout's callbacks. */ + synchronize_srcu(&nvmem->srcu); + list_for_each_entry_safe(cell, next, &cells, node) { + blocking_notifier_call_chain(&nvmem_notifier, NVMEM_CELL_REMOVE, cell); + list_del(&cell->node); + nvmem_cell_entry_put(cell); + } +#ifdef CONFIG_NVMEM_SYSFS + if (!READ_ONCE(nvmem->disconnected) && nvmem_populate_sysfs_cells(nvmem)) + dev_warn(&nvmem->dev, "Failed to restore provider cell attributes\n"); +#endif } EXPORT_SYMBOL_GPL(nvmem_layout_unregister); +static void nvmem_disconnect(struct nvmem_device *nvmem) +{ + scoped_guard(mutex, &nvmem_mutex) + WRITE_ONCE(nvmem->disconnected, true); + synchronize_srcu(&nvmem->srcu); + gpiod_put(nvmem->wp_gpio); + nvmem->wp_gpio = NULL; +} + /** * nvmem_register() - Register a nvmem device for given nvmem_config. * Also creates a binary entry in /sys/bus/nvmem/devices/dev-name/nvmem @@ -883,10 +961,8 @@ EXPORT_SYMBOL_GPL(nvmem_layout_unregister); * Return: Will be an ERR_PTR() on error or a valid pointer to nvmem_device * on success. */ - struct nvmem_device *nvmem_register(const struct nvmem_config *config) { - struct nvmem_operations *ops; struct nvmem_device *nvmem; int rval; @@ -900,15 +976,15 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) if (!nvmem) return ERR_PTR(-ENOMEM); - ops = kzalloc_obj(*ops); - if (!ops) { + rval = init_srcu_struct(&nvmem->srcu); + if (rval) { kfree(nvmem); - return ERR_PTR(-ENOMEM); + return ERR_PTR(rval); } rval = ida_alloc(&nvmem_ida, GFP_KERNEL); if (rval < 0) { - kfree(ops); + cleanup_srcu_struct(&nvmem->srcu); kfree(nvmem); return ERR_PTR(rval); } @@ -918,10 +994,11 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) nvmem->dev.type = &nvmem_provider_type; nvmem->dev.bus = &nvmem_bus_type; nvmem->dev.parent = config->dev; - nvmem->ops = ops; device_initialize(&nvmem->dev); + nvmem->priv = config->priv; + if (!config->ignore_wp) nvmem->wp_gpio = gpiod_get_optional(config->dev, "wp", GPIOD_OUT_HIGH); @@ -935,8 +1012,8 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) INIT_LIST_HEAD(&nvmem->cells); nvmem->fixup_dt_cell_info = config->fixup_dt_cell_info; - ops->reg_read = config->reg_read; - ops->reg_write = config->reg_write; + nvmem->reg_read = config->reg_read; + nvmem->reg_write = config->reg_write; nvmem->owner = config->owner; if (!nvmem->owner && config->dev->driver) @@ -945,14 +1022,13 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) nvmem->word_size = config->word_size ?: 1; nvmem->size = config->size; nvmem->root_only = config->root_only; - nvmem->priv = config->priv; nvmem->type = config->type; nvmem->keepout = config->keepout; nvmem->nkeepout = config->nkeepout; if (config->of_node) - nvmem->dev.of_node = config->of_node; + nvmem->dev.of_node = of_node_get(config->of_node); else - nvmem->dev.of_node = config->dev->of_node; + nvmem->dev.of_node = of_node_get(config->dev->of_node); switch (config->id) { case NVMEM_DEVID_NONE: @@ -972,7 +1048,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) goto err_put_device; nvmem->read_only = device_property_present(config->dev, "read-only") || - config->read_only || !ops->reg_write; + config->read_only || !nvmem->reg_write; #ifdef CONFIG_NVMEM_SYSFS nvmem->dev.groups = nvmem_dev_groups; @@ -1010,7 +1086,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) rval = nvmem_populate_layout(nvmem); if (rval) - goto err_remove_dev; + goto err_unregister; /* If the device has WP GPIO, default to read-only */ if (nvmem->wp_gpio) @@ -1019,23 +1095,24 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) #ifdef CONFIG_NVMEM_SYSFS rval = nvmem_populate_sysfs_cells(nvmem); if (rval) - goto err_destroy_layout; + goto err_unregister; #endif blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem); return nvmem; -#ifdef CONFIG_NVMEM_SYSFS -err_destroy_layout: - nvmem_destroy_layout(nvmem); -#endif -err_remove_dev: - device_del(&nvmem->dev); +err_unregister: + nvmem_unregister(nvmem); + return ERR_PTR(rval); err_remove_cells: + nvmem_disconnect(nvmem); nvmem_device_remove_all_cells(nvmem); nvmem_sysfs_remove_compat(nvmem); + goto err_put_disconnected; err_put_device: + nvmem_disconnect(nvmem); +err_put_disconnected: put_device(&nvmem->dev); return ERR_PTR(rval); @@ -1048,24 +1125,29 @@ static void nvmem_device_release(struct kref *kref) nvmem = container_of(kref, struct nvmem_device, refcnt); - blocking_notifier_call_chain(&nvmem_notifier, NVMEM_REMOVE, nvmem); - - nvmem_sysfs_remove_compat(nvmem); - - nvmem_device_remove_all_cells(nvmem); - nvmem_destroy_layout(nvmem); - device_unregister(&nvmem->dev); + put_device(&nvmem->dev); } /** * nvmem_unregister() - Unregister previously registered nvmem device * * @nvmem: Pointer to previously registered nvmem device. + * + * Stop and drain provider callbacks before returning. Existing consumers keep + * their core-owned metadata, but further access returns -ENODEV. */ void nvmem_unregister(struct nvmem_device *nvmem) { - if (nvmem) - kref_put(&nvmem->refcnt, nvmem_device_release); + if (!nvmem) + return; + + nvmem_disconnect(nvmem); + nvmem_destroy_layout(nvmem); + blocking_notifier_call_chain(&nvmem_notifier, NVMEM_REMOVE, nvmem); + nvmem_sysfs_remove_compat(nvmem); + device_del(&nvmem->dev); + nvmem_device_remove_all_cells(nvmem); + kref_put(&nvmem->refcnt, nvmem_device_release); } EXPORT_SYMBOL_GPL(nvmem_unregister); @@ -1103,26 +1185,46 @@ struct nvmem_device *devm_nvmem_register(struct device *dev, } EXPORT_SYMBOL_GPL(devm_nvmem_register); +struct nvmem_match_data { + void *data; + int (*match)(struct device *dev, const void *data); +}; + +static int nvmem_match_device(struct device *dev, const void *data) +{ + const struct nvmem_match_data *match = data; + struct nvmem_device *nvmem = to_nvmem_device(dev); + + guard(srcu)(&nvmem->srcu); + if (READ_ONCE(nvmem->disconnected)) + return 0; + return match->match(dev, match->data); +} + static struct nvmem_device *nvmem_device_match(void *data, int (*match)(struct device *dev, const void *data)) { + struct nvmem_match_data match_data = { .data = data, .match = match }; struct nvmem_device *nvmem = NULL; struct device *dev; - scoped_guard(mutex, &nvmem_mutex) { - dev = bus_find_device(&nvmem_bus_type, NULL, data, match); - if (dev) - nvmem = to_nvmem_device(dev); - } + guard(mutex)(&nvmem_mutex); + dev = bus_find_device(&nvmem_bus_type, NULL, &match_data, nvmem_match_device); + if (dev) + nvmem = to_nvmem_device(dev); if (!nvmem) return ERR_PTR(-EPROBE_DEFER); + if (READ_ONCE(nvmem->disconnected)) { + put_device(dev); + return ERR_PTR(-ENODEV); + } + if (!try_module_get(nvmem->owner)) { dev_err(&nvmem->dev, "could not increase module refcount for cell %s\n", nvmem_dev_name(nvmem)); - - put_device(&nvmem->dev); + put_device(dev); return ERR_PTR(-EINVAL); } @@ -1337,8 +1439,10 @@ nvmem_cell_get_from_lookup(struct device *dev, const char *con_id) cell = ERR_PTR(-ENOENT); } else { cell = nvmem_create_cell(cell_entry, con_id, 0); - if (IS_ERR(cell)) + if (IS_ERR(cell)) { + nvmem_cell_entry_put(cell_entry); nvmem_device_put(nvmem); + } } break; } @@ -1347,12 +1451,6 @@ nvmem_cell_get_from_lookup(struct device *dev, const char *con_id) return cell; } -static void nvmem_layout_module_put(struct nvmem_device *nvmem) -{ - if (nvmem->layout && nvmem->layout->dev.driver) - module_put(nvmem->layout->dev.driver->owner); -} - #if IS_ENABLED(CONFIG_OF) static struct nvmem_cell_entry * nvmem_find_cell_entry_by_node(struct nvmem_device *nvmem, struct device_node *np) @@ -1362,25 +1460,15 @@ nvmem_find_cell_entry_by_node(struct nvmem_device *nvmem, struct device_node *np guard(mutex)(&nvmem_mutex); list_for_each_entry(cell, &nvmem->cells, node) { - if (np == cell->np) + if (np == cell->np) { + kref_get(&cell->refcnt); return cell; + } } return NULL; } -static int nvmem_layout_module_get_optional(struct nvmem_device *nvmem) -{ - if (!nvmem->layout) - return 0; - - if (!nvmem->layout->dev.driver || - !try_module_get(nvmem->layout->dev.driver->owner)) - return -EPROBE_DEFER; - - return 0; -} - /** * of_nvmem_cell_get() - Get a nvmem cell from given device node and cell id * @@ -1443,25 +1531,17 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np, const char *id) return ERR_CAST(nvmem); } - ret = nvmem_layout_module_get_optional(nvmem); - if (ret) { - of_node_put(cell_np); - nvmem_device_put(nvmem); - return ERR_PTR(ret); - } - cell_entry = nvmem_find_cell_entry_by_node(nvmem, cell_np); of_node_put(cell_np); if (!cell_entry) { - nvmem_layout_module_put(nvmem); - ret = nvmem->layout ? -EPROBE_DEFER : -ENOENT; + ret = READ_ONCE(nvmem->layout) ? -EPROBE_DEFER : -ENOENT; nvmem_device_put(nvmem); return ERR_PTR(ret); } cell = nvmem_create_cell(cell_entry, id, cell_index); if (IS_ERR(cell)) { - nvmem_layout_module_put(nvmem); + nvmem_cell_entry_put(cell_entry); nvmem_device_put(nvmem); } @@ -1575,8 +1655,8 @@ void nvmem_cell_put(struct nvmem_cell *cell) if (cell->id) kfree_const(cell->id); + nvmem_cell_entry_put(cell->entry); kfree(cell); - nvmem_layout_module_put(nvmem); nvmem_device_put(nvmem); } EXPORT_SYMBOL_GPL(nvmem_cell_put); @@ -1628,6 +1708,10 @@ static int __nvmem_cell_read(struct nvmem_device *nvmem, { int rc; + guard(srcu)(&nvmem->srcu); + if (READ_ONCE(nvmem->disconnected) || READ_ONCE(cell->disconnected)) + return -ENODEV; + rc = nvmem_reg_read(nvmem, cell->offset, buf, cell->raw_len); if (rc) @@ -1742,7 +1826,14 @@ static int __nvmem_cell_entry_write(struct nvmem_cell_entry *cell, void *buf, si struct nvmem_device *nvmem = cell->nvmem; int rc; - if (!nvmem || nvmem->read_only || + if (!nvmem) + return -EINVAL; + + guard(srcu)(&nvmem->srcu); + if (READ_ONCE(nvmem->disconnected) || READ_ONCE(cell->disconnected)) + return -ENODEV; + + if (nvmem->read_only || (cell->bit_offset == 0 && len != cell->bytes)) return -EINVAL; diff --git a/drivers/nvmem/internals.h b/drivers/nvmem/internals.h index 4e610deeaa7b..4e15699d381b 100644 --- a/drivers/nvmem/internals.h +++ b/drivers/nvmem/internals.h @@ -6,12 +6,7 @@ #include #include #include - -/* Hold pointers to callbacks owned by the nvmem provider module. */ -struct nvmem_operations { - nvmem_reg_read_t reg_read; - nvmem_reg_write_t reg_write; -}; +#include struct nvmem_device { struct module *owner; @@ -20,6 +15,8 @@ struct nvmem_device { int word_size; int id; struct kref refcnt; + struct srcu_struct srcu; + bool disconnected; size_t size; bool read_only; bool root_only; @@ -34,9 +31,11 @@ struct nvmem_device { unsigned int nkeepout; struct gpio_desc *wp_gpio; struct nvmem_layout *layout; - struct nvmem_operations *ops; + nvmem_reg_read_t reg_read; + nvmem_reg_write_t reg_write; void *priv; bool sysfs_cells_populated; + struct attribute_group cells_group; }; int nvmem_add_cells_from_dt(struct nvmem_device *nvmem, struct device_node *np); diff --git a/drivers/nvmem/layouts.c b/drivers/nvmem/layouts.c index 07a34be9669c..32995c9be68d 100644 --- a/drivers/nvmem/layouts.c +++ b/drivers/nvmem/layouts.c @@ -118,6 +118,7 @@ static int nvmem_layout_create_device(struct nvmem_device *nvmem, ret = device_add(dev); if (ret) { + nvmem->layout = NULL; put_device(dev); return ret; } @@ -192,6 +193,7 @@ void nvmem_destroy_layout(struct nvmem_device *nvmem) dev = &nvmem->layout->dev; of_node_clear_flag(dev->of_node, OF_POPULATED_BUS); device_unregister(dev); + WRITE_ONCE(nvmem->layout, NULL); } int nvmem_layout_bus_register(void) diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h index 6063fe5b7784..dcf4c52b62c6 100644 --- a/include/linux/nvmem-provider.h +++ b/include/linux/nvmem-provider.h @@ -107,6 +107,9 @@ struct nvmem_cell_info { * * Note: Specifying name and setting id to -1 implies a unique device * whose name is provided as-is (kept unaltered). + * + * Provider callbacks and @priv must remain valid until nvmem_unregister() + * returns, or until a failed nvmem_register() returns. */ struct nvmem_config { struct device *dev; -- 2.53.0