From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794357811; b=oozDMGI1bC3NJLNhV9eJDg8Kw9VlkTr9WXF7AV0c6J6fQdhaRmymEieqXIYBSLpoAcl4 YJSQcfrK/Rh9dImK5Yv2KwwVFiHsXwbvj2pRIZzI9zdO4pbwJZ68rAoaAK5VOlpM19V5o NSBMVQQwzmgQZqQyUpCTwqgFR2IOjBkWQVU2rgULv0iTT0iRC3WY422EETX3fWhQeR0aU 9ZBUXUPjXkxUKV7YO6M2XSn/Ja//z/xekmoOyOzZTl2cjiBOdIPOKhAc4yUhJiorSb6QE HxTh+AaD5x4n8L3rnSDokh8BaBQCHWYSEKa2fawH+Cxnfg2+YIFSm62KXQ1sp9BCr8w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794357811; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:Date: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Proofpoint-Spam-Details-Enc: X-Authority-Analysis:X-Proofpoint-Spam-Info:X-Proofpoint-GUID: X-Proofpoint-ORIG-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=rem+nrfKD98GZM8ZtF/WgXdv6SPv/ujdk/JlCqHr32o=; b=Fi751h+nSA0YUVVJ129jT3+vSucvS+kv09YgVmaAQxn8W19Z+EI7+gBck16GLXv34++d ZFxWpxopOoHXzve1B0RLMkGoV9n1MQMck2kMkbpBc8TF2OMaua21l+i65zBrxOGVfI/DM 2mDIM6xmL0cKm/1nPe1MMhq3QjhD9NEpLbnapFmEdBaYT5qEAjgK9Oc5/PRhp0D8pfARg INLG2V1OqCPDXBSL/Q5edlWEzx4U8eEhLAxFBjyuABSpqCW9K1gYDobVg48pfhtejqTaw AR5XKE0aCM8ORP2dJ//JevbepgcJNsDW1U1q1M9VH7mcSToPEx/fWwB6Pc64/393Q+Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=n2hRQDiy; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=FQnRacl4; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3F5A606A330 for ; Wed, 11 Nov 2026 00:43:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F3F5A606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=n2hRQDiy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=FQnRacl4 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AAMKKiM3714336 for ; Wed, 11 Nov 2026 00:43:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rem+nrfKD98GZM8ZtF/WgXdv6SPv/ujdk/JlCqHr32o=; b=n2hRQDiy6GFShLEd hSU+67EAvYYb1h6YchOYKSuTjMCeNR8TqEIQks2zfBEz1Jp4K2zLdG2d9BFxRZMu XFgBc9G3dWDpHFjhhgGhBZ/24BkgGmyeucBoZSghmMEtoa4y3ckvaBuqsji39c1w imS7ZEyUFUxuPadtPthUCleyU/NiaBGireIIDsjtQ54pF2QHPjWnbqnVyjbD+LjQ gR3DnrRYVxeb9qKc8lPDqsLNVd1HmRbCTBGzqd1xFDypA2yH3knNgUg6qi0Z4YqB dN73YKI5uSkYqO6cXwzk0gCPwZgXWNUs84VSNI0YxN3h8YwErxm1wQt29QICBhhk MZWgug== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4huyw4bjtx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Nov 2026 00:43:30 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-91ea71789d8so70412516d6.0 for ; Tue, 10 Nov 2026 16:43:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794357809; x=1794962609; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rem+nrfKD98GZM8ZtF/WgXdv6SPv/ujdk/JlCqHr32o=; b=FQnRacl4IQK4jyV9tQPmlKyMZMsZHzq9XidoGLwKGcAzwkbaH88rosNB/QV2i9UpMt bR04H6KMFctS+/OTinyjOaeb46RBV9AVZsy07iZ8YYt3rqB4GDfcfF75RrpU0M7DVWLE SgPXyoSG8AHzL3swPgn9s+pgpuQ0pbnmjCFgI295o5qFwHZBPewpQ3U4+NXKUL5uYraz +hy7aKNMMuEuNXrZvFaJPNBAv8sG7n8A2ECDgiPjZELxNa4F6sQQTh2E4VRBOepK86Og UJb0N7S1guFEaWMkc9mev/+tZQ8y9mhs4G7cdWVHc3Ksj/WWg9BSuO209TnON1C3tUGA Exeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794357809; x=1794962609; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rem+nrfKD98GZM8ZtF/WgXdv6SPv/ujdk/JlCqHr32o=; b=JRUHKzrk0Vaa87+erYRfxL8IGWlHLhy6f+8dkttBLQG4l6wzjF/YViX15CtGUDrEqZ FwUhO6ws8WKyOoTrkMC43f7KAB59x+K30HzfSDJz8DAaxSCEYZBxZPqYOqgfEmNtkscJ qmibiMFXlg/zAIDUQHc1IJnznxPs9Qg1WFlecdlGc46D7YYyoA5LnqACfItH1VfGvwSh 7v6ovqvm2O25S4zBu5GiF40Ktn2OGkZQrMnfSwTvi3A5CcglGHgegBk66SJObLU02jVo TT5fMkV8/3ajpqJQMQwyWezAefnyp7Zh/STSGlfqg4LjuMQhmEPC2vy0QLHqxCqNlP81 tIjg== X-Forwarded-Encrypted: i=1; AL+hErHuYQISi/zMFzQwjMTEa5EAvUnVBQtMUQJymeKa0Xqzv8JutxuA7xOxM+umZUwvrRMKHvsfEtWoL3X12Eo=@vger.kernel.org X-Gm-Message-State: APuU4Z/Qv0geQmD9+YIPbee74tpZf97osPotZwSbZ5IDLkHGdBz09kmQ 4x3UelQNYckjKXzHxLbRYo+Ondl2s+UAwtinejp+NPTG5IpoZ1Lcd3Fjz06k2q35dLLcezep0xa Pl7Fj7yPNm1/VXkilIp+PviS452nRcfoIvQpXF/rYHU59qcjE4kpO/VVtzuZGguBNp/Y= X-Gm-Gg: AYBFou1V9C4RTO/qE1nuGTYZFPWIQVwEMa9ez3yocRGCqn+0a88G0nHWv2kh63Jwhmb FfJni2cmqMoOnAyHxOsNDMBbTRtEhWLxUPg4/MySPoEAt58usGbZldaLq2J+Ke7Vy04u3abhCXC uHSwy6YGxuVolD/QsVgZrg2VGEAJu8luD63jWu1jvcJvqaTAPOzXXsF7Ga/WnLQKamcfpD54QXr v0MaK0Ah5QCNZTw56e+ii70je3CzH4MsqBF+uvxMzLuKJUJGK4Dj4IybuIrFP1127HcZDUJG7c8 6lPmbkOYUkDHdCObGP54MtrBPzFhErA2TG06WCsnlnCYZzQm3os1+si/oBCfI/E+jvHjtoccOot N5DFsgTcqsxZbvTUEyt6a5PfFk/GBwnBQVIX8sl+xWNkkUDpzNebvT1qe/C5dLfmq4vhxzpgU3X rFY+5hOKoyxD73BkwoYz7gXbEjuEsZGkm/xcYUrM/NeXX4vulU3Zy8oiXLO45ApQ== X-Received: by 2002:a05:6214:4109:b0:91e:8cb1:b842 with SMTP id 6a1803df08f44-91f0416afc3mr18114026d6.49.1794357808926; Tue, 10 Nov 2026 16:43:28 -0800 (PST) X-Received: by 2002:a05:6214:4109:b0:91e:8cb1:b842 with SMTP id 6a1803df08f44-91f0416afc3mr18113656d6.49.1794357808309; Tue, 10 Nov 2026 16:43:28 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3ae092896d8sm7499011fa.32.2026.11.10.16.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 16:43:26 -0800 (PST) From: Dmitry Baryshkov Date: Wed, 11 Nov 2026 02:42:39 +0200 Subject: [PATCH v8 10/10] drm: writeback: drop the drmm writeback cleanup action X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261111-wb-drop-encoder-v8-10-62948ed87d13@oss.qualcomm.com> References: <20261111-wb-drop-encoder-v8-0-62948ed87d13@oss.qualcomm.com> In-Reply-To: <20261111-wb-drop-encoder-v8-0-62948ed87d13@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , John Harrison , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Louis Chauvet , Mihail Atanassov , Eric Anholt , Rob Clark , Brian Starkey Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, John Harrison X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2573; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=zFchQ2Tm6mpR1tJxfS8Ahms9paw4/2N65BwMaqhRGdY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBq87oXF36VJi20ypSJvvq0dMWU2n97wmd2BNuWU te4JTfo1TuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCavO6FwAKCRCLPIo+Aiko 1YW7B/9R958+trlT+7V42rGUF2nKBhOCM/QjmDp20lI1gchwVYH/MyskiElts+RvZ6vF57MfsF7 s2GB6G8nopGMASP96cG94rLE2QB9YR12H427s6ulj21GBbzS9PNLYekGjpLwHxOWbAzhL/Nz0nC fdMwFIwlEzLwQgKnWLX9aRAaRdObJ4UTPD2sE8lrGgn3CYnGMlL6HoIatUuOHEidXdfjcHmxgGv 0i3n6pgfNBPZwruEmZp8pZNdd9wq4OWN6vg2M/gJ0bf8JI/glC1xcvJJm+ljqyn/UTNqFw87cLD aRfnet3H/pMM9TfanUoMF8hT8roQsmUP1X97qRM4ryneWyKp X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTExMDAwMSBTYWx0ZWRfX3vZ2XhSVUC0p ILLJJRwM01Z/d2aSVZrpL+p6AqUj8rT/LPH1eMl2XbaXW69b6rFGE4wZUutv/eyCf6VXiLzLETh Qot9pkU0MZHD9Szx/x5xT68jeJd6GN2Zy2Tr4DAor6ihrUxGYvuetN7zWIggRok+SRaDAo0Trei 0VPfXjx1CErSbWRYKImg6RRu8xLa6gZ0mxvR4RR5vDQBLjBmTEM0wfwyi2HDeu91mrvTDrTRsK0 BSPEbDuwshhuGxaFnpLPaFlR+2gNKiauViqTagfvYr24YBXzjXABXiTELa4yLmj6suM06DtOKP+ jLDcaN2yAfN3gwlw0IEvrNhNHTUSQ6vMcWEXlnjR8yCiMjYuuruc0hX4cMzIEiLRU1UltmeSWGJ hGB8KC4Jdtd4TJSGRvbcsdV5rVhxrIWGJ4Fn9OvCc83TBTp8d48Lg/3bZ+3iMdEMDREzyfmrxpM T/0AOjBRB6psv7hbSJA== X-Authority-Analysis: v=2.4 cv=Ee1d0/mC c=1 sm=1 tr=0 ts=6af3ba32 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=V2sgnzSHAAAA:8 a=EUspDBNiAAAA:8 a=jfrLVL6Nzc9eZwqZ98kA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=Z31ocT7rh6aUJxSkT1EX:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMTExMDAwMSBTYWx0ZWRfX0P+PayRL/ISO CCImhAkQce6zYsMzd2cUtV3QxQXhj1I9CfMoOLIguryGLansBeE67MDr90ZKSXfd/eiVlT/Dh8b B5v4KEE1Bsq72m5fckwxR5l2JxvH3Zw= X-Proofpoint-GUID: Ig9_cN0xnogubBg0DLIGEIU6kv7myh2N X-Proofpoint-ORIG-GUID: Ig9_cN0xnogubBg0DLIGEIU6kv7myh2N X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-10_07,2026-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 adultscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611110001 drmm_connector_init() already registers drm_connector_cleanup() as a managed action, and that now cleans up the writeback state too. The extra action registered by drmm_writeback_connector_init() just does the same work a little earlier, leaving drm_connector_cleanup() nothing to do. Drop it. Reviewed-by: John Harrison Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 25 ++++--------------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c index 6ea3e55a1962..097d480d6187 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include #include @@ -308,14 +307,6 @@ void drm_writeback_connector_cleanup(struct drm_connector *connector) } } -static void drm_writeback_connector_cleanup_action(struct drm_device *dev, - void *data) -{ - struct drm_writeback_connector *wb_connector = data; - - drm_writeback_connector_cleanup(&wb_connector->base); -} - /** * drmm_writeback_connector_init - Initialize a writeback connector * @@ -326,7 +317,8 @@ static void drm_writeback_connector_cleanup_action(struct drm_device *dev, * @formats: Array of supported pixel formats for the writeback engine * @n_formats: Length of the formats array * - * This function initialize a writeback connector and register its cleanup. + * This function initializes a writeback connector. Cleanup is automatically + * handled with a call to drm_connector_cleanup() in a DRM-managed action. * * This function creates the writeback-connector-specific properties if they * have not been already created, initializes the connector as @@ -349,17 +341,8 @@ int drmm_writeback_connector_init(struct drm_device *dev, if (ret) return ret; - ret = __drm_writeback_connector_init(dev, wb_connector, enc, formats, - n_formats); - if (ret) - return ret; - - ret = drmm_add_action_or_reset(dev, drm_writeback_connector_cleanup_action, - wb_connector); - if (ret) - return ret; - - return 0; + return __drm_writeback_connector_init(dev, wb_connector, enc, formats, + n_formats); } EXPORT_SYMBOL(drmm_writeback_connector_init); -- 2.47.3