mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Todd Freed <toddfreed@meta.com>
To: <netfilter-devel@vger.kernel.org>, <toddfreed@meta.com>
Cc: "Pablo Neira Ayuso" <pablo@netfilter.org>,
	"Florian Westphal" <fw@strlen.de>, "Phil Sutter" <phil@nwl.cc>,
	"Nikolay Aleksandrov" <razor@blackwall.org>,
	"Ido Schimmel" <idosch@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Boris Pismenny" <borisp@nvidia.com>,
	"Sabrina Dubroca" <sd@queasysnail.net>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Daniel Zahka" <daniel.zahka@gmail.com>,
	"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
	"Björn Töpel" <bjorn@kernel.org>,
	coreteam@netfilter.org, bridge@lists.linux.dev,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH nf-next 0/2] netfilter: don't send decrypted skbs in clear text
Date: Tue, 10 Nov 2026 16:31:09 -0800	[thread overview]
Message-ID: <20261111003111.3826942-1-toddfreed@meta.com> (raw)

skb->decrypted marks a packet which the device decrypted on receive, or
must encrypt on transmit (tls device offload, psp). since this series in
net, the ip stack doesn't fragment such packets, and sends no icmp error
about a received one. an error about a locally originated one is only
sent if it is routed to a local address.

  https://lore.kernel.org/netdev/20261111001831.3710881-1-toddfreed@meta.com

netfilter does both itself: the bridge refragments the packets which
bridge conntrack reassembled, and the reject code builds its own tcp
resets, and for the netdev and bridge families its own icmp errors. this
series applies the same rules there.

the psp socket-less associations series for net-next, which follows
this one, makes forwarding and bridging packets which a psp device
decrypted an intended use.

this series doesn't depend on the net series or the net-next series,
and doesn't conflict with them.

testing: on netdevsim psp, with the net series applied, nft reject of
psp socket traffic, with tcp reset and icmpx, for ipv4 and ipv6:

 - in an inet input chain and a netdev ingress chain, of the decrypted
   packets a host receives. without patch 2, the tcp resets and the
   netdev icmp errors are sent in the clear. with patch 2, they are not
   sent.
 - in an inet output chain, of the packets a host sends. with and
   without this series, tcp resets and icmp errors are sent to the local
   socket.

patch 1 is build-tested only

Todd Freed (2):
  netfilter: bridge: don't refragment decrypted skbs
  netfilter: reject: don't reply to decrypted skbs

 net/bridge/netfilter/nf_conntrack_bridge.c |  6 +++++
 net/ipv4/netfilter/nf_reject_ipv4.c        | 26 ++++++++++++++++++++
 net/ipv6/netfilter.c                       |  6 +++++
 net/ipv6/netfilter/nf_reject_ipv6.c        | 28 ++++++++++++++++++++++
 4 files changed, 66 insertions(+)


base-commit: 734bef548a96e8774d6eef5dfa2026c6edc4e80b
-- 
2.53.0-Meta


             reply	other threads:[~2026-11-11  0:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  0:31 Todd Freed [this message]
2026-11-11  0:31 ` [PATCH nf-next v1 1/2] netfilter: bridge: don't refragment decrypted skbs Todd Freed
2026-11-11  0:31 ` [PATCH nf-next v1 2/2] netfilter: reject: don't reply to " Todd Freed
2026-11-11  0:36 ` [PATCH nf-next 0/2] netfilter: don't send decrypted skbs in clear text netdev-bot+sinfo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111003111.3826942-1-toddfreed@meta.com \
    --to=toddfreed@meta.com \
    --cc=bjorn@kernel.org \
    --cc=borisp@nvidia.com \
    --cc=bridge@lists.linux.dev \
    --cc=coreteam@netfilter.org \
    --cc=daniel.zahka@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    --cc=razor@blackwall.org \
    --cc=sd@queasysnail.net \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®