From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794358055; b=xsejZGII/ZXwIaf2cmNd761wpyJTxiXe400Mz+vn+NyJDFNh6HzeTXEWD0+P4sgl5DBY 5k9EZ9MsHU99fOBciPQ57tuRsplxRkVuBQKvTHsSEX+cDDYJQCy94UGR53IGljmRDrFwp F2hua3giugLvQrrL7fqqx/SGtq0h9LlzE+q5mfaPKxbKaBMRh0DoOt1dMNHi38Dh8dXcs 1VRs+6mFCQ9B26vw/C3ii7rVLBwbsqR2ynU4VhiZchmjpO21BNYqd3zqZguRNPnPynf2j ikYQmTvGdHsBUqGvmmj9NOlmE3VS1tNFFO0cq5/hTR+8r+y4tQas2g5D5L1GYfvk84Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794358055; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=POqYBqnjCDXSJMErzTHxYJeAhCAZrSEkM0W036mr0l0=; b=iPD2EsVQqci55+asIrG7wc0aHY9gXdaac8eZNCqZXTlzEazVNyWuJE5zCiqHmmcvN4gb RhpKJI5trsNKfGOrpaFPNbxb12xnX98PAXGqkQWqJvW+OZzTPr1Vy30Hz6kPrc0NCX7fh o2XcMxwjqocye9lV8m8tKG0JcJQ/SA6upgOgUORwH+l7BDNfyKgEbcaYo/RZEY8nQp5Gx +IVHsrGOwG3iDkC7GZ4eOMrsEk8ZXnSEIvRPV2jOrN7TBbqJI6ldby8Fupr5oSImAOxpX FQcHBvbsfS1Rf/RF7ui0e6W7dwJmlHXJ7+btj7gEBGMI+nCVPO7Q+VKN8Q9JVew1W8A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=WM6outSp; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A73E8606A320; Wed, 11 Nov 2026 00:47:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=WM6outSp Received: by smtp.kernel.org (Postfix) with ESMTPSA id C640F1F0089F; Wed, 11 Nov 2026 00:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794358055; bh=POqYBqnjCDXSJMErzTHxYJeAhCAZrSEkM0W036mr0l0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=WM6outSpn9srJTdlP80y9RSw+u+bI42TfmY8rOxOBIBFkH2+zZ9al2xsJVdmy2cKl MU0sSVdkBnD02MA/xy1279U/64ZTOQ4czNbbyMLWZZz6mk5iD1a00QVM2VmPwTOUbR ZF1xG1Tzzcmt2RmGYjSb18XhJrWbgrPDExiDFLorRcZx6DeOW5OE7FSJP6jYufwJXw IVx86JI0jYvZJZBpCqJH0hwDyURY2yqHYhIUVsQA87yxjwhfNWkXmBZK7kIu4Z5J5h pQygmpBw2U6W/sPza04838xo9erGSx0ACqeDpjESbKDNSIj/Lr51MqBwjaqYz16EIn Zbdp9el4fJtzw== Date: Wed, 11 Nov 2026 00:47:32 +0000 From: Yixun Lan To: Iker Pedrosa Cc: Alessio Belle , Luigi Santivetti , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , imagination@lists.freedesktop.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev Subject: Re: [PATCH RFC 1/2] riscv: dts: spacemit: k1: add PowerVR GPU device node Message-ID: <20261111004732-GKB2005@kernel.org> References: <20261015-orangepi-gpu-v1-0-03566a615660@gmail.com> <20261015-orangepi-gpu-v1-1-03566a615660@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20261015-orangepi-gpu-v1-1-03566a615660@gmail.com> Hi Iker, You could drop "RFC" prefix next time.. This patch generally looks good, while note that it has to wait for power domain to be kicked in On 20:56 Thu 15 Oct , Iker Pedrosa wrote: > Add device tree node for the Imagination Technologies PowerVR Rogue GPU ~~~~~~~~~~~~~~~~~~~~ drop, it's redundant and obvious > (BVNC 36.29.52.182 / BXE-2-32) found in the Spacemit K1 SoC. > > The GPU is located at address 0xcac00000 and uses: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drop, too much detail and not really worth mention in commit message > - CLK_GPU for core clock from APMU controller > - RESET_GPU for reset control from APMU controller > - K1_PMDOMAIN_GPU for power management from syscon_apmu provider > - IRQ 75 for interrupt handling > .. > Disabled by default; boards enable it individually. > As GPU is integrated within SoC, I'd rather see it enabled by default, so will not only one specific board befenit from this patch, besides, I see no reason why people should disable it by default? > Signed-off-by: Iker Pedrosa > --- > arch/riscv/boot/dts/spacemit/k1.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi > index 3fabfd34114b..82cade2f76fe 100644 > --- a/arch/riscv/boot/dts/spacemit/k1.dtsi > +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > #include "k1-pdma.h" > > @@ -1119,6 +1120,17 @@ multimedia-bus { > #size-cells = <2>; > dma-ranges = <0x0 0x00000000 0x0 0x00000000 0x0 0x80000000>, > <0x0 0x80000000 0x1 0x00000000 0x3 0x80000000>; > + > + gpu: gpu@cac00000 { > + compatible = "spacemit,k1-gpu", "img,img-bxe-2-32", "img,img-rogue"; > + reg = <0x0 0xcac00000 0x0 0x80000>; > + interrupts = <75>; > + clocks = <&syscon_apmu CLK_GPU>; > + clock-names = "core"; > + resets = <&syscon_apmu RESET_GPU>; > + power-domains = <&syscon_apmu K1_PMDOMAIN_GPU>; .. > + status = "disabled"; as if agree with above comment, drop this line and patch [2/2] > + }; > }; > > network-bus { > > -- > 2.56.0 > -- Yixun Lan (dlan)