From: Johan Dahlin <jdahlin@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
Alwyn Kik <alwyn@kik.pw>,
Fabio Baltieri <fabio.baltieri@gmail.com>,
Hamza Mahfooz <someguy@effective-light.com>,
Johan Dahlin <jdahlin@gmail.com>
Subject: [PATCH v2 4/7] hwmon: (nct6683) Enable fan control on ASRock BC-250
Date: Wed, 11 Nov 2026 09:28:35 +0100 [thread overview]
Message-ID: <20261111082838.1418051-5-jdahlin@gmail.com> (raw)
In-Reply-To: <20261111082838.1418051-1-jdahlin@gmail.com>
The ASRock BC-250 (customer ID 0x162b) has an NCT6686D with the same fan
control registers as the B850 Steel Legend WiFi, and manual fan control
was reported to work there.
Enable fan control for channels 0 to 7 on this board as well.
Suggested-by: Fabio Baltieri <fabio.baltieri@gmail.com>
Signed-off-by: Johan Dahlin <jdahlin@gmail.com>
---
Documentation/hwmon/nct6683.rst | 2 +-
drivers/hwmon/nct6683.c | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/hwmon/nct6683.rst b/Documentation/hwmon/nct6683.rst
index 026515c35243..8e5cd1d7dcd2 100644
--- a/Documentation/hwmon/nct6683.rst
+++ b/Documentation/hwmon/nct6683.rst
@@ -59,7 +59,7 @@ fan reported by fanN_input.
It is also supported on the ASRock B850 Steel Legend WiFi (NCT6686D,
customer ID 0x164a), where pwm1 to pwm6 control the fan headers reported
-by fan1 to fan6.
+by fan1 to fan6, and on the ASRock BC-250 (NCT6686D, customer ID 0x162b).
pwmN_enable selects the fan control mode:
diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index 29fbf438c04c..f656b84ee8ac 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -1540,7 +1540,8 @@ nct6683_setup_fans(struct nct6683_data *data)
}
}
- if (data->customer_id == NCT6683_CUSTOMER_ID_ASROCK8)
+ if (data->customer_id == NCT6683_CUSTOMER_ID_ASROCK8 ||
+ data->customer_id == NCT6683_CUSTOMER_ID_AMD)
data->have_fan_ctrl = data->have_pwm & GENMASK(7, 0);
}
--
2.53.0
next prev parent reply other threads:[~2026-11-11 8:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 8:28 [PATCH v2 0/7] hwmon: (nct6683) Fan control and sensor names for ASRock NCT6686D boards Johan Dahlin
2026-11-11 8:28 ` [PATCH v2 1/7] hwmon: (nct6683) Add customer ID for ASRock B850 Steel Legend WiFi Johan Dahlin
2026-11-11 8:28 ` [PATCH v2 2/7] hwmon: (nct6683) Restore automatic fan control on driver removal Johan Dahlin
2026-11-11 8:28 ` [PATCH v2 3/7] hwmon: (nct6683) Enable fan control on ASRock B850 Steel Legend WiFi Johan Dahlin
2026-11-11 8:28 ` Johan Dahlin [this message]
2026-11-11 8:28 ` [PATCH v2 5/7] hwmon: (nct6683) Name the sensors of the " Johan Dahlin
2026-11-11 8:28 ` [PATCH v2 6/7] hwmon: (nct6683) Name the fan headers " Johan Dahlin
2026-11-11 8:28 ` [PATCH v2 7/7] hwmon: (nct6683) Scale the +5V and +12V inputs " Johan Dahlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111082838.1418051-5-jdahlin@gmail.com \
--to=jdahlin@gmail.com \
--cc=alwyn@kik.pw \
--cc=fabio.baltieri@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=someguy@effective-light.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®