From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.36 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794387291; b=BDEON3XN2M6XTE1OSYvT9bxGOoa6mAC6ZvGCXVtD3r1N4HpazUhnH9a4eRP7m/mS2pVe 7GZXH6GI+OEJCydtN3055TXA2ky+NSR0Xb7Ok90vjJ9wnsx1ZvRDutvBggeEpj7qHg1eB u3pxueAKQJhKTpHKJukbym6b8yt7Z5J1mwZKsuCWnB0ig4pn5RYTvXvep9wQ9zbsyYyjD ABw1m61wyPRRH7e7Ib63q174ATYQDQVdjfwwrz54xcwGGPYevFYAUjJLvA6OTXAOB70AC ifC2JTlqnssP+8Ox13gXMEU3A5kEJl51J6+QI+AovARlIGjVzOnyN+7ie2KLeZLpFHg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794387291; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=LLwOkpWku+LuRzU0j1n/3ISg+beECDACZb9CL8tnJJE=; b=GA7uVVdVZ1OvfOG9gzD4pDk/X0C90WobiiLDDYFwmO58zrUIBUFRxG5PAc1Of398t1X7 vMdQ6F/CBDyqitEZ30cXgFrDoS642m9icTZw4QZOaFTpDQTWaSqcEks2kQm0wYrxF4CEV hIulFeUUjOjQB/2QBf7D1CtKFf2BB3vI8HHVGDSX1J+ajOD9g+aQAka9w2lEVZig1FbOV RPWJoOtfJD55yi9czTqOxmSvfN1ycQYnKZyWE5wa/eziRA3XmAys8wf+qZ4N49GHvs1+I Xhrd+JeMXWNiIoLXDWxh59NoWPhSE68WaKzW1IToL2Ui5jCjzOdFe7fo60nzq58yz9g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=ZcpTYDg1; arc=none smtp.remote-ip=91.218.175.36 Received: from mta0.migadu.com (out-36.mta0.migadu.com [91.218.175.36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48373606A332 for ; Wed, 11 Nov 2026 08:54:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 48373606A332 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=ZcpTYDg1 X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=VWN8eFztGEEX6q/yBgqDy1q04Jl/aSZsCUJ97YS64+c=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794387289; v=1; x=1794992089; b=ZcpTYDg1JpJLHVnoN7sNv58aKANM3gl9EuBQcP83fO1iL6EPYTSLjm1mp5jHvoWSp1sWh03s VRPUp3PNZ91AqkJrRTEaYO7ABev4cldTqBzl/kFKN9d+Ex2kP0ZYYFkg0PEJec2oB7N44plnrH5 zd27Wb+X/ehAFPekq8xGjOBg= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 3e744c096daf5982; Wed, 11 Nov 2026 08:54:49 +0000 X-Mizu-Trace-ID: 3e744c096daf5982 X-Migadu-Flow: FLOW_OUT From: Fuad Tabba To: Paolo Bonzini , Sean Christopherson Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Corbet , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Huacai Chen , linux-mips@vger.kernel.org, Will Deacon , Fuad Tabba Subject: [PATCH 2/7] Documentation: KVM: Fix lock names and a lock type in locking.rst Date: Wed, 11 Nov 2026 08:54:43 +0000 Message-ID: <20261111085448.1130701-3-fuad.tabba@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261111085448.1130701-1-fuad.tabba@linux.dev> References: <20261111085448.1130701-1-fuad.tabba@linux.dev> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The x86 lock ordering refers to kvm->arch.mmu_lock instead of kvm->mmu_lock. The entry for wakeup_vcpus_on_cpu_lock gives its type as spinlock_t instead of raw_spinlock_t, and its comment uses the list and lock names from before commit 12a8eee5686ef ("KVM: Move x86 VMX's posted interrupt list_head to vcpu_vmx"). Fix all three. Signed-off-by: Fuad Tabba --- Documentation/virt/kvm/locking.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/virt/kvm/locking.rst b/Documentation/virt/kvm/locking.rst index 662231e958a07..df0db74630976 100644 --- a/Documentation/virt/kvm/locking.rst +++ b/Documentation/virt/kvm/locking.rst @@ -54,9 +54,9 @@ On x86: - vcpu->mutex is taken outside kvm->arch.hyperv.hv_lock and kvm->arch.xen.xen_lock -- kvm->arch.mmu_lock is an rwlock; critical sections for +- kvm->mmu_lock is an rwlock; critical sections for kvm->arch.tdp_mmu_pages_lock and kvm->arch.mmu_unsync_pages_lock must - also take kvm->arch.mmu_lock + also take kvm->mmu_lock Everything else is a leaf: no other lock is taken inside the critical sections. @@ -297,13 +297,13 @@ time it will be set using the Dirty tracking mechanism described above. ``wakeup_vcpus_on_cpu_lock`` ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -:Type: spinlock_t +:Type: raw_spinlock_t :Arch: x86 :Protects: wakeup_vcpus_on_cpu :Comment: This is a per-CPU lock and it is used for VT-d posted-interrupts. When VT-d posted-interrupts are supported and the VM has assigned - devices, we put the blocked vCPU on the list blocked_vcpu_on_cpu - protected by blocked_vcpu_on_cpu_lock. When VT-d hardware issues + devices, we put the blocked vCPU on the list wakeup_vcpus_on_cpu + protected by wakeup_vcpus_on_cpu_lock. When VT-d hardware issues wakeup notification event since external interrupts from the assigned devices happens, we will find the vCPU on the list to wakeup. -- 2.47.3