mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josef Schlehofer <pepe.schlehofer@gmail.com>
To: Ignat Korchagin <ignat@linux.win>, Mikulas Patocka <mpatocka@redhat.com>
Cc: Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Benjamin Marzinski <bmarzins@redhat.com>,
	dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
	Milan Broz <gmazyland@gmail.com>
Subject: Re: [PATCH] dm-crypt: defer async write submission to write thread
Date: Wed, 11 Nov 2026 10:47:56 +0100	[thread overview]
Message-ID: <20261111094756.20997-1-pepe.schlehofer@gmail.com> (raw)
In-Reply-To: <CAOs+rJWmmUbYqU34Yb4qJvJsZ92=AztNwNsqX+xD8WaH8tVz-w@mail.gmail.com>

On Mon, Nov 9, 2026 at 8:51 PM Ignat Korchagin <ignat@linux.win> wrote:
> At the very least I think it may be an unexpected/undesirable setup
> for the user: they enable "no_write_workqueue" expecting a fully
> inline setup, but still get io offloaded. Perhaps in such cases we can
> do a pr_warn_once() to let the user know their setup is impossible?

Now that Damien has confirmed async is fine for zoned devices, I would
like to add this warning as a follow-up patch on top of dm-7.4.

Would a pr_warn_once() in kcryptd_crypt_write_io_submit() be acceptable,
printed when an async completion is sent to the write thread despite
no_write_workqueue? The other option is a warning at table load when
no_write_workqueue is set and the cipher is async. Zoned devices would
not get the warning in either case.

Mikulas, which one would you prefer?

Thanks,
Josef

      reply	other threads:[~2026-11-11  9:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  7:27 Josef Schlehofer
2026-11-09  6:08 ` Damien Le Moal
2026-11-09 12:18   ` Mikulas Patocka
2026-11-10  4:29     ` Josef Schlehofer
2026-11-11  8:56       ` Damien Le Moal
2026-11-09 20:51 ` Ignat Korchagin
2026-11-11  9:47   ` Josef Schlehofer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111094756.20997-1-pepe.schlehofer@gmail.com \
    --to=pepe.schlehofer@gmail.com \
    --cc=agk@redhat.com \
    --cc=bmarzins@redhat.com \
    --cc=dlemoal@kernel.org \
    --cc=dm-devel@lists.linux.dev \
    --cc=gmazyland@gmail.com \
    --cc=ignat@linux.win \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=snitzer@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®