mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Timo Joannin <timo.joannin@gmail.com>
To: trintaeoitogc@gmail.com
Cc: axboe@kernel.dk, bvanassche@acm.org, josef@toxicpanda.com,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	nbd@other.debian.org,
	syzbot+d7d72f3d467710442af0@syzkaller.appspotmail.com
Subject: Re: [PATCH] nbd: fix circular lock dependency
Date: Wed, 11 Nov 2026 12:29:21 +0100	[thread overview]
Message-ID: <20261111112921.306969-1-timo.joannin@gmail.com> (raw)
In-Reply-To: <20261111101919.215767-1-trintaeoitogc@gmail.com>

On Wed, Nov 11, 2026 at 0:40 AM, Bart Van Assche <bvanassche@acm.org> wrote:
> Moving nbd_get_socket() makes this patch much larger than necessary,
> which makes reviewing and backporting it harder. Adding a single
> nbd_reclassify_socket(sock) call in nbd_genl_reconnect_sock_cb() right
> after the nbd_get_socket() call is sufficient. 

Hi Guilherme and Bart,

Thanks for working on this! I'm currently fixing a possible deadlock
in wg_ratelimiter_uninit 
(Reported-by: syzbot+72fceb8393e04ce876d9@syzkaller.appspotmail.com)
involving cpu_hotplug_lock and slab_mutex.

My one syzbot test failed because of this lockdep
false positive that this patch addresses. I applied Bart's suggested 1-line
fix locally, and will see if it resolves the false positive.
I will be submitting my cpu_hotplug_lock fix separately.
I am looking forward to see your v2!

Thanks,
Timo Joannin

  reply	other threads:[~2026-11-11 11:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 21:57 Guilherme Giacomo Simoes
2026-11-11  0:40 ` Bart Van Assche
2026-11-11 10:19   ` Guilherme Giacomo Simoes
2026-11-11 11:29     ` Timo Joannin [this message]
2026-11-11 11:38     ` Guilherme Giacomo Simoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111112921.306969-1-timo.joannin@gmail.com \
    --to=timo.joannin@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbd@other.debian.org \
    --cc=syzbot+d7d72f3d467710442af0@syzkaller.appspotmail.com \
    --cc=trintaeoitogc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®