mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Slark Xiao <slark_xiao@163.com>
To: mani@kernel.org, jeff.hugo@oss.qualcomm.com, bbhatt@codeaurora.org
Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, Slark Xiao <slark_xiao@163.com>,
	stable@vger.kernel.org
Subject: [PATCH] bus: mhi: host: Only expose controller sysfs attributes on the controller device
Date: Wed, 11 Nov 2026 19:56:58 +0800	[thread overview]
Message-ID: <20261111115659.11943-1-slark_xiao@163.com> (raw)

The serial_number, oem_pk_hash and soc_reset attributes are registered
through mhi_bus_type.dev_groups, so the driver core creates them for
every device on the MHI bus.  MHI client devices (the per-channel
devices such as mhi0_DUN or mhi0_MBIM) are also MHI bus devices, so
each of them ends up with its own copies of these files even though
they all operate on the same mhi_controller:

  $ ls /sys/bus/mhi/devices/mhi0_DUN/
  driver  oem_pk_hash  power  serial_number  soc_reset  subsystem  uevent

This is wrong for several reasons:

  - The attributes describe the controller, not the channel.  Their
    callbacks all dereference mhi_dev->mhi_cntrl and read BHI registers
    or issue a controller-wide SoC reset, so writing soc_reset through
    mhi0_DUN resets the whole device while looking like a per-channel
    operation.
  - oem_pk_hash reports failures with dev_err(dev, ...), so a single
    failing controller produces one log line per registered channel
    device instead of one.
  - Userspace has no way to tell which copy is authoritative.

Move the attributes off the bus and attach them to the controller
device only.  mhi_register_controller() now installs the group via
mhi_dev->dev.groups before device_add(), while the channel devices
created by mhi_create_devices() are left untouched.  No functional
change for the controller device; the files stay at the paths listed
in Documentation/ABI/stable/sysfs-bus-mhi.

Note that trigger_edl was already handled this way, through an explicit
sysfs_create_file() on the controller kobject, which is why it never
appeared on the channel devices.

Fixes: 21cb9b18edea ("bus: mhi: core: Introduce sysfs entries for MHI")
Cc: stable@vger.kernel.org
Signed-off-by: Slark Xiao <slark_xiao@163.com>
---
 drivers/bus/mhi/host/init.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c
index fd3050889412..b4b254d1c6b9 100644
--- a/drivers/bus/mhi/host/init.c
+++ b/drivers/bus/mhi/host/init.c
@@ -150,13 +150,21 @@ static ssize_t trigger_edl_store(struct device *dev,
 }
 static DEVICE_ATTR_WO(trigger_edl);
 
-static struct attribute *mhi_dev_attrs[] = {
+static struct attribute *mhi_cntrl_dev_attrs[] = {
 	&dev_attr_serial_number.attr,
 	&dev_attr_oem_pk_hash.attr,
 	&dev_attr_soc_reset.attr,
 	NULL,
 };
-ATTRIBUTE_GROUPS(mhi_dev);
+
+static const struct attribute_group mhi_cntrl_dev_group = {
+	.attrs = mhi_cntrl_dev_attrs,
+};
+
+static const struct attribute_group *mhi_cntrl_dev_groups[] = {
+	&mhi_cntrl_dev_group,
+	NULL,
+};
 
 /* MHI protocol requires the transfer ring to be aligned with ring length */
 static int mhi_alloc_aligned_ring(struct mhi_controller *mhi_cntrl,
@@ -1019,6 +1027,8 @@ int mhi_register_controller(struct mhi_controller *mhi_cntrl,
 	dev_set_name(&mhi_dev->dev, "mhi%d", mhi_cntrl->index);
 	mhi_dev->name = dev_name(&mhi_dev->dev);
 
+	mhi_dev->dev.groups = mhi_cntrl_dev_groups;
+
 	/* Init wakeup source */
 	device_init_wakeup(&mhi_dev->dev, true);
 
@@ -1455,7 +1465,6 @@ const struct bus_type mhi_bus_type = {
 	.uevent = mhi_uevent,
 	.probe = mhi_probe,
 	.remove = mhi_remove,
-	.dev_groups = mhi_dev_groups,
 };
 
 static int __init mhi_init(void)
-- 
2.53.0


             reply	other threads:[~2026-11-11 11:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 11:56 Slark Xiao [this message]
2026-11-13 18:42 ` Jeff Hugo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111115659.11943-1-slark_xiao@163.com \
    --to=slark_xiao@163.com \
    --cc=bbhatt@codeaurora.org \
    --cc=jeff.hugo@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mhi@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®