From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.136.64.225 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794398985; b=Ndz6xLMGaOzwtgQetgA2HfKk89FsLx/d2hgr9qeoQgr3vU/ymdOAcd3+sLaFX9MD5QLv hcTpjROWVTJ5Svfu5pE1npZrL8ZSRTYgTAmXcGDXWdBeRLlJc4dr/12krE4ioXe1DN7xM dE2NHmC6ATJuKAb7u7UDxQIEmHicDtfDKGVOHbl53ODT6Jh6fTy2eoRpu3S00e+0iNxFF 1/PyRE72xS8Io+UOrZGu8Jf3124H/6j48w5XM5wfvN7TZ5PpsCE3X2avAwZBbKWIFB342 Ysk3IcEfZNHnH8ABFyL7OpaFwlU0kwhyhalqrBl7IiTmmFd+roHXiBddsSyZBeGjTWQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794398985; h=DMARC-Filter:Received:DKIM-Signature:From:To:Cc:Subject:Date: Message-Id:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Flowmailer-Platform:Feedback-ID; bh=1rurHZ0wTY/YPriBMTBu68etXAQxqOR8Khf34iiOSFw=; b=FbqlXSY3aVRyPqGbAz2uBfs4pOxujteq5+qOWufIljb5EPo1T9PwbdeKIAwFvKKW1cA1 Eqks0qdJ25jjdsbLaEa/VgEpoffbv0bT6Kf2OW2YmARADGGXUZuFoeqVk6BhGzuOSlWQG DMyV2tufiH1kxagGPrb/VbCzScN82Z3QlszyhggZ1pof4iGuDuW86rsrEd3gGFgNDRPmF h94HFPZ/ArH6yu+RLvR3AVlrGyKBnB41TZbuXdXg5inw+ahByT+pu/WPkfT4tR6U+IXV3 wlOSH/LIYm8yQSmLgFWXba0ATDwT5yoSIqMdpM88SluijtgtH/TMoacPESgh0qkcnCA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=siemens.com; spf=pass smtp.mailfrom=rts-flowmailer.siemens.com; dkim=pass header.d=siemens.com header.i=michael.haener@siemens.com header.a=rsa-sha256 header.s=fm1 header.b=XWTRJ1wb; arc=none smtp.remote-ip=185.136.64.225 Received: from mta-64-225.siemens.flowmailer.net (mta-64-225.siemens.flowmailer.net [185.136.64.225]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD4DB606A330 for ; Wed, 11 Nov 2026 12:09:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BD4DB606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=siemens.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rts-flowmailer.siemens.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=siemens.com header.i=michael.haener@siemens.com header.a=rsa-sha256 header.s=fm1 header.b=XWTRJ1wb Received: by mta-64-225.siemens.flowmailer.net with ESMTPSA id 20261111120936e8c1a6209d000207de for ; Wed, 11 Nov 2026 13:09:36 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=michael.haener@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=1rurHZ0wTY/YPriBMTBu68etXAQxqOR8Khf34iiOSFw=; b=XWTRJ1wb0cn2erbCjGGZ13Dz2oa7tOsIi0yVTjFdvWet4i9AdEd9SDUDb0OWE3WweTVvKu X2BQ3wLX+TjebA61jJEUgkX2Hrkv0f+K/SlJSN/E0K6vhDMyFISkgqDRQmz/7wEwF0HlgAx8 Mxm16yVuF9cncbxe9lwd3zRnGs3HEvQLX9ScMj2TLGDSj7yUBtsNKZRowNtBaQ9OCpQ8vvD8 COJcf04RO0Og+k2vtfY9T1tZxu9opsCi1bh+vsJKYGAFhl8qs1I9b60xDUu/xaeW2td0Flko VER9nLq/bVUwuzJQghBbqvxpmRrluwqYM8OeOJVJu35/6uPTf4ompN3w==; From: Michael Haener To: Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Avri Altman , Luke Wang , Michael Haener , stable@vger.kernel.org Subject: [PATCH 1/2] mmc: add ISSI IS22TF128G to fixed secure erase time quirk Date: Wed, 11 Nov 2026 13:07:58 +0100 Message-Id: <20261111120759.100830-2-michael.haener@siemens.com> In-Reply-To: <20261111120759.100830-1-michael.haener@siemens.com> References: <20261111120759.100830-1-michael.haener@siemens.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-664519:519-21489:flowmailer The ISSI IS22TF128G eMMC (CID manfid 0x9d, oemid 0x0101, name "IS128G") reports SECURE_REMOVAL_TYPE 0x01 (overwrite, then erase) and has a large per-command overhead for secure erase. Secure erasing a 33.5GiB partition with blkdiscard -s on an NXP i.MX8 (sdhci-esdhc-imx, HS400ES) is split into max_discard sized requests of about 3.5MiB, i.e. roughly 10000 secure erase commands, which takes 5-7 hours once ~27GiB of the partition have been written. Since the per-command overhead dominates, apply MMC_QUIRK_FIXED_SECURE_ERASE_TRIM_TIME so secure erase requests are no longer limited by max_discard. With the quirk, secure erasing the same partition with ~27GiB written takes about 6 minutes. Card parameters: ERASE_GROUP_DEF 0x01, HC_ERASE_GRP_SIZE 0x01 (512KiB), ERASE_TIMEOUT_MULT 0x12, SEC_ERASE_MULT 0x64, SEC_TRIM_MULT 0x64. Cc: stable@vger.kernel.org Signed-off-by: Michael Haener --- drivers/mmc/core/card.h | 1 + drivers/mmc/core/quirks.h | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h index a7c364d0030a..dc99242a0af2 100644 --- a/drivers/mmc/core/card.h +++ b/drivers/mmc/core/card.h @@ -93,6 +93,7 @@ struct mmc_fixup { #define CID_MANFID_SWISSBIT 0x5D #define CID_MANFID_KINGSTON 0x70 #define CID_MANFID_HYNIX 0x90 +#define CID_MANFID_ISSI 0x9D #define CID_MANFID_KINGSTON_SD 0x9F #define CID_MANFID_NUMONYX 0xFE diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index 98cb680e3ace..be29be8ec413 100644 --- a/drivers/mmc/core/quirks.h +++ b/drivers/mmc/core/quirks.h @@ -162,6 +162,15 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = { MMC_FIXUP("IB2932", CID_MANFID_KINGSTON, 0x0100, add_quirk_mmc, MMC_QUIRK_FIXED_SECURE_ERASE_TRIM_TIME), + /* + * ISSI IS22TF128G has a large per-command overhead for secure erase + * once data has been written: splitting a 33GB secure erase into + * max_discard sized chunks takes hours, while a single command over + * the same range finishes in about 10 seconds. + */ + MMC_FIXUP("IS128G", CID_MANFID_ISSI, CID_OEMID_ANY, add_quirk_mmc, + MMC_QUIRK_FIXED_SECURE_ERASE_TRIM_TIME), + END_FIXUP }; -- 2.56.0