From: Atanas Filipov <atanas.filipov@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: linux-media@vger.kernel.org, bod@kernel.org, mchehab@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andersson@kernel.org, konradybcio@kernel.org,
loic.poulain@linaro.org, gjorgji.rosikopulos@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, atanas.filipov@oss.qualcomm.com
Subject: Re: [PATCH v8 5/8] arm64: dts: qcom: sm8250: Add JPEG encoder node
Date: Wed, 11 Nov 2026 17:40:18 +0200 [thread overview]
Message-ID: <20261111154018.654669-1-atanas.filipov@oss.qualcomm.com> (raw)
In-Reply-To: <3ti6ntq6ztczilnwv66ak7ohl63mgw4tv4mdbsiy2hrkqqqjow@rmkwrasthd5e>
On Wed, Nov 11, 2026 at 03:14:54PM +0200, Dmitry Baryshkov wrote:
> > + jpeg_enc: jpeg-encoder@ac53000 {
> > + compatible = "qcom,sm8250-jpeg-enc";
> > + status = "disabled";
>
> Drop, there is no point in keeping it disabled. (And the status is
> expected to be the last property anyway).
Ok, I will enable it by default in the next version.
> > + power-domains = <&camcc TITAN_TOP_GDSC>,
>
> TITAN_TOP_GDSC is a child of MMCX. You shouldn't need to declare mmcx
> separately. Instead cast the votes on TITAN and they will propagate to
> the MMCX rail.
Ok, I will drop mmcx and vote through TITAN_TOP_GDSC.
> > + interconnects = <&mmss_noc MASTER_CAMNOC_SF 0 &mc_virt SLAVE_EBI_CH0 0>;
>
> Use tags instead of 0. I guess it's QCOM_ICC_TAG_ALWAYS.
Ok, I will use QCOM_ICC_TAG_ALWAYS.
--
Best regards,
Atanas
next prev parent reply other threads:[~2026-11-11 15:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 16:39 [PATCH v8 0/8] Add Qualcomm JPEG V4L2 encoder for SM8250 and SC7280 Atanas Filipov
2026-11-10 16:39 ` [PATCH v8 1/8] dt-bindings: media: qcom: Add JPEG encoder binding Atanas Filipov
2026-11-12 8:41 ` Loic Poulain
2026-11-12 10:02 ` Krzysztof Kozlowski
2026-11-10 16:39 ` [PATCH v8 2/8] media: jpeg: Add JPEG baseline and JFIF APP0 constants Atanas Filipov
2026-11-10 16:39 ` [PATCH v8 3/8] media: v4l2-jpeg: Add a baseline JPEG header writer Atanas Filipov
2026-11-11 13:30 ` Dmitry Baryshkov
2026-11-11 15:40 ` Atanas Filipov
2026-11-10 16:39 ` [PATCH v8 4/8] media: qcom: jpeg: Add Qualcomm JPEG V4L2 encoder Atanas Filipov
2026-11-11 9:02 ` kernel test robot
2026-11-11 11:55 ` kernel test robot
2026-11-10 16:39 ` [PATCH v8 5/8] arm64: dts: qcom: sm8250: Add JPEG encoder node Atanas Filipov
2026-11-11 13:14 ` Dmitry Baryshkov
2026-11-11 15:40 ` Atanas Filipov [this message]
2026-11-10 16:39 ` [PATCH v8 6/8] arm64: dts: qcom: qrb5165-rb5: Enable JPEG encoder Atanas Filipov
2026-11-10 16:39 ` [PATCH v8 7/8] arm64: dts: qcom: kodiak: Add JPEG encoder node Atanas Filipov
2026-11-11 13:17 ` Dmitry Baryshkov
2026-11-11 15:40 ` Atanas Filipov
2026-11-10 16:39 ` [PATCH v8 8/8] arm64: dts: qcom: qcs6490-rb3gen2: Enable JPEG encoder Atanas Filipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111154018.654669-1-atanas.filipov@oss.qualcomm.com \
--to=atanas.filipov@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gjorgji.rosikopulos@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®