mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Bridges <icb@fastmail.org>
To: jan.koester@tuxist.de
Cc: linkinjeon@kernel.org, senozhatsky@chromium.org, tom@talpey.com,
	chenxiaosong@chenxiaosong.com, brauner@kernel.org,
	linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, Ian Bridges <icb@fastmail.org>
Subject: Re: [RFC PATCH 1/6] ksmbd: don't ignore the owner and group of a descriptor without a DACL
Date: Wed, 11 Nov 2026 10:00:29 -0600	[thread overview]
Message-ID: <20261111160029.4127378-1-icb@fastmail.org> (raw)
In-Reply-To: <86878858c5973b660bd04a65@groupi3>

Hi Jan,

On Tue, Nov 10, 2026 at 09:02:27AM +0000, Jan Koester wrote:
> +	/* parse_sec_desc() rewrites type */
> +	dacl = le16_to_cpu(pntsd->type) & DACL_PRESENT;

Shouldn't the parts to change come from the SecurityInformation of the
request rather than from DACL_PRESENT? As far as I can see, the Linux
cifs client's chown can send OWNER_SECURITY_INFORMATION alone with a
descriptor that still carries the DACL. It does so when no ACE names
the old owner. Would this patch then parse that DACL again, rebuild the
POSIX ACL from it and replace the stored descriptor, though the client
only asked to change the owner? And in the reverse case, would a
request for the DACL alone still change the owner when the descriptor
carries one?

Thanks,
Ian

  reply	other threads:[~2026-11-11 16:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  9:02 Jan Koester
2026-11-11 16:00 ` Ian Bridges [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-10-28  6:19 [RFC PATCH 0/6] ksmbd: Windows SIDs for user and group ids Jan Koester
2026-10-28  6:19 ` [RFC PATCH 1/6] ksmbd: don't ignore the owner and group of a descriptor without a DACL Jan Koester

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111160029.4127378-1-icb@fastmail.org \
    --to=icb@fastmail.org \
    --cc=brauner@kernel.org \
    --cc=chenxiaosong@chenxiaosong.com \
    --cc=jan.koester@tuxist.de \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®