From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=103.168.172.146 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794413438; b=toJ/sEtJ7ykqy1nby7nlRc6coM1FMrfslBfu9fliwgt2CdrMtrTm2KPPmNk0WeSEkm2E IZ0o+k37HLkgk5lLWpGScVdMi1gwRgje69cfFAZBn9noHaBRYcYeYXqhXbzrBVIDRuhiV m/BqQGswbjy0QC0xJbicvmUot+WkdW6lhjt4DuqmxyM8E9Epi/Q9FCyxErz6wxbSvRbVx /8jzUe8mzE4wmzgjYe7T9fjTtRvT2BM+0eeXRc9CFe8NlXes00U5qrbzxGhrsPJQpL00i LeKx46m7XX+SKYeS6j7puZkO4m6gUSSecYM7hnJbn60cQD/HQj7CaRLFQOQE/9B5qIQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794413438; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding; bh=Uq7SAWfC40SPdH0tndk0XJhDRBsFA05lXparVsZ7Ty8=; b=LlZUfZ6Mbp7YVo1W2fuPfa+AElxOlgsOSa3DiTea5w5vlQnv1kkG+0vjG5jCx5xiPTSX NO/YKrGSeiK8IVtOGHsixC7X+OMtudS4TdO7rDT1iVwvvsARHoivim+twgPsgbXVPmOpW Jn36dbiThhEd5eD31zTNdsAMaJ5RziEk4yr2r0njM9n5JY7baO6nkqqtgWlfksLQy++HG 9fJSdoXl3i59W5UFzvcAHK/Ghs7hlcmicPLFydukgUrB5wZaJ9AZuGV01JNUF+tz77VCV ubcN1Y81uskK70dYB6krz1DHaq6SsVamtFaKLUL9ixkTvOSugumE0IsLqWoMEFPiuOA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=fastmail.org; spf=pass smtp.mailfrom=fastmail.org; dkim=pass header.d=fastmail.org header.i=@fastmail.org header.a=rsa-sha256 header.s=fm3 header.b=LWB9BK1a; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=EkblR73Q; arc=none smtp.remote-ip=103.168.172.146 Received: from fout-a3-smtp.messagingengine.com (fout-a3-smtp.messagingengine.com [103.168.172.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B3C8606A321 for ; Wed, 11 Nov 2026 16:10:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5B3C8606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=fastmail.org header.i=@fastmail.org header.a=rsa-sha256 header.s=fm3 header.b=LWB9BK1a; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=EkblR73Q Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id 5617DEC067A for ; Wed, 11 Nov 2026 11:10:37 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Wed, 11 Nov 2026 11:10:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1794413436; x= 1794499836; bh=Uq7SAWfC40SPdH0tndk0XJhDRBsFA05lXparVsZ7Ty8=; b=L WB9BK1ax4wfjtsvmqbcZKT1CC0g3HvYjfAYPI4k54Cn4t4pYbKXzC6QQe6Zt/9tZ ogVQGE75SesYgwFNVetfhcK020oaN/qE/G34HdbTP7i3HgF/mJX36x88Wp0VINVX 7U7BwBgg6+tfJQXaYk5NRzGTgdKFQiLu6/JPPhNGNByHh/idqw9qHEsYW6gzMSRm NBiKPOmsqBJ4mor+vpZfZ3dq4RNbJ/n8+GSOleO8JF7Pb+cOcprIzE6ufNO8N2MH 6K7sonqxYn9i0RpGVLI7Og88FeYZ+wiepbF1Q5W460JV0jIxlMIp7elUdxSHyFGu cYqjy88GA0P3hSOjhCPRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1794413436; x=1794499836; bh=U q7SAWfC40SPdH0tndk0XJhDRBsFA05lXparVsZ7Ty8=; b=EkblR73QhVsYDKCaU 8GWvHlgtVtJMV3wNQnYQYcrJMMjGbIbS8h+eAyKO2afAsqkycbiYf/PeU56Y1lxG coepsyyKb/rdjWazi4LL+uqfHiHQd/BPq1ESjFCnOIUF3mRg1CEXJvFzOpR/x6Kl fDLkuRde65nDAqg+/xe/ZiFyfilwylmEk1wxcGCH+NtVaDd2wPuHC08cg8i+xhpy 6Zmf/+9pShOkstC6wppbOaXq0IzOugQnBt/WSuw/ZLJtu7eXcNTHxmYMXjOXwUTZ T9azUDLB/sWSm7iG4m94WMfGwCZ4aifncDtv9/qh8hW+VnqM0ORUboV8aPoOfYU6 QDj7w== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=fastmail.org a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794413436; d=fastmail.org; mf=PGljYkBmYXN0bWFpbC5vcmc+; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm3:rsa-sha256:dXK7FJaVBJEDldisoeiRxsZzsdmAlnZIv8vvjkP0bnrelSy fIAos0E0KYrdWIJSf69iUNrVAhQSyNsrnp3360/78qDb5YQhyQxX69ZDipRa7dSw 3kbHWsFGSCc5JrQvMIpDhNxcCBUWpl/P3GeILOG/ilFdM7ZJnUDQNmLubCzRrQ97 ndchAESFgrt+iRPrag3TsOduLlZZ48Xz9VL7rhvGC4J/BXeYmTR3fB/tN+gcfM4J JnghgtqK9nAywTXs+Ryx0E1r1GVpGJD45qP6dtm7tzdM/opt6o2Vlw7CYVv/O+QR OXvqgxrLX+QZLTYsmlQNBFKzLzZZ4Z7mcIKVcmg==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=11; hn=cc,content-transfer-encoding,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:mJgToMQj3UVdzf4WOyKY91r/yHCkIH8/h+TooU7quKg=:53TFk04Yc9rvZUNv7nt8CxhI7DWNLllMy0Brtg/yPus=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFh6uuZJisOPSkiBRmlP3c7Xf1zTKcKKUCvf24GxmCEwWyBzY/I1K82tFLPeGmxxT xG+pB+I0tJWavgH01uW9qnC/zq6yGMVBAKKqZCFocpPU3BJhRma7ck41UtZp2SpFJnOElW LRH8pqqlF3clj8ccod5i2sl3WTtPamT1wZaY0HKdNoiz2d6x5vfPAIn7P9NtQpsp9n0IgN aJN/Ow99o15SMzPKMjqkIzNyAya+QLRQVAEfXBLM1ij9IohlJMssGjwTDSfK0rVlBEuEfB gL2Hbaen1QpckbBbRByTwoe6S3ut3LNKY8FkEcjABo0YNpA+IK4EaAEWQvScJDe5k1PbIo aI0yZslM5jk4kPxwts6+o8i82eSOjS0No+cR7ufrb+54XLUznb4YCOGCcyne50jkzF6xC7 KjfNXrxdYS3McLMAOp0FAPPmirZhhvTjfuuasA2xvtJUauDdiYN0ErhqF77rBOPWEa3g5l jQnBEU8beTHYzhEJDRwjjG+pnDtiGBoY+k98rMUGhlEqR2ki/smKgXDK20RIrZ8D8TSmlk jJ/buQLGnxKAsmsPRzHiGZOZ8orqFPM1baPGnv2+4ReeSt8k3blZCL/4lpLCWJub3pz+Ng 3GYx6RRcMHkav1+wXzaEkXso88Hm94UkXb1P6fyrfgy0RsTEZWEDM8SPxgyA X-ME-Proxy: Feedback-ID: ib53e4b78:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 Nov 2026 11:10:35 -0500 (EST) From: Ian Bridges To: jan.koester@tuxist.de Cc: linkinjeon@kernel.org, senozhatsky@chromium.org, tom@talpey.com, chenxiaosong@chenxiaosong.com, brauner@kernel.org, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ian Bridges Subject: Re: [RFC PATCH 5/6] ksmbd: show classic users as S-1-22-1- on every server Date: Wed, 11 Nov 2026 10:10:29 -0600 Message-ID: <20261111161029.4128473-1-icb@fastmail.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Jan, On Tue, Nov 10, 2026 at 09:02:52AM +0000, Jan Koester wrote: > + else if (uid_is_legacy(uid)) > + id_to_sid(from_kuid_munged(&init_user_ns, uid), SIDUNIX_USER, ssid); smb_check_perm_dacl() seems to still build the caller's own SID in the old form. For a user other than root, would an ACE that a client writes for S-1-22-1- then match the user only through the token? If ksmbd_user_set_token() builds no token, as when its allocation fails in 4/6, would a deny ACE on the user in the new form stop applying? With a deny for S-1-22-1- followed by an allow for Everyone, the user would then get the access the deny should refuse. Thanks, Ian