Re: [PATCH v2 16/28] drm/panthor: Add AM_RESOURCE_GROUP support

[kernel test robot <lkp@intel.com>]

Hi Karunika,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm/drm-next drm-tip/drm-tip next-20261110]
[cannot apply to linux-review/Karunika-Choo/drm-panthor-Ignore-EOPNOTSUPP-for-shader-present-nvmem-lookup/20260922-214455 daeinki-drm-exynos/exynos-drm-next drm-i915/for-linux-next drm-i915/for-linux-next-fixes linus/master v7.4-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Karunika-Choo/drm-panthor-Ignore-EOPNOTSUPP-for-shader-present-nvmem-lookup/20261110-153822
base:   https://gitlab.freedesktop.org/drm/misc/kernel.git drm-misc-next
patch link:    https://lore.kernel.org/r/20261110153907.3241978-17-karunika.choo%40arm.com
patch subject: [PATCH v2 16/28] drm/panthor: Add AM_RESOURCE_GROUP support
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20261111/202611111629.kkrg6syk-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project e73e336290028f26553b46c9fba844c13da38c9c)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261111/202611111629.kkrg6syk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611111629.kkrg6syk-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/panthor/arbitration/panthor_resource_group.c:341:12: error: call to undeclared function 'irq_get_irq_data'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     341 |         irqdata = irq_get_irq_data(irq);
         |                   ^
   drivers/gpu/drm/panthor/arbitration/panthor_resource_group.c:341:12: note: did you mean 'irq_set_irq_wake'?
   include/linux/interrupt.h:486:12: note: 'irq_set_irq_wake' declared here
     486 | extern int irq_set_irq_wake(unsigned int irq, unsigned int on);
         |            ^
>> drivers/gpu/drm/panthor/arbitration/panthor_resource_group.c:341:10: error: incompatible integer to pointer conversion assigning to 'struct irq_data *' from 'int' [-Wint-conversion]
     341 |         irqdata = irq_get_irq_data(irq);
         |                 ^ ~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/panthor/arbitration/panthor_resource_group.c:343:15: error: call to undeclared function 'irqd_get_trigger_type'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     343 |                 irq_flags = irqd_get_trigger_type(irqdata);
         |                             ^
   3 errors generated.


vim +/irq_get_irq_data +341 drivers/gpu/drm/panthor/arbitration/panthor_resource_group.c

   284	
   285	static int resource_group_init(struct panthor_arbitration *adev, int i)
   286	{
   287		struct panthor_resource_group *rg;
   288		struct device *dev = adev->dev;
   289		struct irq_data *irqdata;
   290		struct resource *res;
   291		void __iomem *iomem;
   292		u32 irq_flags = 0;
   293		char *name;
   294		int irq;
   295		int ret;
   296	
   297		if (adev->rg[i])
   298			return dev_warn_probe(dev, -ENODEV,
   299					      "resource-group %u already present", i);
   300	
   301		rg = devm_kzalloc(dev, sizeof(*rg), GFP_KERNEL);
   302		if (!rg)
   303			return -ENOMEM;
   304	
   305		name = devm_kasprintf(dev, GFP_KERNEL, "rg%d", i);
   306		if (!name)
   307			return -ENOMEM;
   308	
   309		res = platform_get_resource_byname(to_platform_device(dev),
   310						   IORESOURCE_MEM, name);
   311		if (!res)
   312			return -ENODEV;
   313	
   314		iomem = devm_ioremap_resource(dev, res);
   315		if (IS_ERR(iomem))
   316			return dev_err_probe(dev, PTR_ERR(iomem), "%s: Failed to ioremap", name);
   317	
   318		rg->name = name;
   319		rg->dev = dev;
   320		rg->iomem = iomem;
   321	
   322		spin_lock_init(&rg->irq_lock);
   323		rg->irq_suspended = true;
   324	
   325		rg->wq = devm_alloc_ordered_workqueue(dev, "panthor-%s-wq", WQ_FREEZABLE, name);
   326		if (!rg->wq)
   327			return -ENOMEM;
   328	
   329		INIT_DELAYED_WORK(&rg->msg_retry_work, rg_retry_messages);
   330	
   331		for (int i = 0; i < AM_ARB_MAX_AW_COUNT; i++)
   332			panthor_am_msg_init(&rg->aw_data[i].msg,
   333					    rg->iomem + AM_RG_AW_MESSAGE(i));
   334	
   335		irq = platform_get_irq_byname(to_platform_device(dev), name);
   336		if (irq < 0)
   337			return irq;
   338	
   339		rg->irq = irq;
   340	
 > 341		irqdata = irq_get_irq_data(irq);
   342		if (irqdata)
 > 343			irq_flags = irqd_get_trigger_type(irqdata);
   344	
   345		ret = devm_request_irq(
   346			dev, irq, rg_irq_raw_handler, irq_flags | IRQF_SHARED,
   347			devm_kasprintf(dev, GFP_KERNEL, "panthor-%s-irq", name), rg);
   348		if (ret)
   349			return ret;
   350	
   351		adev->rg[i] = rg;
   352	
   353		rg_irq_resume(rg);
   354	
   355		rg_handshake_init(rg);
   356	
   357		return 0;
   358	}
   359	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki