mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aryan Sinha <sinha.aryan03@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/amdgpu: fix kernel-doc in amdgpu_ualink.c
Date: Wed, 11 Nov 2026 22:01:23 +0530	[thread overview]
Message-ID: <20261111163131.25965-1-sinha.aryan03@gmail.com> (raw)
In-Reply-To: <CADnq5_N7zDDuE-S6Jyg7q706H3SW6WuM4eOTBcEU90boYJG=PA@mail.gmail.com>

On Wed, Nov 11, 2026 at 11:21 AM Alex Deucher <alexdeucher@gmail.com> wrote:
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> for patch 1.  I'm skipping patch 2 because I find str_enable_disable()
> harder to understand and just as long to write as the current code.

Thanks for the review, Alex. For what it's worth, the helpers were meant to
keep these strings consistent across the tree, but it's your driver and
your call, so consider patch 2 dropped. Thanks! Have a nice day ahead.

Aryan

      reply	other threads:[~2026-11-11 16:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 15:06 Aryan Sinha
2026-11-04 15:06 ` [PATCH 2/2] drm/amdgpu: use str_enable_disable() in amdgpu_ualink_set_irq_state() Aryan Sinha
2026-11-11 16:21 ` [PATCH 1/2] drm/amdgpu: fix kernel-doc in amdgpu_ualink.c Alex Deucher
2026-11-11 16:31   ` Aryan Sinha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111163131.25965-1-sinha.aryan03@gmail.com \
    --to=sinha.aryan03@gmail.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®