From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794415287; b=4pc7biwXmwGB0aWiBncENcFx3aHWDDjj2ozU0aKOO0FyDXIFq7mqpR6W0bKNQRxLDST8 ivBhoTP/HoxVOrElUd30aCMbImmnoSQXg+47PNeRehM/HKs1ZFOVby/PkOOVwVT5PvFEm PJ1TxUR2LjV7LweU9mlJjbQm82gxPFAYpDaeIkowOYOfOBVEKzZn9MEM6zA8VcE4T8iEd mwjINOj+6XTWWwgP86SRATeUaLtTDigX5cPn5sNE9AcvprPS/Oce8oDw4/5dfYt/rQVv6 rt1MdBB9fcxVirfY0+9YiP8gsLLvEP84UR2SzGk7XGZeFJE57jqGzjfDJAAfACL7N4g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794415287; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:From:To:Cc:Subject:Date: Message-ID:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Scanned-By; bh=NX9FKH6K+UEomRB8px05FQHC/CI9W13+rfvS8/4IDW0=; b=CX4S4sJMhDnFyalflkR9ljh3TmT1V+dMmWJu+xH0tJjXeb4hw+6UH88vQgnjvIKAvz03 xdIZGVGhP4JMS2Usq8Bar/+bB64SBYrhrsOWu3nelpRm9g+wFmF1YSrN2MgFF2fZxhG+8 p+6I2CztrzMcEaZ8wgpzLCBggmXzGGVRpzd8DkwbhPen7cvZ3IwIsmyPikDbdDZbYO9ZQ wnu/j22PxPqtbSQUhGcLho/708VRlmAEii1SVDZSs9pPz/zvxqxf9MmIFp9l/RZFofshE kQbJpsZfpcOax0pEARrcDAkckxewEtnV4S+cbTMm2gYPef77zkJCTLkeGK6Oj6iWKBg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TGBoC6iw; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35000606A8BB for ; Wed, 11 Nov 2026 16:41:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 35000606A8BB Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TGBoC6iw DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794415286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NX9FKH6K+UEomRB8px05FQHC/CI9W13+rfvS8/4IDW0=; b=TGBoC6iwOAkKml+s4xqozq20tujaNzLZqazVIqqKMDGMQVZZxczmVAzZm7sHwS2lI4yN32 reY7QIPdvZ7VrPWpP64CvPy2Mi+ijC9vXAsa9HgJb71+x1Nl4KVLxKCtGqhGSMfILN1DTp 41hjtq8/c/PAWlG67wN5314j7dyBJT4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-udOd2yd0Nz--KgahitOCoA-1; Wed, 11 Nov 2026 11:41:20 -0500 X-MC-Unique: udOd2yd0Nz--KgahitOCoA-1 X-Mimecast-MFC-AGG-ID: udOd2yd0Nz--KgahitOCoA_1794415278 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D9C981955E7E; Wed, 11 Nov 2026 16:41:17 +0000 (UTC) Received: from ivecera-thinkpadp16vgen1.tpbc.csb (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 593AD410; Wed, 11 Nov 2026 16:41:12 +0000 (UTC) From: Ivan Vecera To: netdev@vger.kernel.org Cc: Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Jonathan Corbet , Shuah Khan , Randy Dunlap , Min Li , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Grzegorz Nitka , Karol Kolacinski , Saeed Mahameed , Tariq Toukan , Petr Oros Subject: [PATCH net-next v2 8/9] ice: dpll: update locking comments Date: Wed, 11 Nov 2026 17:40:19 +0100 Message-ID: <20261111164021.273409-9-ivecera@redhat.com> In-Reply-To: <20261111164021.273409-1-ivecera@redhat.com> References: <20261111164021.273409-1-ivecera@redhat.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Callbacks run under the DPLL core domain locks instead of dpll_lock. On E825 the TXC DPLL, the TSPLL DPLL and the other objects of a PF are in three domains, and callbacks of pins of an external DPLL run under the domain of that DPLL, so only pf->dplls.lock serializes them with each other. Reviewed-by: Petr Oros Signed-off-by: Ivan Vecera --- Changes in v2: - Described the three domains of an E825 PF (Sashiko) --- drivers/net/ethernet/intel/ice/ice_dpll.c | 4 ++-- drivers/net/ethernet/intel/ice/ice_dpll.h | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethernet/intel/ice/ice_dpll.c index 0877827a6521cc..5d0a52d86f03e8 100644 --- a/drivers/net/ethernet/intel/ice/ice_dpll.c +++ b/drivers/net/ethernet/intel/ice/ice_dpll.c @@ -1178,8 +1178,8 @@ ice_dpll_input_state_get(const struct dpll_pin *pin, void *pin_priv, * peer via dpll netlink learn about the update. * * Context: Called from dpll_pin_ops callbacks after pf->dplls.lock is - * released. Uses __dpll_pin_change_ntf() because dpll_lock is - * still held by the dpll netlink layer. + * released. Uses __dpll_pin_change_ntf() because the domain lock + * is still held by the dpll core. */ static void ice_dpll_sw_pin_notify_peer(struct ice_dplls *d, struct ice_dpll_pin *changed) diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.h b/drivers/net/ethernet/intel/ice/ice_dpll.h index bce0bea9a664bc..c522c5fcbcce52 100644 --- a/drivers/net/ethernet/intel/ice/ice_dpll.h +++ b/drivers/net/ethernet/intel/ice/ice_dpll.h @@ -164,6 +164,11 @@ struct ice_dpll { * tx_refclks usage map), acquire pf->dplls.lock first, then * ctrl_pf->dplls.lock. Skip the second acquire when pf == ctrl_pf * to avoid recursive locking. + * - The DPLL core serializes callbacks per (module, clock_id) domain. On + * E825 the TXC DPLL, the TSPLL DPLL and the other objects of a PF, such + * as the RCLK pin, use three different clock_ids, and callbacks of the + * SYNCE and TIME_REF pins of an external DPLL run under the domain of + * that DPLL, so only @lock serializes all of them with each other. * - @txclk_notify_rwsem is held for read across * ice_txclk_update_and_notify(), including the out-of-lock * dpll_*_change_ntf() calls. ice_dpll_deinit() takes the write side -- 2.56.0