From: Jakub Kicinski <kuba@kernel.org>
To: "Harry Yoo (Meta)" <harry@kernel.org>
Cc: Arthur Kiyanovski <akiyano@amazon.com>,
David Arinzon <darinzon@amazon.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Breno Leitao <leitao@debian.org>,
kernel-team@meta.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: ena: reuse the whole RX page on 64kB page kernels
Date: Wed, 11 Nov 2026 16:47:51 -0800 [thread overview]
Message-ID: <20261111164751.5ac643fa@kernel.org> (raw)
In-Reply-To: <20261106-ena-rx-reuse-64k-page-v1-1-ac75b20c5de8@kernel.org>
On Fri, 06 Nov 2026 03:17:11 +0000 Harry Yoo (Meta) wrote:
> This shows up when RX data stays in socket receive queues, as each
> queued skb keeps the whole 64kB page alive while at most 16kB of it
> holds data. On an EC2 t4g.large instance (64kB pages, 8GB memory) with
> 519MB left unread across 64 TCP sockets, RX pages pinned 2869MB of
> memory while the socket layer accounted only 687MB.
I'm not sure you're actually fixing the problem you're describing?
You optimize the memory use but the (unused) tail of the buffer is
still not charged to any skb, is it? Or does it now fit perfectly?
Normally when the page can no longer be chunked up we should charge
the tail to whoever happened to use it last (see the page pool code
which does that).
Either way, you have to respin this on top of Breno's fix which
was applied earlier today.
prev parent reply other threads:[~2026-11-12 0:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 3:17 Harry Yoo (Meta)
2026-11-06 10:09 ` Breno Leitao
2026-11-06 11:10 ` Harry Yoo
2026-11-12 0:47 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111164751.5ac643fa@kernel.org \
--to=kuba@kernel.org \
--cc=akiyano@amazon.com \
--cc=andrew+netdev@lunn.ch \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=harry@kernel.org \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®