From: Andrew Morton <akpm@linux-foundation.org>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: workflows@vger.kernel.org, ksummit@lists.linux.dev,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Mark Brown <broonie@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Leon Romanovsky <leon@kernel.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Thorsten Leemhuis <linux@leemhuis.info>,
"Michael S. Tsirkin" <mst@redhat.com>,
Kees Cook <kees@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Dan Carpenter <error27@gmail.com>,
Miguel Ojeda <ojeda@kernel.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Julia Lawall <julia.lawall@inria.fr>, SJ Park <sj@kernel.org>,
Bradley Morgan <brads@mainlining.org>,
Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v5 6/6] agents: add a skill to write KUnit tests
Date: Wed, 11 Nov 2026 17:12:38 -0800 [thread overview]
Message-ID: <20261111171238.7a974b89a2d9e793666b30df@linux-foundation.org> (raw)
In-Reply-To: <20261111225940.1573565-7-tytso@mit.edu>
On Wed, 11 Nov 2026 17:59:38 -0500 "Theodore Ts'o" <tytso@mit.edu> wrote:
> Add a skill under agents/skills/writing-kunit-tests/ to guide coding
> assistants when designing, implementing, verifying, or reviewing KUnit
> unit tests. Point the skill at the KUnit and process documentation and
> cover unit testing principles (testing behaviors rather than
> implementation details, keeping tests focused and DAMP, choosing
> non-default and distinct test values, using narrow expectations, and
> maintaining test isolation), KUnit resource management and static stub
> idioms, and verification with kunit.py.
>
> Update Documentation/process/coding-assistants.rst to list the new skill
> and note that skills only inspect and report unless their task is to
> write or modify code or tests.
>
> ...
>
> + KUNIT_DEFINE_ACTION_WRAPPER(my_resource_cleanup, my_resource_cleanup_wrapper,
> + struct my_resource *);
LLM says this should be
KUNIT_DEFINE_ACTION_WRAPPER(my_resource_cleanup_wrapper, my_resource_cleanup, struct my_resource *)
:)
prev parent reply other threads:[~2026-11-12 1:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 22:59 [PATCH v5 0/6] agents: add skills for Fixes tags, stable tags, similar bugs, and commit messages Theodore Ts'o
2026-11-11 22:59 ` [PATCH v5 1/6] agents: add infrastructure for agent resources Theodore Ts'o
2026-11-11 22:59 ` [PATCH v5 2/6] agents: add a skill to determine Fixes tags Theodore Ts'o
2026-11-11 22:59 ` [PATCH v5 3/6] agents: add a skill to determine stable tags Theodore Ts'o
2026-11-12 1:10 ` Andrew Morton
2026-11-11 22:59 ` [PATCH v5 4/6] agents: add a skill to find other instances of a fixed bug Theodore Ts'o
2026-11-11 22:59 ` [PATCH v5 5/6] agents: add a skill to write commit messages Theodore Ts'o
2026-11-11 22:59 ` [PATCH v5 6/6] agents: add a skill to write KUnit tests Theodore Ts'o
2026-11-12 0:57 ` Mauro Carvalho Chehab
2026-11-12 1:12 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111171238.7a974b89a2d9e793666b30df@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=brads@mainlining.org \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=error27@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=kees@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=ksummit@lists.linux.dev \
--cc=laurent.pinchart@ideasonboard.com \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=mst@redhat.com \
--cc=ojeda@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sashal@kernel.org \
--cc=sj@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®