From: Andrew Davis <afd@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Johan Hovold <johan@kernel.org>
Cc: <driver-core@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
"Andrew Davis" <afd@ti.com>
Subject: [PATCH 11/12] soc: versatile: realview: Use devm_soc_device_register() helper
Date: Wed, 11 Nov 2026 11:57:10 -0600 [thread overview]
Message-ID: <20261111175711.428824-12-afd@ti.com> (raw)
In-Reply-To: <20261111175711.428824-1-afd@ti.com>
Use the device lifecycle managed register function. This helps prevent
mistakes like unregistering out of order in cleanup functions and
forgetting to unregister on error paths.
Signed-off-by: Andrew Davis <afd@ti.com>
---
drivers/soc/versatile/soc-realview.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/soc/versatile/soc-realview.c b/drivers/soc/versatile/soc-realview.c
index addb8eb32f0d9..a0dc37ff9b376 100644
--- a/drivers/soc/versatile/soc-realview.c
+++ b/drivers/soc/versatile/soc-realview.c
@@ -82,13 +82,6 @@ static struct attribute *realview_attrs[] = {
ATTRIBUTE_GROUPS(realview);
-static void realview_soc_socdev_release(void *data)
-{
- struct soc_device *soc_dev = data;
-
- soc_device_unregister(soc_dev);
-}
-
static int realview_soc_probe(struct platform_device *pdev)
{
struct regmap *syscon_regmap;
@@ -113,15 +106,10 @@ static int realview_soc_probe(struct platform_device *pdev)
soc_dev_attr->machine = "RealView";
soc_dev_attr->family = "Versatile";
soc_dev_attr->custom_attr_group = realview_groups[0];
- soc_dev = soc_device_register(soc_dev_attr);
+ soc_dev = devm_soc_device_register(&pdev->dev, soc_dev_attr);
if (IS_ERR(soc_dev))
return -ENODEV;
- ret = devm_add_action_or_reset(&pdev->dev, realview_soc_socdev_release,
- soc_dev);
- if (ret)
- return ret;
-
ret = regmap_read(syscon_regmap, REALVIEW_SYS_ID_OFFSET,
&realview_coreid);
if (ret)
--
2.43.0
next prev parent reply other threads:[~2026-11-11 17:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 17:56 [PATCH 00/12] Add and use DEVM soc_device_register helper Andrew Davis
2026-11-11 17:57 ` [PATCH 01/12] base: soc: Implement devm_soc_device_register() helper function Andrew Davis
2026-11-11 17:57 ` [PATCH 02/12] soc: ep93xx: Use devm_soc_device_register() helper Andrew Davis
2026-11-11 17:57 ` [PATCH 03/12] soc: imx8m: " Andrew Davis
2026-11-11 17:57 ` [PATCH 04/12] soc: imx9: " Andrew Davis
2026-11-11 17:57 ` [PATCH 05/12] soc: loongson: " Andrew Davis
2026-11-11 17:57 ` [PATCH 06/12] soc: mediatek: mtk-socinfo: " Andrew Davis
2026-11-11 17:57 ` [PATCH 07/12] soc: qcom: socinfo: " Andrew Davis
2026-11-11 17:57 ` [PATCH 08/12] soc: renesas: rz-sysc: " Andrew Davis
2026-11-11 17:57 ` [PATCH 09/12] soc: samsung: exynos-chipid: " Andrew Davis
2026-11-11 17:57 ` [PATCH 10/12] soc: ti: k3-socinfo: " Andrew Davis
2026-11-11 17:57 ` Andrew Davis [this message]
2026-11-11 17:57 ` [PATCH 12/12] soc: vt8500: " Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111175711.428824-12-afd@ti.com \
--to=afd@ti.com \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®